Gamercat
/
geneva
mirror of https://github.com/Kkevsterrr/geneva
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

added comment justifying assignment of None change

This commit is contained in:
Frederick Sell 2023-01-23 13:52:45 -05:00 committed by GitHub
parent df7b2140a9
commit aadc7fa7dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
layers/dns_layer.py
View File

@ -164,6 +164,8 @@ class DNSLayer(Layer):
# Next, we must rebuild the DNS packet itself. If we try to have scapy parse either dns_qr1 or dns_qr2, they
# will look malformed, since neither contains a complete request. Therefore, we must build the entire
# DNS packet at once. First, we must remove the original DNSQR, since this contains the original request
# Need to set qd field to None instead of deleting it to be compatible with scapy 2.5
# deleting the qd field in scapy 2.5 causes the qd field to be populated with a question record for example.com
packet["DNS"].qd = None
# Once the DNSQR is removed, scapy automatically sets the qdcount to 0. Adjust it to 2