vk: fix missing skybox

ref/vk/TODO.md

@@ -1,3 +1,13 @@
+# 2023-10-30 E321
+- [x] missing skybox
+- [ ] explicitly free default textues; and complain about any leftovers
+- [ ] use the new hash table in materials too, remove dummy textures
+- [ ] why are there references to \*unused
+- [ ] massage texture code
+    - [ ] single return/goto cleanup
+    - [ ] pass args via structs?
+    - [ ] collapse texture uploading into a single function
+
 # 2023-10-27 E320
 - [x] fix windows build
 - [x] track texture visibility for ref_api via flag and refcounts
@@ -7,16 +17,10 @@
 - [x] check urmom stats after a few different changelevels
     - [x] COUNT(IS_DELETED)
     - [x] clusters size histogram
-- [ ] silence logs
+- [x] silence logs
     - [x] "accessing empty texture"
     - [x] "found existing texture"
-    - [ ] ..
-- [ ] check mips
-- [ ] massage texture code
-    - [ ] single return/goto cleanup
-    - [ ] pass args via structs?
-    - [ ] collapse texture uploading into a single function
-- [ ] why are there references to \*unused
+- [x] check mips
 
 # 2023-10-26 E319
 - [x] fix pbr materials disappearing

ref/vk/r_textures.c

@@ -932,8 +932,7 @@ static qboolean loadSkybox( const char *prefix, int style ) {
 	if( !checkTextureName( prefix ))
 		goto cleanup;
 
-
-	R_VkTexturesSkyboxUpload( prefix, sides, kColorspaceGamma, false );
+	success = R_VkTexturesSkyboxUpload( prefix, sides, kColorspaceGamma, false );
 
 cleanup:
 	for (int j = 0; j < i; ++j)