2016-01-01 05:33:14 +01:00
|
|
|
# Copyright 2011-2016 Free Software Foundation, Inc.
|
2011-04-01 18:59:58 +02:00
|
|
|
#
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
#
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
load_lib "ada.exp"
|
|
|
|
|
2012-07-26 20:43:02 +02:00
|
|
|
standard_ada_testfile foo
|
2011-04-01 18:59:58 +02:00
|
|
|
|
|
|
|
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnata ]] != "" } {
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
|
|
|
|
# Some global variables used to simplify the maintenance of some of
|
|
|
|
# the regular expressions below.
|
|
|
|
set any_nb "\[0-9\]+"
|
|
|
|
set eol "\[\r\n\]+"
|
|
|
|
|
|
|
|
# Before going any further, verify that we can insert exception
|
|
|
|
# catchpoints... That way, we won't have to do this while doing
|
|
|
|
# the actual GDB/MI testing.
|
|
|
|
|
|
|
|
clean_restart ${testfile}
|
|
|
|
|
|
|
|
if ![runto_main] then {
|
|
|
|
fail "Cannot run to main, testcase aborted"
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
|
|
|
set msg "insert catchpoint on all Ada exceptions"
|
|
|
|
gdb_test_multiple "catch exception" $msg {
|
|
|
|
-re "Catchpoint $any_nb: all Ada exceptions$eol$gdb_prompt $" {
|
|
|
|
pass $msg
|
|
|
|
}
|
2011-12-11 18:36:10 +01:00
|
|
|
-re "Your Ada runtime appears to be missing some debugging information.*\[\r\n\]+$gdb_prompt $" {
|
2011-04-01 18:59:58 +02:00
|
|
|
# If the runtime was not built with enough debug information,
|
|
|
|
# or if it was stripped, we can not test exception
|
|
|
|
# catchpoints.
|
|
|
|
unsupported $msg
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
# Now, we can start the GDB/MI testing itself...
|
|
|
|
|
|
|
|
load_lib mi-support.exp
|
|
|
|
set MIFLAGS "-i=mi"
|
|
|
|
|
|
|
|
gdb_exit
|
|
|
|
if [mi_gdb_start] {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
mi_delete_breakpoints
|
|
|
|
mi_gdb_reinitialize_dir $srcdir/$subdir
|
|
|
|
mi_gdb_load ${binfile}
|
|
|
|
|
|
|
|
####################################
|
|
|
|
# 1. Try catching all exceptions. #
|
|
|
|
####################################
|
|
|
|
|
|
|
|
if ![mi_run_to_main] then {
|
|
|
|
fail "Cannot run to main, testcase aborted"
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
2013-10-11 15:49:36 +02:00
|
|
|
mi_gdb_test "-catch-exception" \
|
|
|
|
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",addr=\"$hex\",what=\"all Ada exceptions\",.*}" \
|
|
|
|
"catch all exceptions"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
[Ada catchpoints] Fix "warning: failed to get exception name: No definition of \"e.full_name\" in current context"
Looking at testsuite results, I noticed this warning in an MI test:
~"\nCatchpoint "
~"2, "
&"warning: failed to get exception name: No definition of \"e.full_name\" in current context.\n"
~"exception at 0x000000000040192d in foo () at /home/pedro/brno/pedro/gdb/mygit/src/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb:20\n"
~"20\t raise Constraint_Error; -- SPOT1\n"
*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",exception-name="CONSTRAINT_ERROR",frame={addr="0x000000000040192d",func="foo",args=[],file="/home/pedro/brno/pedro/gdb/mygit/src/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",fullname="/home/pedro/brno/pedro/gdb/mygit/src/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",line="20"},thread-id="1",stopped-threads="all",core="5"
(gdb)
PASS: gdb.ada/mi_catch_ex.exp: continue until CE caught by all-exceptions catchpoint
The problem is that:
- MI prints the breakpoint hit twice: once on the MI stream;
another time on the console stream.
- After printing the Ada catchpoint hit, gdb selects a non-current
frame, from within the catchpoint's print_it routine.
So the second time the breakpoint is printed, the selected frame is no
longer the current frame, and then evaluating e.full_name in
ada_exception_name_addr fails.
This commit fixes the problem and enhances the gdb.ada/mi_catch_ex.exp
test to make sure the catchpoint hit is printed correctly on the
console stream too.
gdb/ChangeLog:
2016-06-21 Pedro Alves <palves@redhat.com>
* ada-lang.c (ada_exception_name_addr_1): Add comment.
(print_it_exception): Select the current frame.
gdb/testsuite/ChangeLog:
2016-06-21 Pedro Alves <palves@redhat.com>
* gdb.ada/mi_catch_ex.exp (continue_to_exception): New procedure.
(top level): Use it instead of mi_execute_to.
2016-06-21 02:11:43 +02:00
|
|
|
# Continue to caught exception.
|
|
|
|
|
|
|
|
proc continue_to_exception { exception_name test } {
|
|
|
|
global hex any_nb
|
|
|
|
|
|
|
|
mi_send_resuming_command "exec-continue" "$test"
|
|
|
|
|
|
|
|
# Match console stream output.
|
|
|
|
gdb_expect {
|
|
|
|
-re " $exception_name at $hex in foo " {
|
|
|
|
}
|
|
|
|
timeout {
|
|
|
|
fail "$test (timeout)"
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
# Now MI stream output.
|
|
|
|
mi_expect_stop \
|
|
|
|
"breakpoint-hit\",disp=\"keep\",bkptno=\"$any_nb\",exception-name=\"$exception_name" \
|
|
|
|
"foo" "" ".*" ".*" \
|
|
|
|
".*" \
|
|
|
|
$test
|
|
|
|
}
|
|
|
|
|
|
|
|
continue_to_exception \
|
|
|
|
"CONSTRAINT_ERROR" \
|
|
|
|
"continue until CE caught by all-exceptions catchpoint"
|
|
|
|
|
|
|
|
continue_to_exception \
|
|
|
|
"PROGRAM_ERROR" \
|
|
|
|
"continue until PE caught by all-exceptions catchpoint"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
|
|
|
################################################
|
|
|
|
# 2. Try catching only some of the exceptions. #
|
|
|
|
################################################
|
|
|
|
|
|
|
|
# Here is the scenario:
|
|
|
|
# - Restart the debugger from scratch, runto_main
|
|
|
|
# - We'll catch only "Program_Error"
|
|
|
|
# We'll catch assertions
|
|
|
|
# We'll catch unhandled exceptions
|
|
|
|
# - continue, we should see the first Program_Error exception
|
|
|
|
# - continue, we should see the failed assertion
|
|
|
|
# - continue, we should see the unhandled Constrait_Error exception
|
|
|
|
# - continue, the program exits.
|
|
|
|
|
|
|
|
if ![mi_run_to_main] then {
|
|
|
|
fail "Cannot run to main, testcase aborted"
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
2013-10-11 15:49:36 +02:00
|
|
|
mi_gdb_test "-catch-exception -e Program_Error" \
|
|
|
|
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",addr=\"$hex\",what=\"`Program_Error' Ada exception\",.*}" \
|
|
|
|
"catch Program_Error"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
2013-10-11 15:49:36 +02:00
|
|
|
mi_gdb_test "-catch-assert" \
|
|
|
|
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",addr=\"$hex\",what=\"failed Ada assertions\",.*}" \
|
|
|
|
"catch assert failures"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
2013-10-11 15:49:36 +02:00
|
|
|
mi_gdb_test "-catch-exception -u" \
|
|
|
|
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",addr=\"$hex\",what=\"unhandled Ada exceptions\",.*}" \
|
|
|
|
"catch unhandled exceptions"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
|
|
|
mi_execute_to "exec-continue" \
|
|
|
|
"breakpoint-hit\",disp=\"keep\",bkptno=\"$any_nb\",exception-name=\"PROGRAM_ERROR" \
|
|
|
|
"foo" "" ".*" ".*" \
|
|
|
|
".*" \
|
|
|
|
"continue to exception catchpoint hit"
|
|
|
|
|
|
|
|
mi_execute_to "exec-continue" \
|
|
|
|
"breakpoint-hit\",disp=\"keep\",bkptno=\"$any_nb" \
|
|
|
|
"foo" "" ".*" ".*" \
|
|
|
|
".*" \
|
2013-10-08 12:25:22 +02:00
|
|
|
"continue to assert failure catchpoint hit"
|
2011-04-01 18:59:58 +02:00
|
|
|
|
|
|
|
mi_execute_to "exec-continue" \
|
|
|
|
"breakpoint-hit\",disp=\"keep\",bkptno=\"$any_nb\",exception-name=\"CONSTRAINT_ERROR" \
|
|
|
|
"foo" "" ".*" ".*" \
|
|
|
|
".*" \
|
2013-10-08 12:25:22 +02:00
|
|
|
"continue to unhandled exception catchpoint hit"
|
2011-04-01 18:59:58 +02:00
|
|
|
|