1999-05-11 22:29:07 +02:00
|
|
|
/* Definitions used by the GDB event loop.
|
2017-01-01 07:50:51 +01:00
|
|
|
Copyright (C) 1999-2017 Free Software Foundation, Inc.
|
1999-05-11 22:29:07 +02:00
|
|
|
Written by Elena Zannoni <ezannoni@cygnus.com> of Cygnus Solutions.
|
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
2007-08-23 20:08:50 +02:00
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
1999-05-11 22:29:07 +02:00
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
2007-08-23 20:08:50 +02:00
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
1999-05-11 22:29:07 +02:00
|
|
|
|
2010-12-29 01:58:14 +01:00
|
|
|
/* An event loop listens for events from multiple event sources. When
|
1999-05-11 22:29:07 +02:00
|
|
|
an event arrives, it is queued and processed by calling the
|
2010-12-29 01:58:14 +01:00
|
|
|
appropriate event handler. The event loop then continues to listen
|
|
|
|
for more events. An event loop completes when there are no event
|
1999-05-11 22:29:07 +02:00
|
|
|
sources to listen on. External event sources can be plugged into
|
|
|
|
the loop.
|
|
|
|
|
2008-10-24 21:33:39 +02:00
|
|
|
There are 4 main components:
|
2010-12-29 01:58:14 +01:00
|
|
|
- a list of file descriptors to be monitored, GDB_NOTIFIER.
|
2008-10-24 21:33:39 +02:00
|
|
|
- a list of asynchronous event sources to be monitored,
|
|
|
|
ASYNC_EVENT_HANDLER_LIST.
|
2010-12-29 01:58:14 +01:00
|
|
|
- a list of events that have occurred, EVENT_QUEUE.
|
1999-05-11 22:29:07 +02:00
|
|
|
- a list of signal handling functions, SIGHANDLER_LIST.
|
|
|
|
|
2008-10-24 21:33:39 +02:00
|
|
|
GDB_NOTIFIER keeps track of the file descriptor based event
|
|
|
|
sources. ASYNC_EVENT_HANDLER_LIST keeps track of asynchronous
|
|
|
|
event sources that are signalled by some component of gdb, usually
|
|
|
|
a target_ops instance. Event sources for gdb are currently the UI
|
|
|
|
and the target. Gdb communicates with the command line user
|
|
|
|
interface via the readline library and usually communicates with
|
|
|
|
remote targets via a serial port. Serial ports are represented in
|
|
|
|
GDB as file descriptors and select/poll calls. For native targets
|
|
|
|
instead, the communication varies across operating system debug
|
|
|
|
APIs, but usually consists of calls to ptrace and waits (via
|
|
|
|
signals) or calls to poll/select (via file descriptors). In the
|
|
|
|
current gdb, the code handling events related to the target resides
|
|
|
|
in wait_for_inferior for synchronous targets; or, for asynchronous
|
|
|
|
capable targets, by having the target register either a target
|
|
|
|
controlled file descriptor and/or an asynchronous event source in
|
|
|
|
the event loop, with the fetch_inferior_event function as the event
|
|
|
|
callback. In both the synchronous and asynchronous cases, usually
|
|
|
|
the target event is collected through the target_wait interface.
|
|
|
|
The target is free to install other event sources in the event loop
|
|
|
|
if it so requires.
|
1999-05-11 22:29:07 +02:00
|
|
|
|
|
|
|
EVENT_QUEUE keeps track of the events that have happened during the
|
|
|
|
last iteration of the event loop, and need to be processed. An
|
|
|
|
event is represented by a procedure to be invoked in order to
|
|
|
|
process the event. The queue is scanned head to tail. If the
|
|
|
|
event of interest is a change of state in a file descriptor, then a
|
|
|
|
call to poll or select will be made to detect it.
|
|
|
|
|
|
|
|
If the events generate signals, they are also queued by special
|
|
|
|
functions that are invoked through traditional signal handlers.
|
|
|
|
The actions to be taken is response to such events will be executed
|
|
|
|
when the SIGHANDLER_LIST is scanned, the next time through the
|
2010-12-29 01:58:14 +01:00
|
|
|
infinite loop.
|
1999-05-11 22:29:07 +02:00
|
|
|
|
2010-12-29 01:58:14 +01:00
|
|
|
Corollary tasks are the creation and deletion of event sources. */
|
1999-05-11 22:29:07 +02:00
|
|
|
|
2000-03-03 16:37:09 +01:00
|
|
|
typedef void *gdb_client_data;
|
1999-09-22 05:28:34 +02:00
|
|
|
struct async_signal_handler;
|
2008-10-24 21:33:39 +02:00
|
|
|
struct async_event_handler;
|
1999-10-06 01:13:56 +02:00
|
|
|
typedef void (handler_func) (int, gdb_client_data);
|
1999-09-22 05:28:34 +02:00
|
|
|
typedef void (sig_handler_func) (gdb_client_data);
|
2008-10-24 21:33:39 +02:00
|
|
|
typedef void (async_event_handler_func) (gdb_client_data);
|
1999-09-22 05:28:34 +02:00
|
|
|
typedef void (timer_handler_func) (gdb_client_data);
|
1999-05-11 22:29:07 +02:00
|
|
|
|
1999-06-28 18:06:02 +02:00
|
|
|
/* Exported functions from event-loop.c */
|
1999-06-14 20:08:47 +02:00
|
|
|
|
1999-09-22 05:28:34 +02:00
|
|
|
extern void start_event_loop (void);
|
2011-08-04 22:09:46 +02:00
|
|
|
extern int gdb_do_one_event (void);
|
1999-09-22 05:28:34 +02:00
|
|
|
extern void delete_file_handler (int fd);
|
2010-12-29 01:58:14 +01:00
|
|
|
extern void add_file_handler (int fd, handler_func *proc,
|
|
|
|
gdb_client_data client_data);
|
1999-09-28 23:55:21 +02:00
|
|
|
extern struct async_signal_handler *
|
2010-12-29 01:58:14 +01:00
|
|
|
create_async_signal_handler (sig_handler_func *proc,
|
|
|
|
gdb_client_data client_data);
|
2011-01-05 23:22:53 +01:00
|
|
|
extern void delete_async_signal_handler (struct async_signal_handler **);
|
2010-12-29 01:58:14 +01:00
|
|
|
extern int create_timer (int milliseconds,
|
|
|
|
timer_handler_func *proc,
|
|
|
|
gdb_client_data client_data);
|
1999-09-22 05:28:34 +02:00
|
|
|
extern void delete_timer (int id);
|
2008-03-05 18:21:10 +01:00
|
|
|
|
2016-04-12 17:49:32 +02:00
|
|
|
/* Call the handler from HANDLER the next time through the event
|
|
|
|
loop. */
|
|
|
|
extern void mark_async_signal_handler (struct async_signal_handler *handler);
|
2008-03-05 18:21:10 +01:00
|
|
|
|
remote: allow aborting long operations (e.g., file transfers)
Currently, when remote debugging, if you type Ctrl-C just while the
target stopped for an internal event, and GDB is busy doing something
that takes a while (e.g., fetching chunks of a shared library off of
the target, with vFile, to process ELF headers and debug info), the
Ctrl-C is lost.
The patch hooks up the QUIT macro to a new target method that lets the
target react to the double-Ctrl-C before the event loop is reached,
which allows reacting to a double-Ctrl-C even when GDB is busy doing
some long operation and not waiting for a stop reply. That end result
is:
(gdb) c
Continuing.
^C
^C
Interrupted while waiting for the program.
Give up waiting? (y or n) y
Quit
(gdb) info threads
Id Target Id Frame
* 1 Thread 11673 0x00007ffff7deb240 in _dl_debug_state () from target:/lib64/ld-linux-x86-64.so.2
(gdb)
If, however, GDB is waiting for a stop reply (because the target has
been resumed, with e.g., vCont;c), but the target isn't responding, we
now get:
(gdb) c
Continuing.
^C
^C
The target is not responding to interrupt requests.
Stop debugging it? (y or n) y
Disconnected from target.
(gdb) info threads
No threads.
This offers to disconnect, because when we're waiting for a stop
reply, there's nothing else we can send the target other than an
interrupt request. And if that doesn't work, there's nothing else we
can do.
The Ctrl-C is presently lost because until we get to a user-visible
stop, the SIGINT handler that is installed is the one that forwards
the interrupt to the remote side, with the \003 "packet" [1]. But,
gdbserver ignores an interrupt request if the program is stopped.
Still, even if it didn't, the server can only report back a
stop-because-of-SIGINT when the program is next resumed. And it may
take a while to actually re-resume the target.
[1] - In the old sync days, the remote target would react to a
double-Ctrl-C by asking users whether they wanted to give up waiting
and disconnect. The code is still there, but it it isn't reacheable
on most hosts, which support serial connections in async mode
(probably only DJGPP doesn't). Even then, in sync mode, remote.c's
SIGINT handler is only installed while the target is resumed, and is
removed as soon as the target sends back a stop reply. That means
that a Ctrl-C just while GDB is processing an internal event can end
up with an odd "Quit" at the prompt instead of "Program stopped by
SIGINT". In contrast, in async mode, remote.c's SIGINT handler is set
up as long as target_terminal_inferior or
target_terminal_ours_for_output are in effect (IOW, until we get a
user-visible stop and call target_terminal_ours), so the user
shouldn't get back a spurious Quit. However, it's still desirable to
be able to interrupt a long-running GDB operation, if GDB takes a
while to re-resume the target or get back to the event loop.
Tested on x86_64 Fedora 20.
gdb/ChangeLog:
2015-08-24 Pedro Alves <palves@redhat.com>
* defs.h (maybe_quit): Declare.
(QUIT): Now calls maybe_quit.
* event-loop.c (clear_async_signal_handler)
(async_signal_handler_is_marked): New functions.
* event-loop.h (async_signal_handler_is_marked)
(clear_async_signal_handler): New declarations.
* remote.c (remote_check_pending_interrupt): New function.
(interrupt_query): Use make_cleanup_restore_target_terminal. No
longer check whether the target is async. If waiting for a stop
reply, and a Ctrl-C as been sent to the target, offer to
disconnect, and throw TARGET_CLOSE_ERROR instead of a quit.
Otherwise do not disconnect and throw a quit.
(_initialize_remote): Install remote_check_pending_interrupt as
to_check_pending_interrupt.
* target.c (target_check_pending_interrupt): New function.
* target.h (struct target_ops) <to_check_pending_interrupt>: New
field.
(target_check_pending_interrupt): New declaration.
* utils.c (maybe_quit): New function.
* target-delegates.c: Regenerate.
2015-08-25 17:12:11 +02:00
|
|
|
/* Returns true if HANDLER is marked ready. */
|
|
|
|
|
|
|
|
extern int
|
|
|
|
async_signal_handler_is_marked (struct async_signal_handler *handler);
|
|
|
|
|
|
|
|
/* Mark HANDLER as NOT ready. */
|
|
|
|
|
|
|
|
extern void clear_async_signal_handler (struct async_signal_handler *handler);
|
|
|
|
|
2008-10-24 21:33:39 +02:00
|
|
|
/* Create and register an asynchronous event source in the event loop,
|
|
|
|
and set PROC as its callback. CLIENT_DATA is passed as argument to
|
|
|
|
PROC upon its invocation. Returns a pointer to an opaque structure
|
|
|
|
used to mark as ready and to later delete this event source from
|
|
|
|
the event loop. */
|
|
|
|
extern struct async_event_handler *
|
|
|
|
create_async_event_handler (async_event_handler_func *proc,
|
|
|
|
gdb_client_data client_data);
|
|
|
|
|
|
|
|
/* Remove the event source pointed by HANDLER_PTR created by
|
|
|
|
CREATE_ASYNC_EVENT_HANDLER from the event loop, and release it. */
|
|
|
|
extern void
|
|
|
|
delete_async_event_handler (struct async_event_handler **handler_ptr);
|
|
|
|
|
|
|
|
/* Call the handler from HANDLER the next time through the event
|
|
|
|
loop. */
|
|
|
|
extern void mark_async_event_handler (struct async_event_handler *handler);
|
When disabling target async, remove all target event sources from the event loop
The sigall-reverse.exp test occasionally fails with something like this:
(gdb) PASS: gdb.reverse/sigall-reverse.exp: send signal TERM
continue
Continuing.
The next instruction is syscall exit_group. It will make the program exit. Do you want to stop the program?([y] or n) FAIL: gdb.reverse/sigall-reverse.exp: continue to signal exit (timeout)
FAIL: gdb.reverse/sigall-reverse.exp: reverse to handler of TERM (timeout)
FAIL: gdb.reverse/sigall-reverse.exp: reverse to gen_TERM (timeout)
This is another event-loop/async related problem exposed by the patch
that made 'query' use gdb_readline_wrapper (588dcc3edbde19f9).
The problem is that even though gdb_readline_wrapper disables
target-async while the secondary prompt is in progress, the record
target's async event source is left marked. So when
gdb_readline_wrapper nests an event loop to process input, it may
happen that that event loop ends up processing a target event while
GDB is not really ready for it. Here's the relevant part of the
backtrace showing the root issue in action:
...
#14 0x000000000061cb48 in fetch_inferior_event (client_data=0x0) at src/gdb/infrun.c:4158
#15 0x0000000000642917 in inferior_event_handler (event_type=INF_REG_EVENT, client_data=0x0) at src/gdb/inf-loop.c:57
#16 0x000000000077ca5c in record_full_async_inferior_event_handler (data=0x0) at src/gdb/record-full.c:791
#17 0x0000000000640fdf in invoke_async_event_handler (data=...) at src/gdb/event-loop.c:1067
#18 0x000000000063fb01 in process_event () at src/gdb/event-loop.c:339
#19 0x000000000063fb2a in gdb_do_one_event () at src/gdb/event-loop.c:360
#20 0x000000000074d607 in gdb_readline_wrapper (prompt=0x3588f40 "The next instruction is syscall exit_group. It will make the program exit. Do you want to stop the program?([y] or n) ") at src/gdb/top.c:842
#21 0x0000000000750bd9 in defaulted_query (ctlstr=0x8c6588 "The next instruction is syscall exit_group. It will make the program exit. Do you want to stop the program?", defchar=121 'y', args=0x7fff70524410) at src/gdb/utils.c:1279
#22 0x0000000000750e4c in yquery (ctlstr=0x8c6588 "The next instruction is syscall exit_group. It will make the program exit. Do you want to stop the program?") at src/gdb/utils.c:1358
#23 0x00000000004b020e in record_linux_system_call (syscall=gdb_sys_exit_group, regcache=0x3529450, tdep=0xd6c840 <amd64_linux_record_tdep>) at src/gdb/linux-record.c:1933
With my all-stop-on-top-of-non-stop series, I'm also seeing
gdb.server/ext-attach.exp fail occasionally due to the same issue.
The first part of the fix is for target_async implementations to make
sure to remove/unmark all target-related event sources from the event
loop.
Tested on x86_64 Fedora 20, native and gdbserver.
gdb/
2015-02-03 Pedro Alves <palves@redhat.com>
* event-loop.c (clear_async_event_handler): New function.
* event-loop.h (clear_async_event_handler): New declaration.
* record-btrace.c (record_btrace_async): New function.
(init_record_btrace_ops): Install record_btrace_async.
* record-full.c (record_full_async): New function.
(record_full_resume): Don't mark the async event source here.
(init_record_full_ops): Install record_full_async.
(record_full_core_resume): Don't mark the async event source here.
(init_record_full_core_ops): Install record_full_async.
* remote.c (remote_async): Mark and clear the async stop reply
queue event-loop token as appropriate.
2015-02-03 16:07:54 +01:00
|
|
|
|
|
|
|
/* Mark the handler (ASYNC_HANDLER_PTR) as NOT ready. */
|
|
|
|
|
|
|
|
extern void clear_async_event_handler (struct async_event_handler *handler);
|
Fix signal handler/event-loop races
GDB's core signal handling suffers from a classical signal handler /
mainline code race:
int
gdb_do_one_event (void)
{
...
/* First let's see if there are any asynchronous signal handlers
that are ready. These would be the result of invoking any of the
signal handlers. */
if (invoke_async_signal_handlers ())
return 1;
...
/* Block waiting for a new event. (...). */
if (gdb_wait_for_event (1) < 0)
return -1;
...
}
If a signal is delivered while gdb is blocked in the poll/select
inside gdb_wait_for_event, then the select/poll breaks with EINTR,
we'll loop back around and call invoke_async_signal_handlers.
However, if the signal handler runs between
invoke_async_signal_handlers and gdb_wait_for_event,
gdb_wait_for_event will block, until the next unrelated event...
The fix is to a struct serial_event, and register it in the set of
files that select/poll in gdb_wait_for_event waits on. The signal
handlers that defer work to invoke_async_signal_handlers call
mark_async_signal_handler, which is adjusted to also set the new
serial event in addition to setting a flag, and is thus now is
garanteed to immediately unblock the next gdb_select/poll call, up
until invoke_async_signal_handlers is called and the event is cleared.
gdb/ChangeLog:
2016-04-12 Pedro Alves <palves@redhat.com>
* event-loop.c: Include "ser-event.h".
(async_signal_handlers_serial_event): New global.
(async_signals_handler, initialize_async_signal_handlers): New
functions.
(mark_async_signal_handler): Set
async_signal_handlers_serial_event.
(invoke_async_signal_handlers): Clear
async_signal_handlers_serial_event.
* event-top.c (async_init_signals): Call
initialize_async_signal_handlers.
2016-04-12 17:49:30 +02:00
|
|
|
|
|
|
|
extern void initialize_async_signal_handlers (void);
|