1999-04-16 03:35:26 +02:00
|
|
|
/* Support for complaint handling during symbol reading in GDB.
|
2002-09-19 02:42:41 +02:00
|
|
|
|
2004-07-28 19:26:27 +02:00
|
|
|
Copyright 1990, 1991, 1992, 1993, 1995, 1998, 1999, 2000, 2002,
|
|
|
|
2004 Free Software Foundation, Inc.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
1999-07-07 22:19:36 +02:00
|
|
|
This file is part of GDB.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
1999-07-07 22:19:36 +02:00
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
1999-07-07 22:19:36 +02:00
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
1999-07-07 22:19:36 +02:00
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program; if not, write to the Free Software
|
|
|
|
Foundation, Inc., 59 Temple Place - Suite 330,
|
|
|
|
Boston, MA 02111-1307, USA. */
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
#include "defs.h"
|
|
|
|
#include "complaints.h"
|
2002-09-19 02:42:41 +02:00
|
|
|
#include "gdb_assert.h"
|
|
|
|
#include "command.h"
|
1999-04-16 03:35:26 +02:00
|
|
|
#include "gdbcmd.h"
|
|
|
|
|
2000-05-28 03:12:42 +02:00
|
|
|
extern void _initialize_complaints (void);
|
1999-05-25 20:09:09 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
/* Should each complaint message be self explanatory, or should we assume that
|
|
|
|
a series of complaints is being produced? */
|
|
|
|
|
|
|
|
/* case 1: First message of a series that must
|
|
|
|
start off with explanation. case 2: Subsequent message of a series
|
|
|
|
that needs no explanation (the user already knows we have a problem
|
|
|
|
so we can just state our piece). */
|
|
|
|
enum complaint_series {
|
|
|
|
/* Isolated self explanatory message. */
|
|
|
|
ISOLATED_MESSAGE,
|
|
|
|
/* First message of a series, includes an explanation. */
|
|
|
|
FIRST_MESSAGE,
|
|
|
|
/* First message of a series, but does not need to include any sort
|
|
|
|
of explanation. */
|
|
|
|
SHORT_FIRST_MESSAGE,
|
|
|
|
/* Subsequent message of a series that needs no explanation (the
|
|
|
|
user already knows we have a problem so we can just state our
|
|
|
|
piece). */
|
|
|
|
SUBSEQUENT_MESSAGE
|
|
|
|
};
|
|
|
|
|
1999-04-16 03:35:26 +02:00
|
|
|
/* Structure to manage complaints about symbol file contents. */
|
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
struct complain
|
1999-07-07 22:19:36 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
const char *file;
|
|
|
|
int line;
|
|
|
|
const char *fmt;
|
|
|
|
int counter;
|
|
|
|
struct complain *next;
|
1999-04-16 03:35:26 +02:00
|
|
|
};
|
|
|
|
|
2003-07-15 17:36:13 +02:00
|
|
|
/* The explanatory message that should accompany the complaint. The
|
|
|
|
message is in two parts - pre and post - that are printed around
|
|
|
|
the complaint text. */
|
|
|
|
struct explanation
|
|
|
|
{
|
|
|
|
const char *prefix;
|
|
|
|
const char *postfix;
|
|
|
|
};
|
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
struct complaints
|
|
|
|
{
|
|
|
|
struct complain *root;
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
/* Should each complaint be self explanatory, or should we assume
|
|
|
|
that a series of complaints is being produced? case 0: Isolated
|
|
|
|
self explanatory message. case 1: First message of a series that
|
|
|
|
must start off with explanation. case 2: Subsequent message of a
|
|
|
|
series that needs no explanation (the user already knows we have
|
|
|
|
a problem so we can just state our piece). */
|
|
|
|
int series;
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
/* The explanatory messages that should accompany the complaint.
|
|
|
|
NOTE: cagney/2002-08-14: In a desperate attempt at being vaguely
|
|
|
|
i18n friendly, this is an array of two messages. When present,
|
2003-07-15 17:36:13 +02:00
|
|
|
the PRE and POST EXPLANATION[SERIES] are used to wrap the
|
|
|
|
message. */
|
|
|
|
const struct explanation *explanation;
|
2002-09-19 02:42:41 +02:00
|
|
|
};
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
static struct complain complaint_sentinel;
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
/* The symbol table complaint table. */
|
1999-07-07 22:19:36 +02:00
|
|
|
|
2003-07-15 17:36:13 +02:00
|
|
|
static struct explanation symfile_explanations[] = {
|
|
|
|
{ "During symbol reading, ", "." },
|
|
|
|
{ "During symbol reading...", "..."},
|
|
|
|
{ "", "..."},
|
|
|
|
{ "", "..."},
|
|
|
|
{ NULL, NULL }
|
2002-09-19 02:42:41 +02:00
|
|
|
};
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
static struct complaints symfile_complaint_book = {
|
|
|
|
&complaint_sentinel,
|
|
|
|
0,
|
|
|
|
symfile_explanations
|
|
|
|
};
|
|
|
|
struct complaints *symfile_complaints = &symfile_complaint_book;
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
/* Wrapper function to, on-demand, fill in a complaints object. */
|
|
|
|
|
|
|
|
static struct complaints *
|
|
|
|
get_complaints (struct complaints **c)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
if ((*c) != NULL)
|
|
|
|
return (*c);
|
|
|
|
(*c) = XMALLOC (struct complaints);
|
|
|
|
(*c)->root = &complaint_sentinel;
|
|
|
|
(*c)->series = ISOLATED_MESSAGE;
|
|
|
|
(*c)->explanation = NULL;
|
|
|
|
return (*c);
|
|
|
|
}
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
static struct complain *
|
|
|
|
find_complaint (struct complaints *complaints, const char *file,
|
|
|
|
int line, const char *fmt)
|
|
|
|
{
|
|
|
|
struct complain *complaint;
|
|
|
|
|
|
|
|
/* Find the complaint in the table. A more efficient search
|
|
|
|
algorithm (based on hash table or something) could be used. But
|
|
|
|
that can wait until someone shows evidence that this lookup is
|
|
|
|
a real bottle neck. */
|
|
|
|
for (complaint = complaints->root;
|
|
|
|
complaint != NULL;
|
|
|
|
complaint = complaint->next)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
if (complaint->fmt == fmt
|
|
|
|
&& complaint->file == file
|
|
|
|
&& complaint->line == line)
|
|
|
|
return complaint;
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
2002-09-19 02:42:41 +02:00
|
|
|
|
|
|
|
/* Oops not seen before, fill in a new complaint. */
|
|
|
|
complaint = XMALLOC (struct complain);
|
|
|
|
complaint->fmt = fmt;
|
|
|
|
complaint->file = file;
|
|
|
|
complaint->line = line;
|
|
|
|
complaint->counter = 0;
|
|
|
|
complaint->next = NULL;
|
|
|
|
|
|
|
|
/* File it, return it. */
|
|
|
|
complaint->next = complaints->root;
|
|
|
|
complaints->root = complaint;
|
|
|
|
return complaint;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* How many complaints about a particular thing should be printed
|
|
|
|
before we stop whining about it? Default is no whining at all,
|
|
|
|
since so many systems have ill-constructed symbol files. */
|
|
|
|
|
|
|
|
static unsigned int stop_whining = 0;
|
|
|
|
|
|
|
|
/* Print a complaint, and link the complaint block into a chain for
|
|
|
|
later handling. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
vcomplaint (struct complaints **c, const char *file, int line, const char *fmt,
|
|
|
|
va_list args)
|
|
|
|
{
|
|
|
|
struct complaints *complaints = get_complaints (c);
|
|
|
|
struct complain *complaint = find_complaint (complaints, file, line, fmt);
|
|
|
|
enum complaint_series series;
|
|
|
|
gdb_assert (complaints != NULL);
|
|
|
|
|
|
|
|
complaint->counter++;
|
1999-07-07 22:19:36 +02:00
|
|
|
if (complaint->counter > stop_whining)
|
2002-09-19 02:42:41 +02:00
|
|
|
return;
|
|
|
|
|
|
|
|
if (info_verbose)
|
|
|
|
series = SUBSEQUENT_MESSAGE;
|
|
|
|
else
|
|
|
|
series = complaints->series;
|
|
|
|
|
|
|
|
if (complaint->file != NULL)
|
|
|
|
internal_vwarning (complaint->file, complaint->line, complaint->fmt, args);
|
2004-04-21 Andrew Cagney <cagney@redhat.com>
* annotate.h (deprecated_annotate_starting_hook)
(deprecated_annotate_stopped_hook)
(deprecated_annotate_exited_hook)
(deprecated_annotate_signal_hook)
(deprecated_annotate_signalled_hook): Deprecate.
* tracepoint.h (deprecated_create_tracepoint_hook)
(deprecated_delete_tracepoint_hook)
(deprecated_modify_tracepoint_hook)
(deprecated_trace_find_hook)
(deprecated_trace_start_stop_hook): Deprecate.
* target.h (deprecated_target_new_objfile_hook): Deprecate.
* remote.h (deprecated_target_resume_hook)
(deprecated_target_wait_loop_hook): Deprecate.
* gdbcore.h (deprecated_exec_file_display_hook)
(deprecated_file_changed_hook): Deprecate.
* frame.h (deprecated_selected_frame_level_changed_hook): Deprecate.
* defs.h (deprecated_modify_breakpoint_hook)
(deprecated_command_loop_hook, deprecated_show_load_progress)
(deprecated_print_frame_info_listing_hook)
(deprecated_query_hook, deprecated_warning_hook)
(deprecated_flush_hook, deprecated_create_breakpoint_hook)
(deprecated_delete_breakpoint_hook)
(deprecated_interactive_hook, deprecated_registers_changed_hook)
(deprecated_readline_begin_hook, deprecated_readline_hook)
(deprecated_readline_end_hook, deprecated_register_changed_hook)
(deprecated_memory_changed_hook, deprecated_init_ui_hook)
(deprecated_context_hook, deprecated_target_wait_hook)
(deprecated_attach_hook, deprecated_detach_hook)
(deprecated_call_command_hook, deprecated_set_hook)
(deprecated_error_hook, deprecated_error_begin_hook)
(deprecated_ui_load_progress_hook): Deprecate.
* valops.c, uw-thread.c, utils.c, tui/tui-io.c: Update.
* tui/tui-hooks.c, tracepoint.c, top.c, thread-db.c: Update.
* target.c, symfile.c, stack.c, sol-thread.c, rs6000-nat.c: Update.
* remote.c, remote-mips.c, regcache.c, mi/mi-interp.c: Update.
* main.c, interps.c, infcmd.c, hpux-thread.c, frame.c: Update.
* exec.c, dsrec.c, d10v-tdep.c, corefile.c, complaints.c: Update.
* cli/cli-script.c, cli/cli-setshow.c, breakpoint.c: Update.
* annotate.c, aix-thread.c: Update.
2004-04-22 01:52:21 +02:00
|
|
|
else if (deprecated_warning_hook)
|
|
|
|
(*deprecated_warning_hook) (complaint->fmt, args);
|
2002-09-19 02:42:41 +02:00
|
|
|
else
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
if (complaints->explanation == NULL)
|
2002-09-21 18:36:33 +02:00
|
|
|
/* A [v]warning() call always appends a newline. */
|
2002-09-19 02:42:41 +02:00
|
|
|
vwarning (complaint->fmt, args);
|
|
|
|
else
|
|
|
|
{
|
|
|
|
char *msg;
|
|
|
|
struct cleanup *cleanups;
|
2004-06-29 16:57:39 +02:00
|
|
|
msg = xstrvprintf (complaint->fmt, args);
|
2002-09-19 02:42:41 +02:00
|
|
|
cleanups = make_cleanup (xfree, msg);
|
|
|
|
wrap_here ("");
|
|
|
|
if (series != SUBSEQUENT_MESSAGE)
|
|
|
|
begin_line ();
|
2005-01-29 Baurzhan Ismagulov <ibr@radix50.net>
* ax-gdb.c, ax-general.c, bcache.c, bfd-target.c, bsd-kvm.c,
* buildsym.c, c-lang.c, c-typeprint.c, c-valprint.c, charset.c,
* coff-pe-read.c, coffread.c, complaints.c, copying.c: I18n markup.
2005-01-29 18:53:26 +01:00
|
|
|
/* XXX: i18n */
|
2003-07-15 17:36:13 +02:00
|
|
|
fprintf_filtered (gdb_stderr, "%s%s%s",
|
|
|
|
complaints->explanation[series].prefix, msg,
|
|
|
|
complaints->explanation[series].postfix);
|
2002-09-21 18:36:33 +02:00
|
|
|
/* Force a line-break after any isolated message. For the
|
|
|
|
other cases, clear_complaints() takes care of any missing
|
|
|
|
trailing newline, the wrap_here() is just a hint. */
|
|
|
|
if (series == ISOLATED_MESSAGE)
|
|
|
|
/* It would be really nice to use begin_line() here.
|
Index: mi/ChangeLog
2003-10-24 Andrew Cagney <cagney@redhat.com>
* tui-out.c: Fix "fortunatly"[sic].
Index: doc/ChangeLog
2003-10-24 Andrew Cagney <cagney@redhat.com>
* annotate.texinfo: Fix "fortunatly"[sic].
2003-10-24 Andrew Cagney <cagney@redhat.com>
* osabi.c (gdbarch_init_osabi): Fix typos, and "fortunatly"[sic].
* PROBLEMS, arch-utils.c, cli-out.c, command.h: Ditto.
* complaints.c, cris-tdep.c, disasm.c, dwarf2-frame.c: Ditto.
* frame.c, frame.h, infcall.c, infcmd.c, infrun.c: Ditto.
* kod.c, mips-tdep.c, regcache.c, regcache.h, remote.c: Ditto.
2003-10-24 19:37:04 +02:00
|
|
|
Unfortunately that function doesn't track GDB_STDERR and
|
2002-09-21 18:36:33 +02:00
|
|
|
consequently will sometimes supress a line when it
|
|
|
|
shouldn't. */
|
|
|
|
fputs_filtered ("\n", gdb_stderr);
|
|
|
|
else
|
|
|
|
wrap_here ("");
|
2002-09-19 02:42:41 +02:00
|
|
|
do_cleanups (cleanups);
|
|
|
|
}
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
switch (series)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
case ISOLATED_MESSAGE:
|
1999-07-07 22:19:36 +02:00
|
|
|
break;
|
2002-09-19 02:42:41 +02:00
|
|
|
case FIRST_MESSAGE:
|
|
|
|
complaints->series = SUBSEQUENT_MESSAGE;
|
|
|
|
break;
|
|
|
|
case SUBSEQUENT_MESSAGE:
|
|
|
|
case SHORT_FIRST_MESSAGE:
|
|
|
|
complaints->series = SUBSEQUENT_MESSAGE;
|
1999-07-07 22:19:36 +02:00
|
|
|
break;
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
2002-09-19 02:42:41 +02:00
|
|
|
|
|
|
|
/* If GDB dumps core, we'd like to see the complaints first.
|
|
|
|
Presumably GDB will not be sending so many complaints that this
|
|
|
|
becomes a performance hog. */
|
|
|
|
|
1999-09-28 23:55:21 +02:00
|
|
|
gdb_flush (gdb_stderr);
|
2002-09-19 02:42:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
complaint (struct complaints **complaints, const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list args;
|
|
|
|
va_start (args, fmt);
|
|
|
|
vcomplaint (complaints, NULL/*file*/, 0/*line*/, fmt, args);
|
|
|
|
va_end (args);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
internal_complaint (struct complaints **complaints, const char *file,
|
|
|
|
int line, const char *fmt, ...)
|
|
|
|
{
|
|
|
|
va_list args;
|
|
|
|
va_start (args, fmt);
|
|
|
|
vcomplaint (complaints, file, line, fmt, args);
|
|
|
|
va_end (args);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Clear out / initialize all complaint counters that have ever been
|
|
|
|
incremented. If LESS_VERBOSE is 1, be less verbose about
|
|
|
|
successive complaints, since the messages are appearing all
|
|
|
|
together during a command that is reporting a contiguous block of
|
|
|
|
complaints (rather than being interleaved with other messages). If
|
|
|
|
noisy is 1, we are in a noisy command, and our caller will print
|
|
|
|
enough context for the user to figure it out. */
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
void
|
2002-09-19 02:42:41 +02:00
|
|
|
clear_complaints (struct complaints **c, int less_verbose, int noisy)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-19 02:42:41 +02:00
|
|
|
struct complaints *complaints = get_complaints (c);
|
|
|
|
struct complain *p;
|
1999-04-16 03:35:26 +02:00
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
for (p = complaints->root; p != NULL; p = p->next)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
1999-07-07 22:19:36 +02:00
|
|
|
p->counter = 0;
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
|
|
|
|
2002-09-21 18:36:33 +02:00
|
|
|
switch (complaints->series)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2002-09-21 18:36:33 +02:00
|
|
|
case FIRST_MESSAGE:
|
|
|
|
/* Haven't yet printed anything. */
|
|
|
|
break;
|
|
|
|
case SHORT_FIRST_MESSAGE:
|
|
|
|
/* Haven't yet printed anything. */
|
|
|
|
break;
|
|
|
|
case ISOLATED_MESSAGE:
|
|
|
|
/* The code above, always forces a line-break. No need to do it
|
|
|
|
here. */
|
|
|
|
break;
|
|
|
|
case SUBSEQUENT_MESSAGE:
|
|
|
|
/* It would be really nice to use begin_line() here.
|
Index: mi/ChangeLog
2003-10-24 Andrew Cagney <cagney@redhat.com>
* tui-out.c: Fix "fortunatly"[sic].
Index: doc/ChangeLog
2003-10-24 Andrew Cagney <cagney@redhat.com>
* annotate.texinfo: Fix "fortunatly"[sic].
2003-10-24 Andrew Cagney <cagney@redhat.com>
* osabi.c (gdbarch_init_osabi): Fix typos, and "fortunatly"[sic].
* PROBLEMS, arch-utils.c, cli-out.c, command.h: Ditto.
* complaints.c, cris-tdep.c, disasm.c, dwarf2-frame.c: Ditto.
* frame.c, frame.h, infcall.c, infcmd.c, infrun.c: Ditto.
* kod.c, mips-tdep.c, regcache.c, regcache.h, remote.c: Ditto.
2003-10-24 19:37:04 +02:00
|
|
|
Unfortunately that function doesn't track GDB_STDERR and
|
2002-09-21 18:36:33 +02:00
|
|
|
consequently will sometimes supress a line when it shouldn't. */
|
|
|
|
fputs_unfiltered ("\n", gdb_stderr);
|
|
|
|
break;
|
|
|
|
default:
|
2005-01-29 Baurzhan Ismagulov <ibr@radix50.net>
* ax-gdb.c, ax-general.c, bcache.c, bfd-target.c, bsd-kvm.c,
* buildsym.c, c-lang.c, c-typeprint.c, c-valprint.c, charset.c,
* coff-pe-read.c, coffread.c, complaints.c, copying.c: I18n markup.
2005-01-29 18:53:26 +01:00
|
|
|
internal_error (__FILE__, __LINE__, _("bad switch"));
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
|
|
|
|
2002-09-19 02:42:41 +02:00
|
|
|
if (!less_verbose)
|
|
|
|
complaints->series = ISOLATED_MESSAGE;
|
|
|
|
else if (!noisy)
|
|
|
|
complaints->series = FIRST_MESSAGE;
|
|
|
|
else
|
|
|
|
complaints->series = SHORT_FIRST_MESSAGE;
|
1999-04-16 03:35:26 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
2000-07-30 03:48:28 +02:00
|
|
|
_initialize_complaints (void)
|
1999-04-16 03:35:26 +02:00
|
|
|
{
|
2005-01-29 Baurzhan Ismagulov <ibr@radix50.net>
* ax-gdb.c, ax-general.c, bcache.c, bfd-target.c, bsd-kvm.c,
* buildsym.c, c-lang.c, c-typeprint.c, c-valprint.c, charset.c,
* coff-pe-read.c, coffread.c, complaints.c, copying.c: I18n markup.
2005-01-29 18:53:26 +01:00
|
|
|
add_setshow_zinteger_cmd ("complaints", class_support, &stop_whining, _("\
|
|
|
|
Set max number of complaints about incorrect symbols."), _("\
|
|
|
|
Show max number of complaints about incorrect symbols."), NULL, _("\
|
|
|
|
Max number of complaints about incorrect symbols is %s."),
|
2004-07-28 21:42:01 +02:00
|
|
|
NULL, NULL,
|
|
|
|
&setlist, &showlist);
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
}
|