2008-05-09 19:02:03 +02:00
|
|
|
/* The find command.
|
|
|
|
|
2017-01-01 07:50:51 +01:00
|
|
|
Copyright (C) 2008-2017 Free Software Foundation, Inc.
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include "defs.h"
|
2009-07-02 19:02:35 +02:00
|
|
|
#include "arch-utils.h"
|
2008-05-09 19:02:03 +02:00
|
|
|
#include <ctype.h>
|
|
|
|
#include "gdbcmd.h"
|
|
|
|
#include "value.h"
|
|
|
|
#include "target.h"
|
2013-03-07 22:57:30 +01:00
|
|
|
#include "cli/cli-utils.h"
|
gdb: Use std::min and std::max throughout
Otherwise including <string> or some other C++ header is broken.
E.g.:
In file included from /opt/gcc/include/c++/7.0.0/bits/char_traits.h:39:0,
from /opt/gcc/include/c++/7.0.0/string:40,
from /home/pedro/gdb/mygit/cxx-convertion/src/gdb/infrun.c:68:
/opt/gcc/include/c++/7.0.0/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2
min(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
/opt/gcc/include/c++/7.0.0/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2
max(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
In file included from .../src/gdb/infrun.c:21:0:
To the best of my grepping abilities, I believe I adjusted all min/max
calls.
gdb/ChangeLog:
2016-09-16 Pedro Alves <palves@redhat.com>
* defs.h (min, max): Delete.
* aarch64-tdep.c: Include <algorithm> and use std::min and
std::max throughout.
* aarch64-tdep.c: Likewise.
* alpha-tdep.c: Likewise.
* amd64-tdep.c: Likewise.
* amd64-windows-tdep.c: Likewise.
* arm-tdep.c: Likewise.
* avr-tdep.c: Likewise.
* breakpoint.c: Likewise.
* btrace.c: Likewise.
* ctf.c: Likewise.
* disasm.c: Likewise.
* doublest.c: Likewise.
* dwarf2loc.c: Likewise.
* dwarf2read.c: Likewise.
* environ.c: Likewise.
* exec.c: Likewise.
* f-exp.y: Likewise.
* findcmd.c: Likewise.
* ft32-tdep.c: Likewise.
* gcore.c: Likewise.
* hppa-tdep.c: Likewise.
* i386-darwin-tdep.c: Likewise.
* i386-tdep.c: Likewise.
* linux-thread-db.c: Likewise.
* lm32-tdep.c: Likewise.
* m32r-tdep.c: Likewise.
* m88k-tdep.c: Likewise.
* memrange.c: Likewise.
* minidebug.c: Likewise.
* mips-tdep.c: Likewise.
* moxie-tdep.c: Likewise.
* nds32-tdep.c: Likewise.
* nios2-tdep.c: Likewise.
* nto-procfs.c: Likewise.
* parse.c: Likewise.
* ppc-sysv-tdep.c: Likewise.
* probe.c: Likewise.
* record-btrace.c: Likewise.
* remote.c: Likewise.
* rs6000-tdep.c: Likewise.
* rx-tdep.c: Likewise.
* s390-linux-nat.c: Likewise.
* s390-linux-tdep.c: Likewise.
* ser-tcp.c: Likewise.
* sh-tdep.c: Likewise.
* sh64-tdep.c: Likewise.
* source.c: Likewise.
* sparc-tdep.c: Likewise.
* symfile.c: Likewise.
* target-memory.c: Likewise.
* target.c: Likewise.
* tic6x-tdep.c: Likewise.
* tilegx-tdep.c: Likewise.
* tracefile-tfile.c: Likewise.
* tracepoint.c: Likewise.
* valprint.c: Likewise.
* value.c: Likewise.
* xtensa-tdep.c: Likewise.
* cli/cli-cmds.c: Likewise.
* compile/compile-object-load.c: Likewise.
2016-09-16 20:55:17 +02:00
|
|
|
#include <algorithm>
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
/* Copied from bfd_put_bits. */
|
|
|
|
|
|
|
|
static void
|
2013-03-08 16:22:44 +01:00
|
|
|
put_bits (bfd_uint64_t data, gdb_byte *buf, int bits, bfd_boolean big_p)
|
2008-05-09 19:02:03 +02:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int bytes;
|
|
|
|
|
|
|
|
gdb_assert (bits % 8 == 0);
|
|
|
|
|
|
|
|
bytes = bits / 8;
|
|
|
|
for (i = 0; i < bytes; i++)
|
|
|
|
{
|
|
|
|
int index = big_p ? bytes - i - 1 : i;
|
|
|
|
|
|
|
|
buf[index] = data & 0xff;
|
|
|
|
data >>= 8;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Subroutine of find_command to simplify it.
|
|
|
|
Parse the arguments of the "find" command. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
parse_find_args (char *args, ULONGEST *max_countp,
|
2013-03-08 16:22:44 +01:00
|
|
|
gdb_byte **pattern_bufp, ULONGEST *pattern_lenp,
|
2009-07-02 19:02:35 +02:00
|
|
|
CORE_ADDR *start_addrp, ULONGEST *search_space_lenp,
|
|
|
|
bfd_boolean big_p)
|
2008-05-09 19:02:03 +02:00
|
|
|
{
|
|
|
|
/* Default to using the specified type. */
|
|
|
|
char size = '\0';
|
|
|
|
ULONGEST max_count = ~(ULONGEST) 0;
|
|
|
|
/* Buffer to hold the search pattern. */
|
2013-03-08 16:22:44 +01:00
|
|
|
gdb_byte *pattern_buf;
|
2008-05-09 19:02:03 +02:00
|
|
|
/* Current size of search pattern buffer.
|
|
|
|
We realloc space as needed. */
|
|
|
|
#define INITIAL_PATTERN_BUF_SIZE 100
|
|
|
|
ULONGEST pattern_buf_size = INITIAL_PATTERN_BUF_SIZE;
|
|
|
|
/* Pointer to one past the last in-use part of pattern_buf. */
|
2013-03-08 16:22:44 +01:00
|
|
|
gdb_byte *pattern_buf_end;
|
2008-05-09 19:02:03 +02:00
|
|
|
ULONGEST pattern_len;
|
|
|
|
CORE_ADDR start_addr;
|
|
|
|
ULONGEST search_space_len;
|
2013-03-12 18:39:45 +01:00
|
|
|
const char *s = args;
|
2008-05-09 19:02:03 +02:00
|
|
|
struct cleanup *old_cleanups;
|
|
|
|
struct value *v;
|
|
|
|
|
|
|
|
if (args == NULL)
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Missing search parameters."));
|
2008-05-09 19:02:03 +02:00
|
|
|
|
2015-09-25 20:08:06 +02:00
|
|
|
pattern_buf = (gdb_byte *) xmalloc (pattern_buf_size);
|
2008-05-09 19:02:03 +02:00
|
|
|
pattern_buf_end = pattern_buf;
|
|
|
|
old_cleanups = make_cleanup (free_current_contents, &pattern_buf);
|
|
|
|
|
|
|
|
/* Get search granularity and/or max count if specified.
|
|
|
|
They may be specified in either order, together or separately. */
|
|
|
|
|
|
|
|
while (*s == '/')
|
|
|
|
{
|
|
|
|
++s;
|
|
|
|
|
|
|
|
while (*s != '\0' && *s != '/' && !isspace (*s))
|
|
|
|
{
|
|
|
|
if (isdigit (*s))
|
|
|
|
{
|
|
|
|
max_count = atoi (s);
|
|
|
|
while (isdigit (*s))
|
|
|
|
++s;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (*s)
|
|
|
|
{
|
|
|
|
case 'b':
|
|
|
|
case 'h':
|
|
|
|
case 'w':
|
|
|
|
case 'g':
|
|
|
|
size = *s++;
|
|
|
|
break;
|
|
|
|
default:
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Invalid size granularity."));
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Rename _const functions to use overloading instead
This renames a few functions -- skip_spaces_const,
skip_to_space_const, get_number_const, extract_arg_const -- to drop
the "_const" suffix and instead rely on overloading.
This makes future const fixes simpler by reducing the number of lines
that must be changed. I think it is also not any less clear, as all
these functions have the same interface as their non-const versions by
design. Furthermore there's an example of using an overload in-tree
already, namely check_for_argument.
This patch was largely created using some perl one-liners; then a few
fixes were applied by hand.
ChangeLog
2017-09-11 Tom Tromey <tom@tromey.com>
* common/common-utils.h (skip_to_space): Remove macro, redeclare
as function.
(skip_to_space): Rename from skip_to_space_const.
* common/common-utils.c (skip_to_space): New function.
(skip_to_space): Rename from skip_to_space_const.
* cli/cli-utils.h (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
* cli/cli-utils.c (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
(number_or_range_parser::get_number): Use ::get_number.
* aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
2017-09-10 22:19:19 +02:00
|
|
|
s = skip_spaces (s);
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Get the search range. */
|
|
|
|
|
|
|
|
v = parse_to_comma_and_eval (&s);
|
|
|
|
start_addr = value_as_address (v);
|
|
|
|
|
|
|
|
if (*s == ',')
|
|
|
|
++s;
|
Rename _const functions to use overloading instead
This renames a few functions -- skip_spaces_const,
skip_to_space_const, get_number_const, extract_arg_const -- to drop
the "_const" suffix and instead rely on overloading.
This makes future const fixes simpler by reducing the number of lines
that must be changed. I think it is also not any less clear, as all
these functions have the same interface as their non-const versions by
design. Furthermore there's an example of using an overload in-tree
already, namely check_for_argument.
This patch was largely created using some perl one-liners; then a few
fixes were applied by hand.
ChangeLog
2017-09-11 Tom Tromey <tom@tromey.com>
* common/common-utils.h (skip_to_space): Remove macro, redeclare
as function.
(skip_to_space): Rename from skip_to_space_const.
* common/common-utils.c (skip_to_space): New function.
(skip_to_space): Rename from skip_to_space_const.
* cli/cli-utils.h (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
* cli/cli-utils.c (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
(number_or_range_parser::get_number): Use ::get_number.
* aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
2017-09-10 22:19:19 +02:00
|
|
|
s = skip_spaces (s);
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
if (*s == '+')
|
|
|
|
{
|
|
|
|
LONGEST len;
|
2010-05-14 21:27:05 +02:00
|
|
|
|
2008-05-09 19:02:03 +02:00
|
|
|
++s;
|
|
|
|
v = parse_to_comma_and_eval (&s);
|
|
|
|
len = value_as_long (v);
|
|
|
|
if (len == 0)
|
|
|
|
{
|
2011-06-27 21:21:51 +02:00
|
|
|
do_cleanups (old_cleanups);
|
2008-05-09 19:37:36 +02:00
|
|
|
printf_filtered (_("Empty search range.\n"));
|
2008-05-09 19:02:03 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (len < 0)
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Invalid length."));
|
2008-05-09 19:02:03 +02:00
|
|
|
/* Watch for overflows. */
|
|
|
|
if (len > CORE_ADDR_MAX
|
|
|
|
|| (start_addr + len - 1) < start_addr)
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Search space too large."));
|
2008-05-09 19:02:03 +02:00
|
|
|
search_space_len = len;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
CORE_ADDR end_addr;
|
2010-05-14 21:27:05 +02:00
|
|
|
|
2008-05-09 19:02:03 +02:00
|
|
|
v = parse_to_comma_and_eval (&s);
|
|
|
|
end_addr = value_as_address (v);
|
|
|
|
if (start_addr > end_addr)
|
2011-07-05 06:35:00 +02:00
|
|
|
error (_("Invalid search space, end precedes start."));
|
2008-05-09 19:02:03 +02:00
|
|
|
search_space_len = end_addr - start_addr + 1;
|
|
|
|
/* We don't support searching all of memory
|
|
|
|
(i.e. start=0, end = 0xff..ff).
|
|
|
|
Bail to avoid overflows later on. */
|
|
|
|
if (search_space_len == 0)
|
2011-01-05 23:22:53 +01:00
|
|
|
error (_("Overflow in address range "
|
|
|
|
"computation, choose smaller range."));
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (*s == ',')
|
|
|
|
++s;
|
|
|
|
|
|
|
|
/* Fetch the search string. */
|
|
|
|
|
|
|
|
while (*s != '\0')
|
|
|
|
{
|
|
|
|
LONGEST x;
|
2012-09-25 14:48:53 +02:00
|
|
|
struct type *t;
|
2012-07-06 17:51:40 +02:00
|
|
|
ULONGEST pattern_buf_size_need;
|
2008-05-09 19:02:03 +02:00
|
|
|
|
Rename _const functions to use overloading instead
This renames a few functions -- skip_spaces_const,
skip_to_space_const, get_number_const, extract_arg_const -- to drop
the "_const" suffix and instead rely on overloading.
This makes future const fixes simpler by reducing the number of lines
that must be changed. I think it is also not any less clear, as all
these functions have the same interface as their non-const versions by
design. Furthermore there's an example of using an overload in-tree
already, namely check_for_argument.
This patch was largely created using some perl one-liners; then a few
fixes were applied by hand.
ChangeLog
2017-09-11 Tom Tromey <tom@tromey.com>
* common/common-utils.h (skip_to_space): Remove macro, redeclare
as function.
(skip_to_space): Rename from skip_to_space_const.
* common/common-utils.c (skip_to_space): New function.
(skip_to_space): Rename from skip_to_space_const.
* cli/cli-utils.h (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
* cli/cli-utils.c (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
(number_or_range_parser::get_number): Use ::get_number.
* aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
2017-09-10 22:19:19 +02:00
|
|
|
s = skip_spaces (s);
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
v = parse_to_comma_and_eval (&s);
|
2012-09-25 14:48:53 +02:00
|
|
|
t = value_type (v);
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
/* Keep it simple and assume size == 'g' when watching for when we
|
|
|
|
need to grow the pattern buf. */
|
2012-07-06 17:51:40 +02:00
|
|
|
pattern_buf_size_need = (pattern_buf_end - pattern_buf
|
gdb: Use std::min and std::max throughout
Otherwise including <string> or some other C++ header is broken.
E.g.:
In file included from /opt/gcc/include/c++/7.0.0/bits/char_traits.h:39:0,
from /opt/gcc/include/c++/7.0.0/string:40,
from /home/pedro/gdb/mygit/cxx-convertion/src/gdb/infrun.c:68:
/opt/gcc/include/c++/7.0.0/bits/stl_algobase.h:243:56: error: macro "min" passed 3 arguments, but takes just 2
min(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
/opt/gcc/include/c++/7.0.0/bits/stl_algobase.h:265:56: error: macro "max" passed 3 arguments, but takes just 2
max(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
In file included from .../src/gdb/infrun.c:21:0:
To the best of my grepping abilities, I believe I adjusted all min/max
calls.
gdb/ChangeLog:
2016-09-16 Pedro Alves <palves@redhat.com>
* defs.h (min, max): Delete.
* aarch64-tdep.c: Include <algorithm> and use std::min and
std::max throughout.
* aarch64-tdep.c: Likewise.
* alpha-tdep.c: Likewise.
* amd64-tdep.c: Likewise.
* amd64-windows-tdep.c: Likewise.
* arm-tdep.c: Likewise.
* avr-tdep.c: Likewise.
* breakpoint.c: Likewise.
* btrace.c: Likewise.
* ctf.c: Likewise.
* disasm.c: Likewise.
* doublest.c: Likewise.
* dwarf2loc.c: Likewise.
* dwarf2read.c: Likewise.
* environ.c: Likewise.
* exec.c: Likewise.
* f-exp.y: Likewise.
* findcmd.c: Likewise.
* ft32-tdep.c: Likewise.
* gcore.c: Likewise.
* hppa-tdep.c: Likewise.
* i386-darwin-tdep.c: Likewise.
* i386-tdep.c: Likewise.
* linux-thread-db.c: Likewise.
* lm32-tdep.c: Likewise.
* m32r-tdep.c: Likewise.
* m88k-tdep.c: Likewise.
* memrange.c: Likewise.
* minidebug.c: Likewise.
* mips-tdep.c: Likewise.
* moxie-tdep.c: Likewise.
* nds32-tdep.c: Likewise.
* nios2-tdep.c: Likewise.
* nto-procfs.c: Likewise.
* parse.c: Likewise.
* ppc-sysv-tdep.c: Likewise.
* probe.c: Likewise.
* record-btrace.c: Likewise.
* remote.c: Likewise.
* rs6000-tdep.c: Likewise.
* rx-tdep.c: Likewise.
* s390-linux-nat.c: Likewise.
* s390-linux-tdep.c: Likewise.
* ser-tcp.c: Likewise.
* sh-tdep.c: Likewise.
* sh64-tdep.c: Likewise.
* source.c: Likewise.
* sparc-tdep.c: Likewise.
* symfile.c: Likewise.
* target-memory.c: Likewise.
* target.c: Likewise.
* tic6x-tdep.c: Likewise.
* tilegx-tdep.c: Likewise.
* tracefile-tfile.c: Likewise.
* tracepoint.c: Likewise.
* valprint.c: Likewise.
* value.c: Likewise.
* xtensa-tdep.c: Likewise.
* cli/cli-cmds.c: Likewise.
* compile/compile-object-load.c: Likewise.
2016-09-16 20:55:17 +02:00
|
|
|
+ std::max (TYPE_LENGTH (t),
|
|
|
|
(unsigned) sizeof (int64_t)));
|
2012-07-06 17:51:40 +02:00
|
|
|
if (pattern_buf_size_need > pattern_buf_size)
|
2008-05-09 19:02:03 +02:00
|
|
|
{
|
|
|
|
size_t current_offset = pattern_buf_end - pattern_buf;
|
2010-05-14 21:27:05 +02:00
|
|
|
|
2012-07-06 17:51:40 +02:00
|
|
|
pattern_buf_size = pattern_buf_size_need * 2;
|
2015-09-25 20:08:06 +02:00
|
|
|
pattern_buf = (gdb_byte *) xrealloc (pattern_buf, pattern_buf_size);
|
2008-05-09 19:02:03 +02:00
|
|
|
pattern_buf_end = pattern_buf + current_offset;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (size != '\0')
|
|
|
|
{
|
|
|
|
x = value_as_long (v);
|
|
|
|
switch (size)
|
|
|
|
{
|
|
|
|
case 'b':
|
|
|
|
*pattern_buf_end++ = x;
|
|
|
|
break;
|
|
|
|
case 'h':
|
|
|
|
put_bits (x, pattern_buf_end, 16, big_p);
|
|
|
|
pattern_buf_end += sizeof (int16_t);
|
|
|
|
break;
|
|
|
|
case 'w':
|
|
|
|
put_bits (x, pattern_buf_end, 32, big_p);
|
|
|
|
pattern_buf_end += sizeof (int32_t);
|
|
|
|
break;
|
|
|
|
case 'g':
|
|
|
|
put_bits (x, pattern_buf_end, 64, big_p);
|
|
|
|
pattern_buf_end += sizeof (int64_t);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
2012-09-25 14:48:53 +02:00
|
|
|
memcpy (pattern_buf_end, value_contents (v), TYPE_LENGTH (t));
|
|
|
|
pattern_buf_end += TYPE_LENGTH (t);
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (*s == ',')
|
|
|
|
++s;
|
Rename _const functions to use overloading instead
This renames a few functions -- skip_spaces_const,
skip_to_space_const, get_number_const, extract_arg_const -- to drop
the "_const" suffix and instead rely on overloading.
This makes future const fixes simpler by reducing the number of lines
that must be changed. I think it is also not any less clear, as all
these functions have the same interface as their non-const versions by
design. Furthermore there's an example of using an overload in-tree
already, namely check_for_argument.
This patch was largely created using some perl one-liners; then a few
fixes were applied by hand.
ChangeLog
2017-09-11 Tom Tromey <tom@tromey.com>
* common/common-utils.h (skip_to_space): Remove macro, redeclare
as function.
(skip_to_space): Rename from skip_to_space_const.
* common/common-utils.c (skip_to_space): New function.
(skip_to_space): Rename from skip_to_space_const.
* cli/cli-utils.h (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
* cli/cli-utils.c (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
(number_or_range_parser::get_number): Use ::get_number.
* aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
2017-09-10 22:19:19 +02:00
|
|
|
s = skip_spaces (s);
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (pattern_buf_end == pattern_buf)
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Missing search pattern."));
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
pattern_len = pattern_buf_end - pattern_buf;
|
|
|
|
|
|
|
|
if (search_space_len < pattern_len)
|
2008-05-09 19:37:36 +02:00
|
|
|
error (_("Search space too small to contain pattern."));
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
*max_countp = max_count;
|
|
|
|
*pattern_bufp = pattern_buf;
|
|
|
|
*pattern_lenp = pattern_len;
|
|
|
|
*start_addrp = start_addr;
|
|
|
|
*search_space_lenp = search_space_len;
|
|
|
|
|
|
|
|
/* We successfully parsed the arguments, leave the freeing of PATTERN_BUF
|
|
|
|
to the caller now. */
|
|
|
|
discard_cleanups (old_cleanups);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
find_command (char *args, int from_tty)
|
|
|
|
{
|
2009-07-02 19:02:35 +02:00
|
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
|
|
bfd_boolean big_p = gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG;
|
2008-05-09 19:02:03 +02:00
|
|
|
/* Command line parameters.
|
|
|
|
These are initialized to avoid uninitialized warnings from -Wall. */
|
|
|
|
ULONGEST max_count = 0;
|
2013-03-08 16:22:44 +01:00
|
|
|
gdb_byte *pattern_buf = 0;
|
2008-05-09 19:02:03 +02:00
|
|
|
ULONGEST pattern_len = 0;
|
|
|
|
CORE_ADDR start_addr = 0;
|
|
|
|
ULONGEST search_space_len = 0;
|
|
|
|
/* End of command line parameters. */
|
|
|
|
unsigned int found_count;
|
|
|
|
CORE_ADDR last_found_addr;
|
|
|
|
struct cleanup *old_cleanups;
|
|
|
|
|
|
|
|
parse_find_args (args, &max_count, &pattern_buf, &pattern_len,
|
2009-07-02 19:02:35 +02:00
|
|
|
&start_addr, &search_space_len, big_p);
|
2008-05-09 19:02:03 +02:00
|
|
|
|
|
|
|
old_cleanups = make_cleanup (free_current_contents, &pattern_buf);
|
|
|
|
|
|
|
|
/* Perform the search. */
|
|
|
|
|
|
|
|
found_count = 0;
|
|
|
|
last_found_addr = 0;
|
|
|
|
|
|
|
|
while (search_space_len >= pattern_len
|
|
|
|
&& found_count < max_count)
|
|
|
|
{
|
|
|
|
/* Offset from start of this iteration to the next iteration. */
|
|
|
|
ULONGEST next_iter_incr;
|
|
|
|
CORE_ADDR found_addr;
|
|
|
|
int found = target_search_memory (start_addr, search_space_len,
|
|
|
|
pattern_buf, pattern_len, &found_addr);
|
|
|
|
|
|
|
|
if (found <= 0)
|
|
|
|
break;
|
|
|
|
|
* defs.h (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter.
* utils.c (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter, use it instead of current_gdbarch.
* ui-out.h (ui_out_field_core_addr): Add GDBARCH parameter.
* ui-out.c (ui_out_field_core_addr): Add GDBARCH parameter,
use it instead of current_gdbarch.
Update calls to ui_out_field_core_addr to pass architecture:
* ada-lang.c (print_one_exception): Update.
* breakpoint.c (print_one_breakpoint_location,
print_one_exception_catchpoint): Update.
* disasm.c (dump_insns): Update.
* darwin-nat-info.c (darwin_debug_regions_recurse): Update.
* mi/mi-main.c (mi_cmd_data_read_memory): Update.
* mi/mi-symbol-cmds.c: Include "objfiles.h".
(mi_cmd_symbol_list_lines): Update.
* stack.c (print_frame_info, print_frame): Update.
Update callers of paddress to pass architecture:
* ada-tasks.c (info_task): Update.
* ada-valprint.c (ada_val_print_1): Update.
* annotate.c (annotate_source, annotate_frame_begin): Update.
* breakpoint.c (insert_bp_location, describe_other_breakpoints,
mention): Update.
* cli/cli-cmds.c (edit_command, list_command, print_disassembly):
Update.
* corefile.c (memory_error): Update.
* c-valprint.c (print_function_pointer_address, c_val_print): Update.
* disasm.c (dis_asm_print_address): Update.
* exec.c (print_section_info): Update.
* f-valprint.c (f_val_print): Update.
* infcmd.c: Include "arch-utils.h".
(jump_command, program_info): Update.
* linux-fork.c: Include "arch-utils.h".
(info_forks_command): Update.
* m2-valprint.c (print_function_pointer_address,
print_unpacked_pointer, print_variable_at_address,
m2_val_print): Update.
* m32r-rom.c (m32r_load_section, m32r_load, m32r_upload_command):
Update.
* printcmd.c (print_address, print_address_demangle, address_info):
Update.
* p-valprint.c (pascal_val_print): Update.
* source.c: Include "arch-utils.h".
(line_info): Update.
* stack.c (frame_info, print_block_frame_labels): Update.
* symfile.c (add_symbol_file_command, list_overlays_command): Update.
* symmisc.c (dump_msymbols, dump_psymtab, dump_symtab_1,
print_symbol, print_partial_symbols, maintenance_info_psymtabs,
maintenance_check_symtabs): Update.
* symtab.c (find_pc_sect_symtab): Update.
* target.c (deprecated_debug_xfer_memory): Update.
* tracepoint.c (scope_info): Update.
* tui/tui-stack.c (tui_make_status_line): Update.
* valprint.c (val_print_string): Update.
Update callers of paddr_nz to use paddress instead (keeping
user-visible output identical):
* alpha-tdep.c (alpha_heuristic_proc_start): Update.
* amd64-tdep.c (fixup_riprel, amd64_displaced_step_copy_insn,
amd64_displaced_step_fixup): Update.
* arch-utils.c (simple_displaced_step_copy_insn): Update.
* auxv.c (fprint_target_auxv): Update.
* breakpoint.c (insert_single_step_breakpoint): Update.
* buildsym.c (finish_block): Update.
* cli/cli-dump.c (restore_section_callback): Update.
* fbsd-nat.c (fbsd_find_memory_regions): Update.
* frame.c (frame_unwind_register_value): Update.
* gcore.c (gcore_create_callback): Update.
* hppa-tdep.c (hppa_frame_cache, hppa_skip_trampoline_code): Update.
* i386-tdep.c (i386_displaced_step_fixup, i386_record_modrm,
i386_record_lea_modrm_addr, i386_record_lea_modrm,
i386_process_record): Update.
* ia64-tdep.c (ia64_frame_this_id, ia64_sigtramp_frame_this_id,
ia64_libunwind_frame_this_id, ia64_libunwind_sigtramp_frame_this_id,
ia64_dummy_id, ia64_access_reg, ia64_access_rse_reg): Update.
* infrun.c (displaced_step_prepare, displaced_step_fixup,
handle_inferior_event, insert_step_resume_breakpoint_at_sal,
insert_longjmp_resume_breakpoint): Update.
* linux-nat.c (linux_nat_find_memory_regions): Update.
* linux-record.c (record_linux_system_call): Update.
* mips-tdep.c (heuristic_proc_start, mips_eabi_push_dummy_call,
mips_n32n64_push_dummy_call, mips_o32_push_dummy_call,
mips_o64_push_dummy_call): Update.
* monitor.c (monitor_error, monitor_remove_breakpoint): Update.
* record.c (record_arch_list_add_mem, record_wait,
record_xfer_partial): Update.
* remote-mips.c (mips_fetch_word, mips_check_lsi_error,
mips_common_breakpoint): Update.
* remote-sim.c (gdbsim_xfer_inferior_memory): Update.
* rs6000-tdep.c (ppc_displaced_step_fixup): Update.
* solib-som.c (som_current_sos): Update.
* symfile.c (load_progress, generic_load): Update.
* symfile-mem.c (add_vsyscall_page): Update.
* valops.c (value_fetch_lazy): Update.
* windows-tdep.c (windows_xfer_shared_library): Update.
Update callers of paddr_nz to use paddress instead (changing
user-visible output to make it more correct):
* dwarf2loc.c (locexpr_describe_location): Update.
* ia64-tdep.c (ia64_memory_insert_breakpoint,
ia64_memory_remove_breakpoint): Update.
* jv-valprint.c (java_value_print): Update.
* m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
* monitor.c (monitor_read_memory): Update.
Update callers of paddr to use paddress instead (changing
user-visible output to make it more correct):
* arm-tdep.c (arm_push_dummy_call): Update.
* breakpoint.c (insert_bp_location, create_thread_event_breakpoint,
create_breakpoint): Update.
* darwin-nat-info.c (darwin_debug_regions): Update.
* dcache.c (dcache_info): Update.
* dsrec.c (load_srec, make_srec): Update.
* dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program,
dwarf2_frame_cache): Update.
* gcore.c (gcore_copy_callback): Update.
* gnu-nat.c (gnu_xfer_memory): Update.
* mips-linux-nat.c (mips_show_dr): Update.
* monitor.c (monitor_write_memory, monitor_insert_breakpoint,
monitor_remove_breakpoint): Update.
* remote.c (compare_sections_command): Update.
* remote-m32r-sdi.c (m32r_xfer_memory, m32r_insert_breakpoint,
m32r_remove_breakpoint, m32r_insert_watchpoint,
m32r_remove_watchpoint): Update.
* sol-thread.c (info_cb): Update.
* symfile.c (load_progress): Update.
Update callers of paddress or paddr_nz to use hex_string instead
(changes output of internal/error/debug messages only):
* dwarf2read.c (dump_die_shallow): Update.
* frame.c (fprint_field, fprint_frame, frame_pc_unwind,
get_frame_func, create_new_frame): Update.
* hppa-tdep.c (find_unwind_entry, unwind_command): Update.
* ia64-tdep.c (get_kernel_table, ia64_find_proc_info_x,
ia64_get_dyn_info_list): Update.
* maint.c (maintenance_translate_address): Update.
* mi/mi-cmd-var.c (mi_cmd_var_create): Update.
* target.c (target_flash_erase): Update.
Update callers of paddr/paddr_nz to use phex/phex_nz instead,
using an appropriate address size. Remove use of strlen_paddr.
* exec.c (exec_files_info): Update.
* i386-nat.c (i386_show_dr): Update.
* remote.c (remote_flash_erase): Update.
* m32r-rom.c (m32r_load_section): Update.
* monitor.c (monitor_vsprintf, monitor_store_register): Update.
* remote.c (remote_check_symbols, remote_search_memory): Update.
* remote-mips.c (mips_request, mips_common_breakpoint): Update.
* scm-valprint.c (scm_ipruk, scm_scmval_print): Update.
* sh64-tdep.c (sh64_show_media_regs, sh64_show_compact_regs): Update.
* sh-tdep.c (sh_generic_show_regs, sh3_show_regs, sh2e_show_regs,
sh2a_show_regs, sh2a_nofpu_show_regs, sh3e_show_regs,
sh3_dsp_show_regs, sh4_show_regs, sh4_nofpu_show_regs,
sh_dsp_show_regs): Update.
* xcoffsolib.c (sharedlibrary_command): Update.
* maint.c (maint_print_section_info): Add ADDR_SIZE parameter.
Use hex_string_custom instead of paddr.
(print_bfd_section_info): Pass address size.
(print_objfile_section_info): Likewise.
* annotate.h (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* annotate.c (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* source.c (identify_source_line): Update call to annotate_source.
* stack.c (print_frame_info, print_frame): Update call to
annotate_frame_begin.
* breakpoint.c (describe_other_breakpoints): Add GDBARCH parameter.
(create_breakpoint, create_ada_exception_breakpoint): Update call.
* stack.c (print_block_frame_labels): Add GDBARCH parameter.
(print_frame_label_vars): Update call.
* symmisc.c (print_partial_symbols): Add GDBARCH parameter.
(dump_psymtab): Update call to print_partial_symbols.
(struct print_symbol_args): Add GDBARCH member.
(dump_symtab_1): Set print_symbol_args architecture member.
(print_symbol): Use it.
* windows-tdep.h (windows_xfer_shared_library): Add GDBARCH
parameter.
* windows-tdep.c (windows_xfer_shared_library): Likewise.
* i386-cygwin-tdep.c (struct cpms_data): Add GDBARCH member.
(core_process_module_section): Pass architecture from cpms_data to
windows_xfer_shared_library.
(windows_core_xfer_shared_libraries): Initialize cmps_data
architecture member.
* windows-nat.c (windows_xfer_shared_libraries): Pass architecture
to windows_xfer_shared_library.
* defs.h (print_address): Add GDBARCH parameter.
* printcmd.c (print_address): Add GDBARCH parameter.
(print_scalar_formatted, do_examine): Update call.
* findcmd.c (find_command): Update call.
* tracepoint.c: Include "arch-utils.h".
(trace_find_line_command): Update call.
* tui/tui-disasm.c (tui_disassemble): Update call.
* value.h (print_address_demangle): Add GDBARCH parameter.
* printcmd.c (print_address_demangle): Add GDBARCH parameter.
* c-valprint.c (print_function_pointer_address, c_val_print):
Update call.
* f-valprint.c (f_val_print): Update call.
* gnu-v3-abi.c (gnuv3_print_method_ptr): Update call.
* jv-valprint.c (java_val_print): Update call.
* m2-valprint.c (print_function_pointer_address, m2_val_print):
Update call.
* p-valprint.c (pascal_val_print): Update call.
* disasm.c (gdb_disassemble_info): Install architecture into
di.application_data field.
testsuite/ChangeLog:
* gdb.threads/tls-shared.exp: Update to locexpr_describe_location
change to prefix TLS offset in hex with 0x.
doc/ChangeLog:
* gdbint.texinfo (Item Output Functions): Update signature
for ui_out_field_core_addr.
2009-07-02 19:21:10 +02:00
|
|
|
print_address (gdbarch, found_addr, gdb_stdout);
|
2008-05-09 19:02:03 +02:00
|
|
|
printf_filtered ("\n");
|
|
|
|
++found_count;
|
|
|
|
last_found_addr = found_addr;
|
|
|
|
|
|
|
|
/* Begin next iteration at one byte past this match. */
|
|
|
|
next_iter_incr = (found_addr - start_addr) + 1;
|
|
|
|
|
|
|
|
/* For robustness, we don't let search_space_len go -ve here. */
|
|
|
|
if (search_space_len >= next_iter_incr)
|
|
|
|
search_space_len -= next_iter_incr;
|
|
|
|
else
|
|
|
|
search_space_len = 0;
|
|
|
|
start_addr += next_iter_incr;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Record and print the results. */
|
|
|
|
|
2009-06-03 20:16:44 +02:00
|
|
|
set_internalvar_integer (lookup_internalvar ("numfound"), found_count);
|
2008-05-09 19:02:03 +02:00
|
|
|
if (found_count > 0)
|
|
|
|
{
|
2008-09-11 16:21:49 +02:00
|
|
|
struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
2010-05-14 21:27:05 +02:00
|
|
|
|
2008-05-09 19:02:03 +02:00
|
|
|
set_internalvar (lookup_internalvar ("_"),
|
2008-09-11 16:21:49 +02:00
|
|
|
value_from_pointer (ptr_type, last_found_addr));
|
2008-05-09 19:02:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (found_count == 0)
|
2008-05-09 19:37:36 +02:00
|
|
|
printf_filtered ("Pattern not found.\n");
|
2008-05-09 19:02:03 +02:00
|
|
|
else
|
2008-05-09 19:37:36 +02:00
|
|
|
printf_filtered ("%d pattern%s found.\n", found_count,
|
2008-05-09 19:02:03 +02:00
|
|
|
found_count > 1 ? "s" : "");
|
|
|
|
|
|
|
|
do_cleanups (old_cleanups);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
_initialize_mem_search (void)
|
|
|
|
{
|
|
|
|
add_cmd ("find", class_vars, find_command, _("\
|
|
|
|
Search memory for a sequence of bytes.\n\
|
2011-01-05 23:22:53 +01:00
|
|
|
Usage:\nfind \
|
|
|
|
[/size-char] [/max-count] start-address, end-address, expr1 [, expr2 ...]\n\
|
2008-05-09 19:02:03 +02:00
|
|
|
find [/size-char] [/max-count] start-address, +length, expr1 [, expr2 ...]\n\
|
|
|
|
size-char is one of b,h,w,g for 8,16,32,64 bit values respectively,\n\
|
|
|
|
and if not specified the size is taken from the type of the expression\n\
|
|
|
|
in the current language.\n\
|
|
|
|
Note that this means for example that in the case of C-like languages\n\
|
|
|
|
a search for an untyped 0x42 will search for \"(int) 0x42\"\n\
|
|
|
|
which is typically four bytes.\n\
|
|
|
|
\n\
|
|
|
|
The address of the last match is stored as the value of \"$_\".\n\
|
|
|
|
Convenience variable \"$numfound\" is set to the number of matches."),
|
|
|
|
&cmdlist);
|
|
|
|
}
|