2017-01-01 07:50:51 +01:00
|
|
|
/* Copyright (C) 2008-2017 Free Software Foundation, Inc.
|
2009-01-11 14:10:44 +01:00
|
|
|
|
|
|
|
This file is part of GDB.
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
|
|
|
|
#include "defs.h"
|
2009-01-12 02:10:28 +01:00
|
|
|
#include "windows-tdep.h"
|
2009-01-11 14:10:44 +01:00
|
|
|
#include "gdb_obstack.h"
|
|
|
|
#include "xml-support.h"
|
2010-04-16 09:49:37 +02:00
|
|
|
#include "gdbarch.h"
|
|
|
|
#include "target.h"
|
|
|
|
#include "value.h"
|
|
|
|
#include "inferior.h"
|
|
|
|
#include "command.h"
|
|
|
|
#include "gdbcmd.h"
|
|
|
|
#include "gdbthread.h"
|
2012-06-05 15:50:57 +02:00
|
|
|
#include "objfiles.h"
|
2012-12-13 11:44:45 +01:00
|
|
|
#include "symfile.h"
|
|
|
|
#include "coff-pe-read.h"
|
|
|
|
#include "gdb_bfd.h"
|
|
|
|
#include "complaints.h"
|
2013-10-01 15:17:57 +02:00
|
|
|
#include "solib.h"
|
|
|
|
#include "solib-target.h"
|
2015-04-02 14:38:29 +02:00
|
|
|
#include "gdbcore.h"
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
struct cmd_list_element *info_w32_cmdlist;
|
|
|
|
|
|
|
|
typedef struct thread_information_block_32
|
|
|
|
{
|
|
|
|
uint32_t current_seh; /* %fs:0x0000 */
|
|
|
|
uint32_t current_top_of_stack; /* %fs:0x0004 */
|
|
|
|
uint32_t current_bottom_of_stack; /* %fs:0x0008 */
|
|
|
|
uint32_t sub_system_tib; /* %fs:0x000c */
|
|
|
|
uint32_t fiber_data; /* %fs:0x0010 */
|
|
|
|
uint32_t arbitrary_data_slot; /* %fs:0x0014 */
|
|
|
|
uint32_t linear_address_tib; /* %fs:0x0018 */
|
|
|
|
uint32_t environment_pointer; /* %fs:0x001c */
|
|
|
|
uint32_t process_id; /* %fs:0x0020 */
|
|
|
|
uint32_t current_thread_id; /* %fs:0x0024 */
|
|
|
|
uint32_t active_rpc_handle; /* %fs:0x0028 */
|
|
|
|
uint32_t thread_local_storage; /* %fs:0x002c */
|
|
|
|
uint32_t process_environment_block; /* %fs:0x0030 */
|
|
|
|
uint32_t last_error_number; /* %fs:0x0034 */
|
|
|
|
}
|
|
|
|
thread_information_32;
|
|
|
|
|
|
|
|
typedef struct thread_information_block_64
|
|
|
|
{
|
|
|
|
uint64_t current_seh; /* %gs:0x0000 */
|
|
|
|
uint64_t current_top_of_stack; /* %gs:0x0008 */
|
|
|
|
uint64_t current_bottom_of_stack; /* %gs:0x0010 */
|
|
|
|
uint64_t sub_system_tib; /* %gs:0x0018 */
|
|
|
|
uint64_t fiber_data; /* %gs:0x0020 */
|
|
|
|
uint64_t arbitrary_data_slot; /* %gs:0x0028 */
|
|
|
|
uint64_t linear_address_tib; /* %gs:0x0030 */
|
|
|
|
uint64_t environment_pointer; /* %gs:0x0038 */
|
|
|
|
uint64_t process_id; /* %gs:0x0040 */
|
|
|
|
uint64_t current_thread_id; /* %gs:0x0048 */
|
|
|
|
uint64_t active_rpc_handle; /* %gs:0x0050 */
|
|
|
|
uint64_t thread_local_storage; /* %gs:0x0058 */
|
|
|
|
uint64_t process_environment_block; /* %gs:0x0060 */
|
|
|
|
uint64_t last_error_number; /* %gs:0x0068 */
|
|
|
|
}
|
|
|
|
thread_information_64;
|
|
|
|
|
|
|
|
|
|
|
|
static const char* TIB_NAME[] =
|
|
|
|
{
|
|
|
|
" current_seh ", /* %fs:0x0000 */
|
|
|
|
" current_top_of_stack ", /* %fs:0x0004 */
|
|
|
|
" current_bottom_of_stack ", /* %fs:0x0008 */
|
|
|
|
" sub_system_tib ", /* %fs:0x000c */
|
|
|
|
" fiber_data ", /* %fs:0x0010 */
|
|
|
|
" arbitrary_data_slot ", /* %fs:0x0014 */
|
|
|
|
" linear_address_tib ", /* %fs:0x0018 */
|
|
|
|
" environment_pointer ", /* %fs:0x001c */
|
|
|
|
" process_id ", /* %fs:0x0020 */
|
|
|
|
" current_thread_id ", /* %fs:0x0024 */
|
|
|
|
" active_rpc_handle ", /* %fs:0x0028 */
|
|
|
|
" thread_local_storage ", /* %fs:0x002c */
|
|
|
|
" process_environment_block ", /* %fs:0x0030 */
|
|
|
|
" last_error_number " /* %fs:0x0034 */
|
|
|
|
};
|
|
|
|
|
2011-01-12 02:23:29 +01:00
|
|
|
static const int MAX_TIB32 =
|
|
|
|
sizeof (thread_information_32) / sizeof (uint32_t);
|
|
|
|
static const int MAX_TIB64 =
|
|
|
|
sizeof (thread_information_64) / sizeof (uint64_t);
|
2010-04-16 09:49:37 +02:00
|
|
|
static const int FULL_TIB_SIZE = 0x1000;
|
|
|
|
|
|
|
|
static int maint_display_all_tib = 0;
|
|
|
|
|
|
|
|
/* Define Thread Local Base pointer type. */
|
|
|
|
|
|
|
|
static struct type *
|
|
|
|
windows_get_tlb_type (struct gdbarch *gdbarch)
|
|
|
|
{
|
2010-04-30 17:38:42 +02:00
|
|
|
static struct gdbarch *last_gdbarch = NULL;
|
|
|
|
static struct type *last_tlb_type = NULL;
|
2010-04-16 09:49:37 +02:00
|
|
|
struct type *dword_ptr_type, *dword32_type, *void_ptr_type;
|
|
|
|
struct type *peb_ldr_type, *peb_ldr_ptr_type;
|
2016-04-18 19:16:27 +02:00
|
|
|
struct type *peb_type, *peb_ptr_type, *list_type;
|
2010-04-16 09:49:37 +02:00
|
|
|
struct type *module_list_ptr_type;
|
|
|
|
struct type *tib_type, *seh_type, *tib_ptr_type, *seh_ptr_type;
|
|
|
|
|
2010-04-30 17:38:42 +02:00
|
|
|
/* Do not rebuild type if same gdbarch as last time. */
|
|
|
|
if (last_tlb_type && last_gdbarch == gdbarch)
|
|
|
|
return last_tlb_type;
|
|
|
|
|
2010-04-16 09:49:37 +02:00
|
|
|
dword_ptr_type = arch_integer_type (gdbarch, gdbarch_ptr_bit (gdbarch),
|
|
|
|
1, "DWORD_PTR");
|
|
|
|
dword32_type = arch_integer_type (gdbarch, 32,
|
|
|
|
1, "DWORD32");
|
|
|
|
void_ptr_type = lookup_pointer_type (builtin_type (gdbarch)->builtin_void);
|
|
|
|
|
|
|
|
/* list entry */
|
|
|
|
|
|
|
|
list_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
|
|
TYPE_NAME (list_type) = xstrdup ("list");
|
|
|
|
|
|
|
|
module_list_ptr_type = void_ptr_type;
|
|
|
|
|
2011-01-12 02:23:29 +01:00
|
|
|
append_composite_type_field (list_type, "forward_list",
|
|
|
|
module_list_ptr_type);
|
2010-04-16 09:49:37 +02:00
|
|
|
append_composite_type_field (list_type, "backward_list",
|
|
|
|
module_list_ptr_type);
|
|
|
|
|
|
|
|
/* Structured Exception Handler */
|
|
|
|
|
|
|
|
seh_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
|
|
TYPE_NAME (seh_type) = xstrdup ("seh");
|
|
|
|
|
|
|
|
seh_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
|
|
TYPE_TARGET_TYPE (seh_ptr_type) = seh_type;
|
|
|
|
|
|
|
|
append_composite_type_field (seh_type, "next_seh", seh_ptr_type);
|
2010-04-20 01:52:11 +02:00
|
|
|
append_composite_type_field (seh_type, "handler",
|
|
|
|
builtin_type (gdbarch)->builtin_func_ptr);
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
/* struct _PEB_LDR_DATA */
|
|
|
|
peb_ldr_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
|
|
TYPE_NAME (peb_ldr_type) = xstrdup ("peb_ldr_data");
|
|
|
|
|
|
|
|
append_composite_type_field (peb_ldr_type, "length", dword32_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "initialized", dword32_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "ss_handle", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "in_load_order", list_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "in_memory_order", list_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "in_init_order", list_type);
|
|
|
|
append_composite_type_field (peb_ldr_type, "entry_in_progress",
|
|
|
|
void_ptr_type);
|
|
|
|
peb_ldr_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
|
|
TYPE_TARGET_TYPE (peb_ldr_ptr_type) = peb_ldr_type;
|
|
|
|
|
|
|
|
|
|
|
|
/* struct process environment block */
|
|
|
|
peb_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
|
|
TYPE_NAME (peb_type) = xstrdup ("peb");
|
|
|
|
|
|
|
|
/* First bytes contain several flags. */
|
|
|
|
append_composite_type_field (peb_type, "flags", dword_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "mutant", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "image_base_address", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "ldr", peb_ldr_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "process_parameters", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "sub_system_data", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "process_heap", void_ptr_type);
|
|
|
|
append_composite_type_field (peb_type, "fast_peb_lock", void_ptr_type);
|
|
|
|
peb_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
|
|
TYPE_TARGET_TYPE (peb_ptr_type) = peb_type;
|
|
|
|
|
|
|
|
|
|
|
|
/* struct thread information block */
|
|
|
|
tib_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
|
|
TYPE_NAME (tib_type) = xstrdup ("tib");
|
|
|
|
|
|
|
|
/* uint32_t current_seh; %fs:0x0000 */
|
|
|
|
append_composite_type_field (tib_type, "current_seh", seh_ptr_type);
|
|
|
|
/* uint32_t current_top_of_stack; %fs:0x0004 */
|
2011-01-12 02:23:29 +01:00
|
|
|
append_composite_type_field (tib_type, "current_top_of_stack",
|
|
|
|
void_ptr_type);
|
2010-04-16 09:49:37 +02:00
|
|
|
/* uint32_t current_bottom_of_stack; %fs:0x0008 */
|
|
|
|
append_composite_type_field (tib_type, "current_bottom_of_stack",
|
|
|
|
void_ptr_type);
|
|
|
|
/* uint32_t sub_system_tib; %fs:0x000c */
|
|
|
|
append_composite_type_field (tib_type, "sub_system_tib", void_ptr_type);
|
|
|
|
|
|
|
|
/* uint32_t fiber_data; %fs:0x0010 */
|
|
|
|
append_composite_type_field (tib_type, "fiber_data", void_ptr_type);
|
|
|
|
/* uint32_t arbitrary_data_slot; %fs:0x0014 */
|
|
|
|
append_composite_type_field (tib_type, "arbitrary_data_slot", void_ptr_type);
|
|
|
|
/* uint32_t linear_address_tib; %fs:0x0018 */
|
|
|
|
append_composite_type_field (tib_type, "linear_address_tib", void_ptr_type);
|
|
|
|
/* uint32_t environment_pointer; %fs:0x001c */
|
|
|
|
append_composite_type_field (tib_type, "environment_pointer", void_ptr_type);
|
|
|
|
/* uint32_t process_id; %fs:0x0020 */
|
|
|
|
append_composite_type_field (tib_type, "process_id", dword_ptr_type);
|
|
|
|
/* uint32_t current_thread_id; %fs:0x0024 */
|
|
|
|
append_composite_type_field (tib_type, "thread_id", dword_ptr_type);
|
|
|
|
/* uint32_t active_rpc_handle; %fs:0x0028 */
|
|
|
|
append_composite_type_field (tib_type, "active_rpc_handle", dword_ptr_type);
|
|
|
|
/* uint32_t thread_local_storage; %fs:0x002c */
|
2011-01-12 02:23:29 +01:00
|
|
|
append_composite_type_field (tib_type, "thread_local_storage",
|
|
|
|
void_ptr_type);
|
2010-04-16 09:49:37 +02:00
|
|
|
/* uint32_t process_environment_block; %fs:0x0030 */
|
|
|
|
append_composite_type_field (tib_type, "process_environment_block",
|
|
|
|
peb_ptr_type);
|
|
|
|
/* uint32_t last_error_number; %fs:0x0034 */
|
|
|
|
append_composite_type_field (tib_type, "last_error_number", dword_ptr_type);
|
|
|
|
|
|
|
|
tib_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
|
|
TYPE_TARGET_TYPE (tib_ptr_type) = tib_type;
|
|
|
|
|
2010-04-30 17:38:42 +02:00
|
|
|
last_tlb_type = tib_ptr_type;
|
|
|
|
last_gdbarch = gdbarch;
|
|
|
|
|
2010-04-16 09:49:37 +02:00
|
|
|
return tib_ptr_type;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* The $_tlb convenience variable is a bit special. We don't know
|
|
|
|
for sure the type of the value until we actually have a chance to
|
|
|
|
fetch the data. The type can change depending on gdbarch, so it is
|
|
|
|
also dependent on which thread you have selected. */
|
|
|
|
|
|
|
|
/* This function implements the lval_computed support for reading a
|
|
|
|
$_tlb value. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
tlb_value_read (struct value *val)
|
|
|
|
{
|
|
|
|
CORE_ADDR tlb;
|
|
|
|
struct type *type = check_typedef (value_type (val));
|
|
|
|
|
|
|
|
if (!target_get_tib_address (inferior_ptid, &tlb))
|
|
|
|
error (_("Unable to read tlb"));
|
|
|
|
store_typed_address (value_contents_raw (val), type, tlb);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* This function implements the lval_computed support for writing a
|
|
|
|
$_tlb value. */
|
|
|
|
|
|
|
|
static void
|
|
|
|
tlb_value_write (struct value *v, struct value *fromval)
|
|
|
|
{
|
|
|
|
error (_("Impossible to change the Thread Local Base"));
|
|
|
|
}
|
|
|
|
|
2011-07-14 17:00:20 +02:00
|
|
|
static const struct lval_funcs tlb_value_funcs =
|
2010-04-16 09:49:37 +02:00
|
|
|
{
|
|
|
|
tlb_value_read,
|
|
|
|
tlb_value_write
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
/* Return a new value with the correct type for the tlb object of
|
|
|
|
the current thread using architecture GDBARCH. Return a void value
|
|
|
|
if there's no object available. */
|
|
|
|
|
|
|
|
static struct value *
|
2012-04-27 22:38:39 +02:00
|
|
|
tlb_make_value (struct gdbarch *gdbarch, struct internalvar *var, void *ignore)
|
2010-04-16 09:49:37 +02:00
|
|
|
{
|
|
|
|
if (target_has_stack && !ptid_equal (inferior_ptid, null_ptid))
|
|
|
|
{
|
|
|
|
struct type *type = windows_get_tlb_type (gdbarch);
|
|
|
|
return allocate_computed_value (type, &tlb_value_funcs, NULL);
|
|
|
|
}
|
|
|
|
|
|
|
|
return allocate_value (builtin_type (gdbarch)->builtin_void);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/* Display thread information block of a given thread. */
|
|
|
|
|
|
|
|
static int
|
|
|
|
display_one_tib (ptid_t ptid)
|
|
|
|
{
|
|
|
|
gdb_byte *tib = NULL;
|
|
|
|
gdb_byte *index;
|
|
|
|
CORE_ADDR thread_local_base;
|
|
|
|
ULONGEST i, val, max, max_name, size, tib_size;
|
* gdbarch.sh (target_gdbarch): Remove macro.
(get_target_gdbarch): Rename to target_gdbarch.
* gdbarch.c, gdbarch.h: Rebuild.
* ada-tasks.c, aix-thread.c, amd64-linux-nat.c, arch-utils.c,
arm-tdep.c, auxv.c, breakpoint.c, bsd-uthread.c, corefile.c,
darwin-nat-info.c, dcache.c, dsrec.c, exec.c, fbsd-nat.c,
filesystem.c, gcore.c, gnu-nat.c, i386-darwin-nat.c, i386-nat.c,
ia64-vms-tdep.c, inf-ptrace.c, infcmd.c, jit.c, linux-nat.c,
linux-tdep.c, linux-thread-db.c, m32r-rom.c, memattr.c,
mep-tdep.c, microblaze-tdep.c, mips-linux-nat.c,
mips-linux-tdep.c, mips-tdep.c, monitor.c, moxie-tdep.c,
nto-procfs.c, nto-tdep.c, ppc-linux-nat.c, proc-service.c,
procfs.c, progspace.c, ravenscar-thread.c, record.c,
remote-m32r-sdi.c, remote-mips.c, remote-sim.c, remote.c,
rl78-tdep.c, rs6000-nat.c, rx-tdep.c, s390-nat.c, sol-thread.c,
solib-darwin.c, solib-dsbt.c, solib-frv.c, solib-ia64-hpux.c,
solib-irix.c, solib-pa64.c, solib-som.c, solib-spu.c,
solib-sunos.c, solib-svr4.c, solib.c, spu-linux-nat.c,
spu-multiarch.c, spu-tdep.c, symfile-mem.c, symfile.c, symtab.c,
target-descriptions.c, target.c, target.h, tracepoint.c,
windows-nat.c, windows-tdep.c, xcoffsolib.c, cli/cli-dump.c,
common/agent.c, mi/mi-interp.c, python/py-finishbreakpoint.c,
python/py-inferior.c, python/python.c: Update.
2012-11-09 20:58:03 +01:00
|
|
|
ULONGEST sizeof_ptr = gdbarch_ptr_bit (target_gdbarch ());
|
|
|
|
enum bfd_endian byte_order = gdbarch_byte_order (target_gdbarch ());
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
if (sizeof_ptr == 64)
|
|
|
|
{
|
|
|
|
size = sizeof (uint64_t);
|
|
|
|
tib_size = sizeof (thread_information_64);
|
|
|
|
max = MAX_TIB64;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
size = sizeof (uint32_t);
|
|
|
|
tib_size = sizeof (thread_information_32);
|
|
|
|
max = MAX_TIB32;
|
|
|
|
}
|
|
|
|
|
|
|
|
max_name = max;
|
|
|
|
|
|
|
|
if (maint_display_all_tib)
|
|
|
|
{
|
|
|
|
tib_size = FULL_TIB_SIZE;
|
|
|
|
max = tib_size / size;
|
|
|
|
}
|
|
|
|
|
2015-09-25 20:08:06 +02:00
|
|
|
tib = (gdb_byte *) alloca (tib_size);
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
if (target_get_tib_address (ptid, &thread_local_base) == 0)
|
|
|
|
{
|
|
|
|
printf_filtered (_("Unable to get thread local base for %s\n"),
|
|
|
|
target_pid_to_str (ptid));
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (target_read (¤t_target, TARGET_OBJECT_MEMORY,
|
|
|
|
NULL, tib, thread_local_base, tib_size) != tib_size)
|
|
|
|
{
|
2011-01-12 02:23:29 +01:00
|
|
|
printf_filtered (_("Unable to read thread information "
|
|
|
|
"block for %s at address %s\n"),
|
2010-04-16 09:49:37 +02:00
|
|
|
target_pid_to_str (ptid),
|
* gdbarch.sh (target_gdbarch): Remove macro.
(get_target_gdbarch): Rename to target_gdbarch.
* gdbarch.c, gdbarch.h: Rebuild.
* ada-tasks.c, aix-thread.c, amd64-linux-nat.c, arch-utils.c,
arm-tdep.c, auxv.c, breakpoint.c, bsd-uthread.c, corefile.c,
darwin-nat-info.c, dcache.c, dsrec.c, exec.c, fbsd-nat.c,
filesystem.c, gcore.c, gnu-nat.c, i386-darwin-nat.c, i386-nat.c,
ia64-vms-tdep.c, inf-ptrace.c, infcmd.c, jit.c, linux-nat.c,
linux-tdep.c, linux-thread-db.c, m32r-rom.c, memattr.c,
mep-tdep.c, microblaze-tdep.c, mips-linux-nat.c,
mips-linux-tdep.c, mips-tdep.c, monitor.c, moxie-tdep.c,
nto-procfs.c, nto-tdep.c, ppc-linux-nat.c, proc-service.c,
procfs.c, progspace.c, ravenscar-thread.c, record.c,
remote-m32r-sdi.c, remote-mips.c, remote-sim.c, remote.c,
rl78-tdep.c, rs6000-nat.c, rx-tdep.c, s390-nat.c, sol-thread.c,
solib-darwin.c, solib-dsbt.c, solib-frv.c, solib-ia64-hpux.c,
solib-irix.c, solib-pa64.c, solib-som.c, solib-spu.c,
solib-sunos.c, solib-svr4.c, solib.c, spu-linux-nat.c,
spu-multiarch.c, spu-tdep.c, symfile-mem.c, symfile.c, symtab.c,
target-descriptions.c, target.c, target.h, tracepoint.c,
windows-nat.c, windows-tdep.c, xcoffsolib.c, cli/cli-dump.c,
common/agent.c, mi/mi-interp.c, python/py-finishbreakpoint.c,
python/py-inferior.c, python/python.c: Update.
2012-11-09 20:58:03 +01:00
|
|
|
paddress (target_gdbarch (), thread_local_base));
|
2010-04-16 09:49:37 +02:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
printf_filtered (_("Thread Information Block %s at %s\n"),
|
|
|
|
target_pid_to_str (ptid),
|
* gdbarch.sh (target_gdbarch): Remove macro.
(get_target_gdbarch): Rename to target_gdbarch.
* gdbarch.c, gdbarch.h: Rebuild.
* ada-tasks.c, aix-thread.c, amd64-linux-nat.c, arch-utils.c,
arm-tdep.c, auxv.c, breakpoint.c, bsd-uthread.c, corefile.c,
darwin-nat-info.c, dcache.c, dsrec.c, exec.c, fbsd-nat.c,
filesystem.c, gcore.c, gnu-nat.c, i386-darwin-nat.c, i386-nat.c,
ia64-vms-tdep.c, inf-ptrace.c, infcmd.c, jit.c, linux-nat.c,
linux-tdep.c, linux-thread-db.c, m32r-rom.c, memattr.c,
mep-tdep.c, microblaze-tdep.c, mips-linux-nat.c,
mips-linux-tdep.c, mips-tdep.c, monitor.c, moxie-tdep.c,
nto-procfs.c, nto-tdep.c, ppc-linux-nat.c, proc-service.c,
procfs.c, progspace.c, ravenscar-thread.c, record.c,
remote-m32r-sdi.c, remote-mips.c, remote-sim.c, remote.c,
rl78-tdep.c, rs6000-nat.c, rx-tdep.c, s390-nat.c, sol-thread.c,
solib-darwin.c, solib-dsbt.c, solib-frv.c, solib-ia64-hpux.c,
solib-irix.c, solib-pa64.c, solib-som.c, solib-spu.c,
solib-sunos.c, solib-svr4.c, solib.c, spu-linux-nat.c,
spu-multiarch.c, spu-tdep.c, symfile-mem.c, symfile.c, symtab.c,
target-descriptions.c, target.c, target.h, tracepoint.c,
windows-nat.c, windows-tdep.c, xcoffsolib.c, cli/cli-dump.c,
common/agent.c, mi/mi-interp.c, python/py-finishbreakpoint.c,
python/py-inferior.c, python/python.c: Update.
2012-11-09 20:58:03 +01:00
|
|
|
paddress (target_gdbarch (), thread_local_base));
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
index = (gdb_byte *) tib;
|
|
|
|
|
|
|
|
/* All fields have the size of a pointer, this allows to iterate
|
|
|
|
using the same for loop for both layouts. */
|
|
|
|
for (i = 0; i < max; i++)
|
|
|
|
{
|
|
|
|
val = extract_unsigned_integer (index, size, byte_order);
|
|
|
|
if (i < max_name)
|
|
|
|
printf_filtered (_("%s is 0x%s\n"), TIB_NAME[i], phex (val, size));
|
|
|
|
else if (val != 0)
|
|
|
|
printf_filtered (_("TIB[0x%s] is 0x%s\n"), phex (i * size, 2),
|
|
|
|
phex (val, size));
|
|
|
|
index += size;
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
Per-inferior/Inferior-qualified thread IDs
This commit changes GDB to track thread numbers per-inferior. Then,
if you're debugging multiple inferiors, GDB displays
"inferior-num.thread-num" instead of just "thread-num" whenever it
needs to display a thread:
(gdb) info inferiors
Num Description Executable
1 process 6022 /home/pedro/gdb/tests/threads
* 2 process 6037 /home/pedro/gdb/tests/threads
(gdb) info threads
Id Target Id Frame
1.1 Thread 0x7ffff7fc2740 (LWP 6022) "threads" (running)
1.2 Thread 0x7ffff77c0700 (LWP 6028) "threads" (running)
1.3 Thread 0x7ffff7fc2740 (LWP 6032) "threads" (running)
2.1 Thread 0x7ffff7fc1700 (LWP 6037) "threads" (running)
2.2 Thread 0x7ffff77c0700 (LWP 6038) "threads" (running)
* 2.3 Thread 0x7ffff7fc2740 (LWP 6039) "threads" (running)
(gdb)
...
(gdb) thread 1.1
[Switching to thread 1.1 (Thread 0x7ffff7fc2740 (LWP 8155))]
(gdb)
...
etc.
You can still use "thread NUM", in which case GDB infers you're
referring to thread NUM of the current inferior.
The $_thread convenience var and Python's InferiorThread.num attribute
are remapped to the new per-inferior thread number. It's a backward
compatibility break, but since it only matters when debugging multiple
inferiors, I think it's worth doing.
Because MI thread IDs need to be a single integer, we keep giving
threads a global identifier, _in addition_ to the per-inferior number,
and make MI always refer to the global thread IDs. IOW, nothing
changes from a MI frontend's perspective.
Similarly, since Python's Breakpoint.thread and Guile's
breakpoint-thread/set-breakpoint-thread breakpoint methods need to
work with integers, those are adjusted to work with global thread IDs
too. Follow up patches will provide convenient means to access
threads' global IDs.
To avoid potencially confusing users (which also avoids updating much
of the testsuite), if there's only one inferior and its ID is "1",
IOW, the user hasn't done anything multi-process/inferior related,
then the "INF." part of thread IDs is not shown. E.g,.:
(gdb) info inferiors
Num Description Executable
* 1 process 15275 /home/pedro/gdb/tests/threads
(gdb) info threads
Id Target Id Frame
* 1 Thread 0x7ffff7fc1740 (LWP 15275) "threads" main () at threads.c:40
(gdb) add-inferior
Added inferior 2
(gdb) info threads
Id Target Id Frame
* 1.1 Thread 0x7ffff7fc1740 (LWP 15275) "threads" main () at threads.c:40
(gdb)
No regressions on x86_64 Fedora 20.
gdb/ChangeLog:
2016-01-13 Pedro Alves <palves@redhat.com>
* NEWS: Mention that thread IDs are now per inferior and global
thread IDs.
* Makefile.in (SFILES): Add tid-parse.c.
(COMMON_OBS): Add tid-parse.o.
(HFILES_NO_SRCDIR): Add tid-parse.h.
* ada-tasks.c: Adjust to use ptid_to_global_thread_id.
* breakpoint.c (insert_breakpoint_locations)
(remove_threaded_breakpoints, bpstat_check_breakpoint_conditions)
(print_one_breakpoint_location, set_longjmp_breakpoint)
(check_longjmp_breakpoint_for_call_dummy)
(set_momentary_breakpoint): Adjust to use global IDs.
(find_condition_and_thread, watch_command_1): Use parse_thread_id.
(until_break_command, longjmp_bkpt_dtor)
(breakpoint_re_set_thread, insert_single_step_breakpoint): Adjust
to use global IDs.
* dummy-frame.c (pop_dummy_frame_bpt): Adjust to use
ptid_to_global_thread_id.
* elfread.c (elf_gnu_ifunc_resolver_stop): Likewise.
* gdbthread.h (struct thread_info): Rename field 'num' to
'global_num. Add new fields 'per_inf_num' and 'inf'.
(thread_id_to_pid): Rename thread_id_to_pid to
global_thread_id_to_ptid.
(pid_to_thread_id): Rename to ...
(ptid_to_global_thread_id): ... this.
(valid_thread_id): Rename to ...
(valid_global_thread_id): ... this.
(find_thread_id): Rename to ...
(find_thread_global_id): ... this.
(ALL_THREADS, ALL_THREADS_BY_INFERIOR): Declare.
(print_thread_info): Add comment.
* tid-parse.h: New file.
* tid-parse.c: New file.
* infcmd.c (step_command_fsm_prepare)
(step_command_fsm_should_stop): Adjust to use the global thread
ID.
(until_next_command, until_next_command)
(finish_command_fsm_should_stop): Adjust to use the global thread
ID.
(attach_post_wait): Adjust to check the inferior number too.
* inferior.h (struct inferior) <highest_thread_num>: New field.
* infrun.c (handle_signal_stop)
(insert_exception_resume_breakpoint)
(insert_exception_resume_from_probe): Adjust to use the global
thread ID.
* record-btrace.c (record_btrace_open): Use global thread IDs.
* remote.c (process_initial_stop_replies): Also consider the
inferior number.
* target.c (target_pre_inferior): Clear the inferior's highest
thread num.
* thread.c (clear_thread_inferior_resources): Adjust to use the
global thread ID.
(new_thread): New inferior parameter. Adjust to use it. Set both
the thread's global ID and the thread's per-inferior ID.
(add_thread_silent): Adjust.
(find_thread_global_id): New.
(find_thread_id): Make static. Adjust to rename.
(valid_thread_id): Rename to ...
(valid_global_thread_id): ... this.
(pid_to_thread_id): Rename to ...
(ptid_to_global_thread_id): ... this.
(thread_id_to_pid): Rename to ...
(global_thread_id_to_ptid): ... this. Adjust.
(first_thread_of_process): Adjust.
(do_captured_list_thread_ids): Adjust to use global thread IDs.
(should_print_thread): New function.
(print_thread_info): Rename to ...
(print_thread_info_1): ... this, and add new show_global_ids
parameter. Handle it. Iterate over inferiors.
(print_thread_info): Reimplement as wrapper around
print_thread_info_1.
(show_inferior_qualified_tids): New function.
(print_thread_id): Use it.
(tp_array_compar): Compare inferior numbers too.
(thread_apply_command): Use tid_range_parser.
(do_captured_thread_select): Use parse_thread_id.
(thread_id_make_value): Adjust.
(_initialize_thread): Adjust "info threads" help string.
* varobj.c (struct varobj_root): Update comment.
(varobj_create): Adjust to use global thread IDs.
(value_of_root_1): Adjust to use global_thread_id_to_ptid.
* windows-tdep.c (display_tib): No longer accept an argument.
* cli/cli-utils.c (get_number_trailer): Make extern.
* cli/cli-utils.h (get_number_trailer): Declare.
(get_number_const): Adjust documentation.
* mi/mi-cmd-var.c (mi_cmd_var_update_iter): Adjust to use global
thread IDs.
* mi/mi-interp.c (mi_new_thread, mi_thread_exit)
(mi_on_normal_stop, mi_output_running_pid, mi_on_resume):
* mi/mi-main.c (mi_execute_command, mi_cmd_execute): Likewise.
* guile/scm-breakpoint.c (gdbscm_set_breakpoint_thread_x):
Likewise.
* python/py-breakpoint.c (bppy_set_thread): Likewise.
* python/py-finishbreakpoint.c (bpfinishpy_init): Likewise.
* python/py-infthread.c (thpy_get_num): Add comment and return the
per-inferior thread ID.
(thread_object_getset): Update comment of "num".
gdb/testsuite/ChangeLog:
2016-01-07 Pedro Alves <palves@redhat.com>
* gdb.base/break.exp: Adjust to output changes.
* gdb.base/hbreak2.exp: Likewise.
* gdb.base/sepdebug.exp: Likewise.
* gdb.base/watch_thread_num.exp: Likewise.
* gdb.linespec/keywords.exp: Likewise.
* gdb.multi/info-threads.exp: Likewise.
* gdb.threads/thread-find.exp: Likewise.
* gdb.multi/tids.c: New file.
* gdb.multi/tids.exp: New file.
gdb/doc/ChangeLog:
2016-01-07 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Threads): Document per-inferior thread IDs,
qualified thread IDs, global thread IDs and thread ID lists.
(Set Watchpoints, Thread-Specific Breakpoints): Adjust to refer to
thread IDs.
(Convenience Vars): Document the $_thread convenience variable.
(Ada Tasks): Adjust to refer to thread IDs.
(GDB/MI Async Records, GDB/MI Thread Commands, GDB/MI Ada Tasking
Commands, GDB/MI Variable Objects): Update to mention global
thread IDs.
* guile.texi (Breakpoints In Guile)
<breakpoint-thread/set-breakpoint-thread breakpoint>: Mention
global thread IDs instead of thread IDs.
* python.texi (Threads In Python): Adjust documentation of
InferiorThread.num.
(Breakpoint.thread): Mention global thread IDs instead of thread
IDs.
2016-01-13 11:56:07 +01:00
|
|
|
/* Display thread information block of the current thread. */
|
2010-04-16 09:49:37 +02:00
|
|
|
|
|
|
|
static void
|
2017-09-10 05:22:05 +02:00
|
|
|
display_tib (const char * args, int from_tty)
|
2010-04-16 09:49:37 +02:00
|
|
|
{
|
Per-inferior/Inferior-qualified thread IDs
This commit changes GDB to track thread numbers per-inferior. Then,
if you're debugging multiple inferiors, GDB displays
"inferior-num.thread-num" instead of just "thread-num" whenever it
needs to display a thread:
(gdb) info inferiors
Num Description Executable
1 process 6022 /home/pedro/gdb/tests/threads
* 2 process 6037 /home/pedro/gdb/tests/threads
(gdb) info threads
Id Target Id Frame
1.1 Thread 0x7ffff7fc2740 (LWP 6022) "threads" (running)
1.2 Thread 0x7ffff77c0700 (LWP 6028) "threads" (running)
1.3 Thread 0x7ffff7fc2740 (LWP 6032) "threads" (running)
2.1 Thread 0x7ffff7fc1700 (LWP 6037) "threads" (running)
2.2 Thread 0x7ffff77c0700 (LWP 6038) "threads" (running)
* 2.3 Thread 0x7ffff7fc2740 (LWP 6039) "threads" (running)
(gdb)
...
(gdb) thread 1.1
[Switching to thread 1.1 (Thread 0x7ffff7fc2740 (LWP 8155))]
(gdb)
...
etc.
You can still use "thread NUM", in which case GDB infers you're
referring to thread NUM of the current inferior.
The $_thread convenience var and Python's InferiorThread.num attribute
are remapped to the new per-inferior thread number. It's a backward
compatibility break, but since it only matters when debugging multiple
inferiors, I think it's worth doing.
Because MI thread IDs need to be a single integer, we keep giving
threads a global identifier, _in addition_ to the per-inferior number,
and make MI always refer to the global thread IDs. IOW, nothing
changes from a MI frontend's perspective.
Similarly, since Python's Breakpoint.thread and Guile's
breakpoint-thread/set-breakpoint-thread breakpoint methods need to
work with integers, those are adjusted to work with global thread IDs
too. Follow up patches will provide convenient means to access
threads' global IDs.
To avoid potencially confusing users (which also avoids updating much
of the testsuite), if there's only one inferior and its ID is "1",
IOW, the user hasn't done anything multi-process/inferior related,
then the "INF." part of thread IDs is not shown. E.g,.:
(gdb) info inferiors
Num Description Executable
* 1 process 15275 /home/pedro/gdb/tests/threads
(gdb) info threads
Id Target Id Frame
* 1 Thread 0x7ffff7fc1740 (LWP 15275) "threads" main () at threads.c:40
(gdb) add-inferior
Added inferior 2
(gdb) info threads
Id Target Id Frame
* 1.1 Thread 0x7ffff7fc1740 (LWP 15275) "threads" main () at threads.c:40
(gdb)
No regressions on x86_64 Fedora 20.
gdb/ChangeLog:
2016-01-13 Pedro Alves <palves@redhat.com>
* NEWS: Mention that thread IDs are now per inferior and global
thread IDs.
* Makefile.in (SFILES): Add tid-parse.c.
(COMMON_OBS): Add tid-parse.o.
(HFILES_NO_SRCDIR): Add tid-parse.h.
* ada-tasks.c: Adjust to use ptid_to_global_thread_id.
* breakpoint.c (insert_breakpoint_locations)
(remove_threaded_breakpoints, bpstat_check_breakpoint_conditions)
(print_one_breakpoint_location, set_longjmp_breakpoint)
(check_longjmp_breakpoint_for_call_dummy)
(set_momentary_breakpoint): Adjust to use global IDs.
(find_condition_and_thread, watch_command_1): Use parse_thread_id.
(until_break_command, longjmp_bkpt_dtor)
(breakpoint_re_set_thread, insert_single_step_breakpoint): Adjust
to use global IDs.
* dummy-frame.c (pop_dummy_frame_bpt): Adjust to use
ptid_to_global_thread_id.
* elfread.c (elf_gnu_ifunc_resolver_stop): Likewise.
* gdbthread.h (struct thread_info): Rename field 'num' to
'global_num. Add new fields 'per_inf_num' and 'inf'.
(thread_id_to_pid): Rename thread_id_to_pid to
global_thread_id_to_ptid.
(pid_to_thread_id): Rename to ...
(ptid_to_global_thread_id): ... this.
(valid_thread_id): Rename to ...
(valid_global_thread_id): ... this.
(find_thread_id): Rename to ...
(find_thread_global_id): ... this.
(ALL_THREADS, ALL_THREADS_BY_INFERIOR): Declare.
(print_thread_info): Add comment.
* tid-parse.h: New file.
* tid-parse.c: New file.
* infcmd.c (step_command_fsm_prepare)
(step_command_fsm_should_stop): Adjust to use the global thread
ID.
(until_next_command, until_next_command)
(finish_command_fsm_should_stop): Adjust to use the global thread
ID.
(attach_post_wait): Adjust to check the inferior number too.
* inferior.h (struct inferior) <highest_thread_num>: New field.
* infrun.c (handle_signal_stop)
(insert_exception_resume_breakpoint)
(insert_exception_resume_from_probe): Adjust to use the global
thread ID.
* record-btrace.c (record_btrace_open): Use global thread IDs.
* remote.c (process_initial_stop_replies): Also consider the
inferior number.
* target.c (target_pre_inferior): Clear the inferior's highest
thread num.
* thread.c (clear_thread_inferior_resources): Adjust to use the
global thread ID.
(new_thread): New inferior parameter. Adjust to use it. Set both
the thread's global ID and the thread's per-inferior ID.
(add_thread_silent): Adjust.
(find_thread_global_id): New.
(find_thread_id): Make static. Adjust to rename.
(valid_thread_id): Rename to ...
(valid_global_thread_id): ... this.
(pid_to_thread_id): Rename to ...
(ptid_to_global_thread_id): ... this.
(thread_id_to_pid): Rename to ...
(global_thread_id_to_ptid): ... this. Adjust.
(first_thread_of_process): Adjust.
(do_captured_list_thread_ids): Adjust to use global thread IDs.
(should_print_thread): New function.
(print_thread_info): Rename to ...
(print_thread_info_1): ... this, and add new show_global_ids
parameter. Handle it. Iterate over inferiors.
(print_thread_info): Reimplement as wrapper around
print_thread_info_1.
(show_inferior_qualified_tids): New function.
(print_thread_id): Use it.
(tp_array_compar): Compare inferior numbers too.
(thread_apply_command): Use tid_range_parser.
(do_captured_thread_select): Use parse_thread_id.
(thread_id_make_value): Adjust.
(_initialize_thread): Adjust "info threads" help string.
* varobj.c (struct varobj_root): Update comment.
(varobj_create): Adjust to use global thread IDs.
(value_of_root_1): Adjust to use global_thread_id_to_ptid.
* windows-tdep.c (display_tib): No longer accept an argument.
* cli/cli-utils.c (get_number_trailer): Make extern.
* cli/cli-utils.h (get_number_trailer): Declare.
(get_number_const): Adjust documentation.
* mi/mi-cmd-var.c (mi_cmd_var_update_iter): Adjust to use global
thread IDs.
* mi/mi-interp.c (mi_new_thread, mi_thread_exit)
(mi_on_normal_stop, mi_output_running_pid, mi_on_resume):
* mi/mi-main.c (mi_execute_command, mi_cmd_execute): Likewise.
* guile/scm-breakpoint.c (gdbscm_set_breakpoint_thread_x):
Likewise.
* python/py-breakpoint.c (bppy_set_thread): Likewise.
* python/py-finishbreakpoint.c (bpfinishpy_init): Likewise.
* python/py-infthread.c (thpy_get_num): Add comment and return the
per-inferior thread ID.
(thread_object_getset): Update comment of "num".
gdb/testsuite/ChangeLog:
2016-01-07 Pedro Alves <palves@redhat.com>
* gdb.base/break.exp: Adjust to output changes.
* gdb.base/hbreak2.exp: Likewise.
* gdb.base/sepdebug.exp: Likewise.
* gdb.base/watch_thread_num.exp: Likewise.
* gdb.linespec/keywords.exp: Likewise.
* gdb.multi/info-threads.exp: Likewise.
* gdb.threads/thread-find.exp: Likewise.
* gdb.multi/tids.c: New file.
* gdb.multi/tids.exp: New file.
gdb/doc/ChangeLog:
2016-01-07 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Threads): Document per-inferior thread IDs,
qualified thread IDs, global thread IDs and thread ID lists.
(Set Watchpoints, Thread-Specific Breakpoints): Adjust to refer to
thread IDs.
(Convenience Vars): Document the $_thread convenience variable.
(Ada Tasks): Adjust to refer to thread IDs.
(GDB/MI Async Records, GDB/MI Thread Commands, GDB/MI Ada Tasking
Commands, GDB/MI Variable Objects): Update to mention global
thread IDs.
* guile.texi (Breakpoints In Guile)
<breakpoint-thread/set-breakpoint-thread breakpoint>: Mention
global thread IDs instead of thread IDs.
* python.texi (Threads In Python): Adjust documentation of
InferiorThread.num.
(Breakpoint.thread): Mention global thread IDs instead of thread
IDs.
2016-01-13 11:56:07 +01:00
|
|
|
if (!ptid_equal (inferior_ptid, null_ptid))
|
2010-04-16 09:49:37 +02:00
|
|
|
display_one_tib (inferior_ptid);
|
|
|
|
}
|
2009-01-11 14:10:44 +01:00
|
|
|
|
|
|
|
void
|
2009-01-13 05:14:07 +01:00
|
|
|
windows_xfer_shared_library (const char* so_name, CORE_ADDR load_addr,
|
* defs.h (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter.
* utils.c (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter, use it instead of current_gdbarch.
* ui-out.h (ui_out_field_core_addr): Add GDBARCH parameter.
* ui-out.c (ui_out_field_core_addr): Add GDBARCH parameter,
use it instead of current_gdbarch.
Update calls to ui_out_field_core_addr to pass architecture:
* ada-lang.c (print_one_exception): Update.
* breakpoint.c (print_one_breakpoint_location,
print_one_exception_catchpoint): Update.
* disasm.c (dump_insns): Update.
* darwin-nat-info.c (darwin_debug_regions_recurse): Update.
* mi/mi-main.c (mi_cmd_data_read_memory): Update.
* mi/mi-symbol-cmds.c: Include "objfiles.h".
(mi_cmd_symbol_list_lines): Update.
* stack.c (print_frame_info, print_frame): Update.
Update callers of paddress to pass architecture:
* ada-tasks.c (info_task): Update.
* ada-valprint.c (ada_val_print_1): Update.
* annotate.c (annotate_source, annotate_frame_begin): Update.
* breakpoint.c (insert_bp_location, describe_other_breakpoints,
mention): Update.
* cli/cli-cmds.c (edit_command, list_command, print_disassembly):
Update.
* corefile.c (memory_error): Update.
* c-valprint.c (print_function_pointer_address, c_val_print): Update.
* disasm.c (dis_asm_print_address): Update.
* exec.c (print_section_info): Update.
* f-valprint.c (f_val_print): Update.
* infcmd.c: Include "arch-utils.h".
(jump_command, program_info): Update.
* linux-fork.c: Include "arch-utils.h".
(info_forks_command): Update.
* m2-valprint.c (print_function_pointer_address,
print_unpacked_pointer, print_variable_at_address,
m2_val_print): Update.
* m32r-rom.c (m32r_load_section, m32r_load, m32r_upload_command):
Update.
* printcmd.c (print_address, print_address_demangle, address_info):
Update.
* p-valprint.c (pascal_val_print): Update.
* source.c: Include "arch-utils.h".
(line_info): Update.
* stack.c (frame_info, print_block_frame_labels): Update.
* symfile.c (add_symbol_file_command, list_overlays_command): Update.
* symmisc.c (dump_msymbols, dump_psymtab, dump_symtab_1,
print_symbol, print_partial_symbols, maintenance_info_psymtabs,
maintenance_check_symtabs): Update.
* symtab.c (find_pc_sect_symtab): Update.
* target.c (deprecated_debug_xfer_memory): Update.
* tracepoint.c (scope_info): Update.
* tui/tui-stack.c (tui_make_status_line): Update.
* valprint.c (val_print_string): Update.
Update callers of paddr_nz to use paddress instead (keeping
user-visible output identical):
* alpha-tdep.c (alpha_heuristic_proc_start): Update.
* amd64-tdep.c (fixup_riprel, amd64_displaced_step_copy_insn,
amd64_displaced_step_fixup): Update.
* arch-utils.c (simple_displaced_step_copy_insn): Update.
* auxv.c (fprint_target_auxv): Update.
* breakpoint.c (insert_single_step_breakpoint): Update.
* buildsym.c (finish_block): Update.
* cli/cli-dump.c (restore_section_callback): Update.
* fbsd-nat.c (fbsd_find_memory_regions): Update.
* frame.c (frame_unwind_register_value): Update.
* gcore.c (gcore_create_callback): Update.
* hppa-tdep.c (hppa_frame_cache, hppa_skip_trampoline_code): Update.
* i386-tdep.c (i386_displaced_step_fixup, i386_record_modrm,
i386_record_lea_modrm_addr, i386_record_lea_modrm,
i386_process_record): Update.
* ia64-tdep.c (ia64_frame_this_id, ia64_sigtramp_frame_this_id,
ia64_libunwind_frame_this_id, ia64_libunwind_sigtramp_frame_this_id,
ia64_dummy_id, ia64_access_reg, ia64_access_rse_reg): Update.
* infrun.c (displaced_step_prepare, displaced_step_fixup,
handle_inferior_event, insert_step_resume_breakpoint_at_sal,
insert_longjmp_resume_breakpoint): Update.
* linux-nat.c (linux_nat_find_memory_regions): Update.
* linux-record.c (record_linux_system_call): Update.
* mips-tdep.c (heuristic_proc_start, mips_eabi_push_dummy_call,
mips_n32n64_push_dummy_call, mips_o32_push_dummy_call,
mips_o64_push_dummy_call): Update.
* monitor.c (monitor_error, monitor_remove_breakpoint): Update.
* record.c (record_arch_list_add_mem, record_wait,
record_xfer_partial): Update.
* remote-mips.c (mips_fetch_word, mips_check_lsi_error,
mips_common_breakpoint): Update.
* remote-sim.c (gdbsim_xfer_inferior_memory): Update.
* rs6000-tdep.c (ppc_displaced_step_fixup): Update.
* solib-som.c (som_current_sos): Update.
* symfile.c (load_progress, generic_load): Update.
* symfile-mem.c (add_vsyscall_page): Update.
* valops.c (value_fetch_lazy): Update.
* windows-tdep.c (windows_xfer_shared_library): Update.
Update callers of paddr_nz to use paddress instead (changing
user-visible output to make it more correct):
* dwarf2loc.c (locexpr_describe_location): Update.
* ia64-tdep.c (ia64_memory_insert_breakpoint,
ia64_memory_remove_breakpoint): Update.
* jv-valprint.c (java_value_print): Update.
* m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
* monitor.c (monitor_read_memory): Update.
Update callers of paddr to use paddress instead (changing
user-visible output to make it more correct):
* arm-tdep.c (arm_push_dummy_call): Update.
* breakpoint.c (insert_bp_location, create_thread_event_breakpoint,
create_breakpoint): Update.
* darwin-nat-info.c (darwin_debug_regions): Update.
* dcache.c (dcache_info): Update.
* dsrec.c (load_srec, make_srec): Update.
* dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program,
dwarf2_frame_cache): Update.
* gcore.c (gcore_copy_callback): Update.
* gnu-nat.c (gnu_xfer_memory): Update.
* mips-linux-nat.c (mips_show_dr): Update.
* monitor.c (monitor_write_memory, monitor_insert_breakpoint,
monitor_remove_breakpoint): Update.
* remote.c (compare_sections_command): Update.
* remote-m32r-sdi.c (m32r_xfer_memory, m32r_insert_breakpoint,
m32r_remove_breakpoint, m32r_insert_watchpoint,
m32r_remove_watchpoint): Update.
* sol-thread.c (info_cb): Update.
* symfile.c (load_progress): Update.
Update callers of paddress or paddr_nz to use hex_string instead
(changes output of internal/error/debug messages only):
* dwarf2read.c (dump_die_shallow): Update.
* frame.c (fprint_field, fprint_frame, frame_pc_unwind,
get_frame_func, create_new_frame): Update.
* hppa-tdep.c (find_unwind_entry, unwind_command): Update.
* ia64-tdep.c (get_kernel_table, ia64_find_proc_info_x,
ia64_get_dyn_info_list): Update.
* maint.c (maintenance_translate_address): Update.
* mi/mi-cmd-var.c (mi_cmd_var_create): Update.
* target.c (target_flash_erase): Update.
Update callers of paddr/paddr_nz to use phex/phex_nz instead,
using an appropriate address size. Remove use of strlen_paddr.
* exec.c (exec_files_info): Update.
* i386-nat.c (i386_show_dr): Update.
* remote.c (remote_flash_erase): Update.
* m32r-rom.c (m32r_load_section): Update.
* monitor.c (monitor_vsprintf, monitor_store_register): Update.
* remote.c (remote_check_symbols, remote_search_memory): Update.
* remote-mips.c (mips_request, mips_common_breakpoint): Update.
* scm-valprint.c (scm_ipruk, scm_scmval_print): Update.
* sh64-tdep.c (sh64_show_media_regs, sh64_show_compact_regs): Update.
* sh-tdep.c (sh_generic_show_regs, sh3_show_regs, sh2e_show_regs,
sh2a_show_regs, sh2a_nofpu_show_regs, sh3e_show_regs,
sh3_dsp_show_regs, sh4_show_regs, sh4_nofpu_show_regs,
sh_dsp_show_regs): Update.
* xcoffsolib.c (sharedlibrary_command): Update.
* maint.c (maint_print_section_info): Add ADDR_SIZE parameter.
Use hex_string_custom instead of paddr.
(print_bfd_section_info): Pass address size.
(print_objfile_section_info): Likewise.
* annotate.h (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* annotate.c (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* source.c (identify_source_line): Update call to annotate_source.
* stack.c (print_frame_info, print_frame): Update call to
annotate_frame_begin.
* breakpoint.c (describe_other_breakpoints): Add GDBARCH parameter.
(create_breakpoint, create_ada_exception_breakpoint): Update call.
* stack.c (print_block_frame_labels): Add GDBARCH parameter.
(print_frame_label_vars): Update call.
* symmisc.c (print_partial_symbols): Add GDBARCH parameter.
(dump_psymtab): Update call to print_partial_symbols.
(struct print_symbol_args): Add GDBARCH member.
(dump_symtab_1): Set print_symbol_args architecture member.
(print_symbol): Use it.
* windows-tdep.h (windows_xfer_shared_library): Add GDBARCH
parameter.
* windows-tdep.c (windows_xfer_shared_library): Likewise.
* i386-cygwin-tdep.c (struct cpms_data): Add GDBARCH member.
(core_process_module_section): Pass architecture from cpms_data to
windows_xfer_shared_library.
(windows_core_xfer_shared_libraries): Initialize cmps_data
architecture member.
* windows-nat.c (windows_xfer_shared_libraries): Pass architecture
to windows_xfer_shared_library.
* defs.h (print_address): Add GDBARCH parameter.
* printcmd.c (print_address): Add GDBARCH parameter.
(print_scalar_formatted, do_examine): Update call.
* findcmd.c (find_command): Update call.
* tracepoint.c: Include "arch-utils.h".
(trace_find_line_command): Update call.
* tui/tui-disasm.c (tui_disassemble): Update call.
* value.h (print_address_demangle): Add GDBARCH parameter.
* printcmd.c (print_address_demangle): Add GDBARCH parameter.
* c-valprint.c (print_function_pointer_address, c_val_print):
Update call.
* f-valprint.c (f_val_print): Update call.
* gnu-v3-abi.c (gnuv3_print_method_ptr): Update call.
* jv-valprint.c (java_val_print): Update call.
* m2-valprint.c (print_function_pointer_address, m2_val_print):
Update call.
* p-valprint.c (pascal_val_print): Update call.
* disasm.c (gdb_disassemble_info): Install architecture into
di.application_data field.
testsuite/ChangeLog:
* gdb.threads/tls-shared.exp: Update to locexpr_describe_location
change to prefix TLS offset in hex with 0x.
doc/ChangeLog:
* gdbint.texinfo (Item Output Functions): Update signature
for ui_out_field_core_addr.
2009-07-02 19:21:10 +02:00
|
|
|
struct gdbarch *gdbarch, struct obstack *obstack)
|
2009-01-11 14:10:44 +01:00
|
|
|
{
|
2012-12-13 11:44:45 +01:00
|
|
|
CORE_ADDR text_offset;
|
|
|
|
|
2009-01-11 14:10:44 +01:00
|
|
|
obstack_grow_str (obstack, "<library name=\"");
|
2017-09-16 14:19:31 +02:00
|
|
|
std::string p = xml_escape_text (so_name);
|
|
|
|
obstack_grow_str (obstack, p.c_str ());
|
* defs.h (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter.
* utils.c (strlen_paddr, paddr, paddr_nz): Remove.
(paddress): Add GDBARCH parameter, use it instead of current_gdbarch.
* ui-out.h (ui_out_field_core_addr): Add GDBARCH parameter.
* ui-out.c (ui_out_field_core_addr): Add GDBARCH parameter,
use it instead of current_gdbarch.
Update calls to ui_out_field_core_addr to pass architecture:
* ada-lang.c (print_one_exception): Update.
* breakpoint.c (print_one_breakpoint_location,
print_one_exception_catchpoint): Update.
* disasm.c (dump_insns): Update.
* darwin-nat-info.c (darwin_debug_regions_recurse): Update.
* mi/mi-main.c (mi_cmd_data_read_memory): Update.
* mi/mi-symbol-cmds.c: Include "objfiles.h".
(mi_cmd_symbol_list_lines): Update.
* stack.c (print_frame_info, print_frame): Update.
Update callers of paddress to pass architecture:
* ada-tasks.c (info_task): Update.
* ada-valprint.c (ada_val_print_1): Update.
* annotate.c (annotate_source, annotate_frame_begin): Update.
* breakpoint.c (insert_bp_location, describe_other_breakpoints,
mention): Update.
* cli/cli-cmds.c (edit_command, list_command, print_disassembly):
Update.
* corefile.c (memory_error): Update.
* c-valprint.c (print_function_pointer_address, c_val_print): Update.
* disasm.c (dis_asm_print_address): Update.
* exec.c (print_section_info): Update.
* f-valprint.c (f_val_print): Update.
* infcmd.c: Include "arch-utils.h".
(jump_command, program_info): Update.
* linux-fork.c: Include "arch-utils.h".
(info_forks_command): Update.
* m2-valprint.c (print_function_pointer_address,
print_unpacked_pointer, print_variable_at_address,
m2_val_print): Update.
* m32r-rom.c (m32r_load_section, m32r_load, m32r_upload_command):
Update.
* printcmd.c (print_address, print_address_demangle, address_info):
Update.
* p-valprint.c (pascal_val_print): Update.
* source.c: Include "arch-utils.h".
(line_info): Update.
* stack.c (frame_info, print_block_frame_labels): Update.
* symfile.c (add_symbol_file_command, list_overlays_command): Update.
* symmisc.c (dump_msymbols, dump_psymtab, dump_symtab_1,
print_symbol, print_partial_symbols, maintenance_info_psymtabs,
maintenance_check_symtabs): Update.
* symtab.c (find_pc_sect_symtab): Update.
* target.c (deprecated_debug_xfer_memory): Update.
* tracepoint.c (scope_info): Update.
* tui/tui-stack.c (tui_make_status_line): Update.
* valprint.c (val_print_string): Update.
Update callers of paddr_nz to use paddress instead (keeping
user-visible output identical):
* alpha-tdep.c (alpha_heuristic_proc_start): Update.
* amd64-tdep.c (fixup_riprel, amd64_displaced_step_copy_insn,
amd64_displaced_step_fixup): Update.
* arch-utils.c (simple_displaced_step_copy_insn): Update.
* auxv.c (fprint_target_auxv): Update.
* breakpoint.c (insert_single_step_breakpoint): Update.
* buildsym.c (finish_block): Update.
* cli/cli-dump.c (restore_section_callback): Update.
* fbsd-nat.c (fbsd_find_memory_regions): Update.
* frame.c (frame_unwind_register_value): Update.
* gcore.c (gcore_create_callback): Update.
* hppa-tdep.c (hppa_frame_cache, hppa_skip_trampoline_code): Update.
* i386-tdep.c (i386_displaced_step_fixup, i386_record_modrm,
i386_record_lea_modrm_addr, i386_record_lea_modrm,
i386_process_record): Update.
* ia64-tdep.c (ia64_frame_this_id, ia64_sigtramp_frame_this_id,
ia64_libunwind_frame_this_id, ia64_libunwind_sigtramp_frame_this_id,
ia64_dummy_id, ia64_access_reg, ia64_access_rse_reg): Update.
* infrun.c (displaced_step_prepare, displaced_step_fixup,
handle_inferior_event, insert_step_resume_breakpoint_at_sal,
insert_longjmp_resume_breakpoint): Update.
* linux-nat.c (linux_nat_find_memory_regions): Update.
* linux-record.c (record_linux_system_call): Update.
* mips-tdep.c (heuristic_proc_start, mips_eabi_push_dummy_call,
mips_n32n64_push_dummy_call, mips_o32_push_dummy_call,
mips_o64_push_dummy_call): Update.
* monitor.c (monitor_error, monitor_remove_breakpoint): Update.
* record.c (record_arch_list_add_mem, record_wait,
record_xfer_partial): Update.
* remote-mips.c (mips_fetch_word, mips_check_lsi_error,
mips_common_breakpoint): Update.
* remote-sim.c (gdbsim_xfer_inferior_memory): Update.
* rs6000-tdep.c (ppc_displaced_step_fixup): Update.
* solib-som.c (som_current_sos): Update.
* symfile.c (load_progress, generic_load): Update.
* symfile-mem.c (add_vsyscall_page): Update.
* valops.c (value_fetch_lazy): Update.
* windows-tdep.c (windows_xfer_shared_library): Update.
Update callers of paddr_nz to use paddress instead (changing
user-visible output to make it more correct):
* dwarf2loc.c (locexpr_describe_location): Update.
* ia64-tdep.c (ia64_memory_insert_breakpoint,
ia64_memory_remove_breakpoint): Update.
* jv-valprint.c (java_value_print): Update.
* m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
* monitor.c (monitor_read_memory): Update.
Update callers of paddr to use paddress instead (changing
user-visible output to make it more correct):
* arm-tdep.c (arm_push_dummy_call): Update.
* breakpoint.c (insert_bp_location, create_thread_event_breakpoint,
create_breakpoint): Update.
* darwin-nat-info.c (darwin_debug_regions): Update.
* dcache.c (dcache_info): Update.
* dsrec.c (load_srec, make_srec): Update.
* dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program,
dwarf2_frame_cache): Update.
* gcore.c (gcore_copy_callback): Update.
* gnu-nat.c (gnu_xfer_memory): Update.
* mips-linux-nat.c (mips_show_dr): Update.
* monitor.c (monitor_write_memory, monitor_insert_breakpoint,
monitor_remove_breakpoint): Update.
* remote.c (compare_sections_command): Update.
* remote-m32r-sdi.c (m32r_xfer_memory, m32r_insert_breakpoint,
m32r_remove_breakpoint, m32r_insert_watchpoint,
m32r_remove_watchpoint): Update.
* sol-thread.c (info_cb): Update.
* symfile.c (load_progress): Update.
Update callers of paddress or paddr_nz to use hex_string instead
(changes output of internal/error/debug messages only):
* dwarf2read.c (dump_die_shallow): Update.
* frame.c (fprint_field, fprint_frame, frame_pc_unwind,
get_frame_func, create_new_frame): Update.
* hppa-tdep.c (find_unwind_entry, unwind_command): Update.
* ia64-tdep.c (get_kernel_table, ia64_find_proc_info_x,
ia64_get_dyn_info_list): Update.
* maint.c (maintenance_translate_address): Update.
* mi/mi-cmd-var.c (mi_cmd_var_create): Update.
* target.c (target_flash_erase): Update.
Update callers of paddr/paddr_nz to use phex/phex_nz instead,
using an appropriate address size. Remove use of strlen_paddr.
* exec.c (exec_files_info): Update.
* i386-nat.c (i386_show_dr): Update.
* remote.c (remote_flash_erase): Update.
* m32r-rom.c (m32r_load_section): Update.
* monitor.c (monitor_vsprintf, monitor_store_register): Update.
* remote.c (remote_check_symbols, remote_search_memory): Update.
* remote-mips.c (mips_request, mips_common_breakpoint): Update.
* scm-valprint.c (scm_ipruk, scm_scmval_print): Update.
* sh64-tdep.c (sh64_show_media_regs, sh64_show_compact_regs): Update.
* sh-tdep.c (sh_generic_show_regs, sh3_show_regs, sh2e_show_regs,
sh2a_show_regs, sh2a_nofpu_show_regs, sh3e_show_regs,
sh3_dsp_show_regs, sh4_show_regs, sh4_nofpu_show_regs,
sh_dsp_show_regs): Update.
* xcoffsolib.c (sharedlibrary_command): Update.
* maint.c (maint_print_section_info): Add ADDR_SIZE parameter.
Use hex_string_custom instead of paddr.
(print_bfd_section_info): Pass address size.
(print_objfile_section_info): Likewise.
* annotate.h (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* annotate.c (annotate_source): Add GDBARCH parameter.
(annotate_frame_begin): Likewise.
* source.c (identify_source_line): Update call to annotate_source.
* stack.c (print_frame_info, print_frame): Update call to
annotate_frame_begin.
* breakpoint.c (describe_other_breakpoints): Add GDBARCH parameter.
(create_breakpoint, create_ada_exception_breakpoint): Update call.
* stack.c (print_block_frame_labels): Add GDBARCH parameter.
(print_frame_label_vars): Update call.
* symmisc.c (print_partial_symbols): Add GDBARCH parameter.
(dump_psymtab): Update call to print_partial_symbols.
(struct print_symbol_args): Add GDBARCH member.
(dump_symtab_1): Set print_symbol_args architecture member.
(print_symbol): Use it.
* windows-tdep.h (windows_xfer_shared_library): Add GDBARCH
parameter.
* windows-tdep.c (windows_xfer_shared_library): Likewise.
* i386-cygwin-tdep.c (struct cpms_data): Add GDBARCH member.
(core_process_module_section): Pass architecture from cpms_data to
windows_xfer_shared_library.
(windows_core_xfer_shared_libraries): Initialize cmps_data
architecture member.
* windows-nat.c (windows_xfer_shared_libraries): Pass architecture
to windows_xfer_shared_library.
* defs.h (print_address): Add GDBARCH parameter.
* printcmd.c (print_address): Add GDBARCH parameter.
(print_scalar_formatted, do_examine): Update call.
* findcmd.c (find_command): Update call.
* tracepoint.c: Include "arch-utils.h".
(trace_find_line_command): Update call.
* tui/tui-disasm.c (tui_disassemble): Update call.
* value.h (print_address_demangle): Add GDBARCH parameter.
* printcmd.c (print_address_demangle): Add GDBARCH parameter.
* c-valprint.c (print_function_pointer_address, c_val_print):
Update call.
* f-valprint.c (f_val_print): Update call.
* gnu-v3-abi.c (gnuv3_print_method_ptr): Update call.
* jv-valprint.c (java_val_print): Update call.
* m2-valprint.c (print_function_pointer_address, m2_val_print):
Update call.
* p-valprint.c (pascal_val_print): Update call.
* disasm.c (gdb_disassemble_info): Install architecture into
di.application_data field.
testsuite/ChangeLog:
* gdb.threads/tls-shared.exp: Update to locexpr_describe_location
change to prefix TLS offset in hex with 0x.
doc/ChangeLog:
* gdbint.texinfo (Item Output Functions): Update signature
for ui_out_field_core_addr.
2009-07-02 19:21:10 +02:00
|
|
|
obstack_grow_str (obstack, "\"><segment address=\"");
|
Use class to manage BFD reference counts
This introduces a new specialization of gdb::ref_ptr that can be used
to manage BFD reference counts. Then it changes most places in gdb to
use this new class, rather than explicit reference-counting or
cleanups. This patch removes make_cleanup_bfd_unref.
If you look you will see a couple of spots using "release" where a use
of gdb_bfd_ref_ptr would be cleaner. These will be fixed in the next
patch.
I think this patch fixes some latent bugs. For example, it seems to
me that previously objfpy_add_separate_debug_file leaked a BFD.
I'm not 100% certain that the macho_symfile_read_all_oso change is
correct. The existing code here is hard for me to follow. One goal
of this sort of automated reference counting, though, is to make it
more difficult to make logic errors; so hopefully the code is clear
now.
2017-01-10 Tom Tromey <tom@tromey.com>
* windows-tdep.c (windows_xfer_shared_library): Update.
* windows-nat.c (windows_make_so): Update.
* utils.h (make_cleanup_bfd_unref): Remove.
* utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove.
* symfile.h (symfile_bfd_open)
(find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr.
* symfile.c (read_symbols, symbol_file_add)
(separate_debug_file_exists): Update.
(symfile_bfd_open): Return gdb_bfd_ref_ptr.
(generic_load, reread_symbols): Update.
* symfile-mem.c (symbol_file_add_from_memory): Update.
* spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr.
(spu_symbol_file_add_from_memory): Update.
* solist.h (struct target_so_ops) <bfd_open>: Return
gdb_bfd_ref_ptr.
(solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr.
* solib.c (solib_bfd_fopen, solib_bfd_open): Return
gdb_bfd_ref_ptr.
(solib_map_sections, reload_shared_libraries_1): Update.
* solib-svr4.c (enable_break): Update.
* solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr.
* solib-frv.c (enable_break2): Update.
* solib-dsbt.c (enable_break): Update.
* solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return
gdb_bfd_ref_ptr.
(darwin_solib_get_all_image_info_addr_at_init): Update.
(darwin_bfd_open): Return gdb_bfd_ref_ptr.
* solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr.
* record-full.c (record_full_save): Update.
* python/py-objfile.c (objfpy_add_separate_debug_file): Update.
* procfs.c (insert_dbx_link_bpt_in_file): Update.
* minidebug.c (find_separate_debug_file_in_section): Return
gdb_bfd_ref_ptr.
* machoread.c (macho_add_oso_symfile): Change abfd to
gdb_bfd_ref_ptr.
(macho_symfile_read_all_oso): Update.
(macho_check_dsym): Return gdb_bfd_ref_ptr.
(macho_symfile_read): Update.
* jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr.
(jit_bfd_try_read_symtab): Update.
* gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec)
(gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
gdb_bfd_ref_ptr.
(gdb_bfd_ref_policy): New struct.
(gdb_bfd_ref_ptr): New typedef.
* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec)
(gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
gdb_bfd_ref_ptr.
* gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr.
* gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr.
(gcore_command): Update.
* exec.c (exec_file_attach): Update.
* elfread.c (elf_symfile_read): Update.
* dwarf2read.c (dwarf2_get_dwz_file): Update.
(try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr.
(open_and_init_dwo_file): Update.
(open_dwp_file): Return gdb_bfd_ref_ptr.
(open_and_init_dwp_file): Update.
* corelow.c (core_open): Update.
* compile/compile-object-load.c (compile_object_load): Update.
* common/gdb_ref_ptr.h (ref_ptr::operator->): New operator.
* coffread.c (coff_symfile_read): Update.
* cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return
gdb_bfd_ref_ptr. Rename.
(dump_bfd_file, restore_command): Update.
* build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
* build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
(find_separate_debug_file_by_buildid): Update.
2016-11-21 19:12:23 +01:00
|
|
|
gdb_bfd_ref_ptr dll (gdb_bfd_open (so_name, gnutarget, -1));
|
2012-12-13 11:44:45 +01:00
|
|
|
/* The following calls are OK even if dll is NULL.
|
|
|
|
The default value 0x1000 is returned by pe_text_section_offset
|
|
|
|
in that case. */
|
Use class to manage BFD reference counts
This introduces a new specialization of gdb::ref_ptr that can be used
to manage BFD reference counts. Then it changes most places in gdb to
use this new class, rather than explicit reference-counting or
cleanups. This patch removes make_cleanup_bfd_unref.
If you look you will see a couple of spots using "release" where a use
of gdb_bfd_ref_ptr would be cleaner. These will be fixed in the next
patch.
I think this patch fixes some latent bugs. For example, it seems to
me that previously objfpy_add_separate_debug_file leaked a BFD.
I'm not 100% certain that the macho_symfile_read_all_oso change is
correct. The existing code here is hard for me to follow. One goal
of this sort of automated reference counting, though, is to make it
more difficult to make logic errors; so hopefully the code is clear
now.
2017-01-10 Tom Tromey <tom@tromey.com>
* windows-tdep.c (windows_xfer_shared_library): Update.
* windows-nat.c (windows_make_so): Update.
* utils.h (make_cleanup_bfd_unref): Remove.
* utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove.
* symfile.h (symfile_bfd_open)
(find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr.
* symfile.c (read_symbols, symbol_file_add)
(separate_debug_file_exists): Update.
(symfile_bfd_open): Return gdb_bfd_ref_ptr.
(generic_load, reread_symbols): Update.
* symfile-mem.c (symbol_file_add_from_memory): Update.
* spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr.
(spu_symbol_file_add_from_memory): Update.
* solist.h (struct target_so_ops) <bfd_open>: Return
gdb_bfd_ref_ptr.
(solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr.
* solib.c (solib_bfd_fopen, solib_bfd_open): Return
gdb_bfd_ref_ptr.
(solib_map_sections, reload_shared_libraries_1): Update.
* solib-svr4.c (enable_break): Update.
* solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr.
* solib-frv.c (enable_break2): Update.
* solib-dsbt.c (enable_break): Update.
* solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return
gdb_bfd_ref_ptr.
(darwin_solib_get_all_image_info_addr_at_init): Update.
(darwin_bfd_open): Return gdb_bfd_ref_ptr.
* solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr.
* record-full.c (record_full_save): Update.
* python/py-objfile.c (objfpy_add_separate_debug_file): Update.
* procfs.c (insert_dbx_link_bpt_in_file): Update.
* minidebug.c (find_separate_debug_file_in_section): Return
gdb_bfd_ref_ptr.
* machoread.c (macho_add_oso_symfile): Change abfd to
gdb_bfd_ref_ptr.
(macho_symfile_read_all_oso): Update.
(macho_check_dsym): Return gdb_bfd_ref_ptr.
(macho_symfile_read): Update.
* jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr.
(jit_bfd_try_read_symtab): Update.
* gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec)
(gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
gdb_bfd_ref_ptr.
(gdb_bfd_ref_policy): New struct.
(gdb_bfd_ref_ptr): New typedef.
* gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
(gdb_bfd_openw, gdb_bfd_openr_iovec)
(gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return
gdb_bfd_ref_ptr.
* gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr.
* gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr.
(gcore_command): Update.
* exec.c (exec_file_attach): Update.
* elfread.c (elf_symfile_read): Update.
* dwarf2read.c (dwarf2_get_dwz_file): Update.
(try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr.
(open_and_init_dwo_file): Update.
(open_dwp_file): Return gdb_bfd_ref_ptr.
(open_and_init_dwp_file): Update.
* corelow.c (core_open): Update.
* compile/compile-object-load.c (compile_object_load): Update.
* common/gdb_ref_ptr.h (ref_ptr::operator->): New operator.
* coffread.c (coff_symfile_read): Update.
* cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return
gdb_bfd_ref_ptr. Rename.
(dump_bfd_file, restore_command): Update.
* build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
* build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr.
(find_separate_debug_file_by_buildid): Update.
2016-11-21 19:12:23 +01:00
|
|
|
text_offset = pe_text_section_offset (dll.get ());
|
2012-12-13 11:44:45 +01:00
|
|
|
obstack_grow_str (obstack, paddress (gdbarch, load_addr + text_offset));
|
2009-01-11 14:10:44 +01:00
|
|
|
obstack_grow_str (obstack, "\"/></library>");
|
|
|
|
}
|
2010-04-16 09:49:37 +02:00
|
|
|
|
2012-06-05 15:50:57 +02:00
|
|
|
/* Implement the "iterate_over_objfiles_in_search_order" gdbarch
|
|
|
|
method. It searches all objfiles, starting with CURRENT_OBJFILE
|
|
|
|
first (if not NULL).
|
|
|
|
|
|
|
|
On Windows, the system behaves a little differently when two
|
|
|
|
objfiles each define a global symbol using the same name, compared
|
|
|
|
to other platforms such as GNU/Linux for instance. On GNU/Linux,
|
|
|
|
all instances of the symbol effectively get merged into a single
|
|
|
|
one, but on Windows, they remain distinct.
|
|
|
|
|
|
|
|
As a result, it usually makes sense to start global symbol searches
|
|
|
|
with the current objfile before expanding it to all other objfiles.
|
|
|
|
This helps for instance when a user debugs some code in a DLL that
|
|
|
|
refers to a global variable defined inside that DLL. When trying
|
|
|
|
to print the value of that global variable, it would be unhelpful
|
|
|
|
to print the value of another global variable defined with the same
|
|
|
|
name, but in a different DLL. */
|
|
|
|
|
2013-10-01 15:17:57 +02:00
|
|
|
static void
|
2012-06-05 15:50:57 +02:00
|
|
|
windows_iterate_over_objfiles_in_search_order
|
|
|
|
(struct gdbarch *gdbarch,
|
|
|
|
iterate_over_objfiles_in_search_order_cb_ftype *cb,
|
|
|
|
void *cb_data, struct objfile *current_objfile)
|
|
|
|
{
|
|
|
|
int stop;
|
|
|
|
struct objfile *objfile;
|
|
|
|
|
|
|
|
if (current_objfile)
|
|
|
|
{
|
|
|
|
stop = cb (current_objfile, cb_data);
|
|
|
|
if (stop)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ALL_OBJFILES (objfile)
|
|
|
|
{
|
|
|
|
if (objfile != current_objfile)
|
|
|
|
{
|
|
|
|
stop = cb (objfile, cb_data);
|
|
|
|
if (stop)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-04-16 09:49:37 +02:00
|
|
|
static void
|
|
|
|
show_maint_show_all_tib (struct ui_file *file, int from_tty,
|
|
|
|
struct cmd_list_element *c, const char *value)
|
|
|
|
{
|
2011-01-12 02:23:29 +01:00
|
|
|
fprintf_filtered (file, _("Show all non-zero elements of "
|
|
|
|
"Thread Information Block is %s.\n"), value);
|
2010-04-16 09:49:37 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
info_w32_command (char *args, int from_tty)
|
|
|
|
{
|
|
|
|
help_list (info_w32_cmdlist, "info w32 ", class_info, gdb_stdout);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int w32_prefix_command_valid = 0;
|
|
|
|
void
|
|
|
|
init_w32_command_list (void)
|
|
|
|
{
|
|
|
|
if (!w32_prefix_command_valid)
|
|
|
|
{
|
|
|
|
add_prefix_cmd ("w32", class_info, info_w32_command,
|
|
|
|
_("Print information specific to Win32 debugging."),
|
|
|
|
&info_w32_cmdlist, "info w32 ", 0, &infolist);
|
|
|
|
w32_prefix_command_valid = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-10-01 15:17:57 +02:00
|
|
|
/* To be called from the various GDB_OSABI_CYGWIN handlers for the
|
|
|
|
various Windows architectures and machine types. */
|
|
|
|
|
|
|
|
void
|
|
|
|
windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
|
|
{
|
Teach GDB that wchar_t is a built-in type in C++ mode
GDB is currently not aware that wchar_t is a built-in type in C++
mode. This is usually not a problem because the debug info describes
the type, so when you have a program loaded, you don't notice this.
However, if you try expressions involving wchar_t before a program is
loaded, gdb errors out:
(gdb) p (wchar_t)-1
No symbol table is loaded. Use the "file" command.
(gdb) p L"hello"
No type named wchar_t.
(gdb) ptype L"hello"
No type named wchar_t.
This commit teaches gdb about the type. After:
(gdb) p (wchar_t)-1
$1 = -1 L'\xffffffff'
(gdb) p L"hello"
$2 = L"hello"
(gdb) ptype L"hello"
type = wchar_t [6]
Unlike char16_t/char32_t, unfortunately, the underlying type of
wchar_t is implementation dependent, both size and signness. So this
requires adding a couple new gdbarch hooks.
I grepped the GCC code base for WCHAR_TYPE and WCHAR_TYPE_SIZE, and it
seems to me that the majority of the ABIs have a 4-byte signed
wchar_t, so that's what I made the default for GDB too. And then I
looked for which ports have a 16-bit and/or unsigned wchar_t, and made
GDB follow suit.
gdb/ChangeLog:
2017-04-12 Pedro Alves <palves@redhat.com>
PR gdb/21323
* c-lang.c (cplus_primitive_types) <cplus_primitive_type_wchar_t>:
New enum value.
(cplus_language_arch_info): Register cplus_primitive_type_wchar_t.
* gdbtypes.h (struct builtin_type) <builtin_wchar>: New field.
* gdbtypes.c (gdbtypes_post_init): Create the "wchar_t" type.
* gdbarch.sh (wchar_bit, wchar_signed): New per-arch values.
* gdbarch.h, gdbarch.c: Regenerate.
* aarch64-tdep.c (aarch64_gdbarch_init): Override
gdbarch_wchar_bit and gdbarch_wchar_signed.
* alpha-tdep.c (alpha_gdbarch_init): Likewise.
* arm-tdep.c (arm_gdbarch_init): Likewise.
* avr-tdep.c (avr_gdbarch_init): Likewise.
* h8300-tdep.c (h8300_gdbarch_init): Likewise.
* i386-nto-tdep.c (i386nto_init_abi): Likewise.
* i386-tdep.c (i386_go32_init_abi): Likewise.
* m32r-tdep.c (m32r_gdbarch_init): Likewise.
* moxie-tdep.c (moxie_gdbarch_init): Likewise.
* nds32-tdep.c (nds32_gdbarch_init): Likewise.
* rs6000-aix-tdep.c (rs6000_aix_init_osabi): Likewise.
* sh-tdep.c (sh_gdbarch_init): Likewise.
* sparc-tdep.c (sparc32_gdbarch_init): Likewise.
* sparc64-tdep.c (sparc64_init_abi): Likewise.
* windows-tdep.c (windows_init_abi): Likewise.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Likewise.
gdb/testsuite/ChangeLog:
2017-04-12 Pedro Alves <palves@redhat.com>
PR gdb/21323
* gdb.cp/wide_char_types.c: Include <wchar.h>.
(wchar): New global.
* gdb.cp/wide_char_types.exp (wide_char_types_program)
(do_test_wide_char, wide_char_types_no_program, top level): Add
wchar_t testing.
2017-04-12 15:00:49 +02:00
|
|
|
set_gdbarch_wchar_bit (gdbarch, 16);
|
|
|
|
set_gdbarch_wchar_signed (gdbarch, 0);
|
|
|
|
|
2013-10-01 15:17:57 +02:00
|
|
|
/* Canonical paths on this target look like
|
|
|
|
`c:\Program Files\Foo App\mydll.dll', for example. */
|
|
|
|
set_gdbarch_has_dos_based_file_system (gdbarch, 1);
|
|
|
|
|
|
|
|
set_gdbarch_iterate_over_objfiles_in_search_order
|
|
|
|
(gdbarch, windows_iterate_over_objfiles_in_search_order);
|
|
|
|
|
|
|
|
set_solib_ops (gdbarch, &solib_target_so_ops);
|
|
|
|
}
|
|
|
|
|
2012-04-27 22:38:39 +02:00
|
|
|
/* Implementation of `tlb' variable. */
|
|
|
|
|
|
|
|
static const struct internalvar_funcs tlb_funcs =
|
|
|
|
{
|
|
|
|
tlb_make_value,
|
|
|
|
NULL,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
2010-04-16 09:49:37 +02:00
|
|
|
void
|
|
|
|
_initialize_windows_tdep (void)
|
|
|
|
{
|
|
|
|
init_w32_command_list ();
|
|
|
|
add_cmd ("thread-information-block", class_info, display_tib,
|
|
|
|
_("Display thread information block."),
|
|
|
|
&info_w32_cmdlist);
|
|
|
|
add_alias_cmd ("tib", "thread-information-block", class_info, 1,
|
|
|
|
&info_w32_cmdlist);
|
|
|
|
|
|
|
|
add_setshow_boolean_cmd ("show-all-tib", class_maintenance,
|
|
|
|
&maint_display_all_tib, _("\
|
|
|
|
Set whether to display all non-zero fields of thread information block."), _("\
|
|
|
|
Show whether to display all non-zero fields of thread information block."), _("\
|
|
|
|
Use \"on\" to enable, \"off\" to disable.\n\
|
|
|
|
If enabled, all non-zero fields of thread information block are displayed,\n\
|
|
|
|
even if their meaning is unknown."),
|
|
|
|
NULL,
|
|
|
|
show_maint_show_all_tib,
|
|
|
|
&maintenance_set_cmdlist,
|
|
|
|
&maintenance_show_cmdlist);
|
|
|
|
|
|
|
|
/* Explicitly create without lookup, since that tries to create a
|
|
|
|
value with a void typed value, and when we get here, gdbarch
|
|
|
|
isn't initialized yet. At this point, we're quite sure there
|
|
|
|
isn't another convenience variable of the same name. */
|
2012-04-27 22:38:39 +02:00
|
|
|
create_internalvar_type_lazy ("_tlb", &tlb_funcs, NULL);
|
2010-04-16 09:49:37 +02:00
|
|
|
}
|