binutils-gdb/ld/testsuite/ld-elf/pr21703-3.s

	.text
	.global foo
	.type	foo, %function
foo:
	.space	4
	.size	foo, 4

	.global foo1
	.type	foo1, %function
foo1:
	.space	32
	.size	foo1, 32

	.symver	foo, foo@FOO
	.symver	foo1, foo@@FOO1
[BFD][PR21703]Override the new defined symbol with the old normal symbol when --allow-multiple-definition is provided. The behavior of _bfd_elf_merge_symbol and _bfd_generic_link_add_one_symbol is inconsistent. In multiple definition case, _bfd_elf_merge_symbol decided to override the old symbol definition with the new defintion, (size, type, target data) In _bfd_generic_link_add_one_symbol, it simply return without doing anything because of allow-multiple-definition is provided. This leaves the symbol in a wrong state. Here, following the documentation, I made this patch to force the old definition override the new definition if the old symbol is not dynamic or weak. Because, in those two cases, it's expected to do some merge. I have checked that, those two cases are properly handled. bfd/ PR ld/21703 * elflink.c (_bfd_elf_merge_symbol): Handle multiple definition case. ld/ PR ld/21703 * testsuite/ld-elf/elf.exp: Run new tests. * testsuite/ld-elf/pr21703-1.s: New. * testsuite/ld-elf/pr21703-2.s: New. * testsuite/ld-elf/pr21703-3.s: New. * testsuite/ld-elf/pr21703-4.s: New. * testsuite/ld-elf/pr21703-r.sd: New. * testsuite/ld-elf/pr21703-shared.sd: New. * testsuite/ld-elf/pr21703.sd: New. * testsuite/ld-elf/pr21703.ver: New. 2017-10-24 13:42:30 +02:00			`.text`
			`.global foo`
			`.type foo, %function`
			`foo:`
			`.space 4`
			`.size foo, 4`

			`.global foo1`
			`.type foo1, %function`
			`foo1:`
			`.space 32`
			`.size foo1, 32`

			`.symver foo, foo@FOO`
			`.symver foo1, foo@@FOO1`