Change section_offsets to a std::vector
This changes section_offsets to be specialization of a std::vector and
updates all the users. It also removes the ANOFFSET and
SIZEOF_N_SECTION_OFFSETS macros.
Most of this is just a generic sort of cleanup, that reduces the
number of lines of code. However, a couple spots were doing weird
things.
objfile_relocate did:
- std::vector<struct section_offsets>
- new_debug_offsets (SIZEOF_N_SECTION_OFFSETS (debug_objfile->num_sections));
... which seems to greatly over-estimate the number of elements
needed.
This appeared in set_objfile_default_section_offset:
- std::vector<struct section_offsets> offsets (objf->num_sections,
- { { offset } });
... which makes sense due to type safety, but is also actively
confusing given that section_offsets was previously also a kind of
vector type.
Tested on x86-64 Fedora 30.
gdb/ChangeLog
2020-01-08 Tom Tromey <tromey@adacore.com>
* xcoffread.c (enter_line_range, read_xcoff_symtab)
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
Remove.
(section_offsets): New typedef.
* symtab.c (fixup_section, get_msymbol_address): Update.
* symmisc.c (dump_msymbols): Update.
* symfile.h (relative_addr_info_to_section_offsets)
(symfile_map_offsets_to_segments): Update.
* symfile.c (build_section_addr_info_from_objfile)
(init_objfile_sect_indices): Update.
(struct place_section_arg): Change type of "offsets".
(place_section): Update.
(relative_addr_info_to_section_offsets): Change type of
"section_offsets". Remove "num_sections" parameter.
(default_symfile_offsets, syms_from_objfile_1)
(set_objfile_default_section_offset): Update.
(reread_symbols): No need to preserve section offsets by hand.
(symfile_map_offsets_to_segments): Change type of "offsets".
* stap-probe.c (relocate_address): Update.
* stabsread.h (process_one_symbol): Update.
* solib-target.c (struct lm_info_target) <offsets>: Change type.
(solib_target_relocate_section_addresses): Update.
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
Update.
* solib-frv.c (frv_relocate_main_executable): Update.
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
* solib-aix.c (solib_aix_get_section_offsets): Change return
type.
(solib_aix_solib_create_inferior_hook): Update.
* remote.c (remote_target::get_offsets): Update.
* psymtab.c (find_pc_sect_psymtab): Update.
* psympriv.h (struct partial_symbol) <address, text_low,
text_high>: Update.
* objfiles.h (obj_section_offset): Update.
(struct objfile) <section_offsets>: Change type.
<num_sections>: Remove.
(objfile_relocate): Update.
* objfiles.c (entry_point_address_query): Update
(relocate_one_symbol): Change type of "section_offsets".
(objfile_relocate1, objfile_relocate1): Change type of
"new_offsets".
(objfile_rebase1): Update.
* mipsread.c (mipscoff_symfile_read): Update.
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
parameter.
* mdebugread.c (parse_symbol): Change type of "section_offsets".
(parse_external, psymtab_to_symtab_1): Update.
* machoread.c (macho_symfile_offsets): Update.
* ia64-tdep.c (ia64_find_unwind_table): Update.
* hppa-tdep.c (read_unwind_info): Update.
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
* dwarf2read.c (create_addrmap_from_index)
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
(process_psymtab_comp_unit_reader, add_partial_symbol)
(add_partial_subprogram, process_full_comp_unit)
(read_file_scope, read_func_scope, read_lexical_block_scope)
(read_call_site_scope, dwarf2_rnglists_process)
(dwarf2_ranges_process, dwarf2_ranges_read)
(dwarf_decode_lines_1, var_decode_location, new_symbol)
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
Update.
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
Update.
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
(process_one_symbol): Change type of "section_offsets".
* ctfread.c (get_objfile_text_range): Update.
* coffread.c (coff_symtab_read, enter_linenos)
(process_coff_symbol): Update.
* coff-pe-read.c (add_pe_forwarded_sym): Update.
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
Change-Id: I147eb967e9b44d82f4048039de7bb44b80cd72fb
2020-01-06 22:34:52 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* xcoffread.c (enter_line_range, read_xcoff_symtab)
|
|
|
|
|
|
(process_xcoff_symbol, xcoff_symfile_offsets): Update.
|
|
|
|
|
|
* symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
|
|
|
|
|
|
(struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
|
|
|
|
|
|
Remove.
|
|
|
|
|
|
(section_offsets): New typedef.
|
|
|
|
|
|
* symtab.c (fixup_section, get_msymbol_address): Update.
|
|
|
|
|
|
* symmisc.c (dump_msymbols): Update.
|
|
|
|
|
|
* symfile.h (relative_addr_info_to_section_offsets)
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Update.
|
|
|
|
|
|
* symfile.c (build_section_addr_info_from_objfile)
|
|
|
|
|
|
(init_objfile_sect_indices): Update.
|
|
|
|
|
|
(struct place_section_arg): Change type of "offsets".
|
|
|
|
|
|
(place_section): Update.
|
|
|
|
|
|
(relative_addr_info_to_section_offsets): Change type of
|
|
|
|
|
|
"section_offsets". Remove "num_sections" parameter.
|
|
|
|
|
|
(default_symfile_offsets, syms_from_objfile_1)
|
|
|
|
|
|
(set_objfile_default_section_offset): Update.
|
|
|
|
|
|
(reread_symbols): No need to preserve section offsets by hand.
|
|
|
|
|
|
(symfile_map_offsets_to_segments): Change type of "offsets".
|
|
|
|
|
|
* stap-probe.c (relocate_address): Update.
|
|
|
|
|
|
* stabsread.h (process_one_symbol): Update.
|
|
|
|
|
|
* solib-target.c (struct lm_info_target) <offsets>: Change type.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
* solib-svr4.c (enable_break, svr4_relocate_main_executable):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* solib-frv.c (frv_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-dsbt.c (dsbt_relocate_main_executable): Update.
|
|
|
|
|
|
* solib-aix.c (solib_aix_get_section_offsets): Change return
|
|
|
|
|
|
type.
|
|
|
|
|
|
(solib_aix_solib_create_inferior_hook): Update.
|
|
|
|
|
|
* remote.c (remote_target::get_offsets): Update.
|
|
|
|
|
|
* psymtab.c (find_pc_sect_psymtab): Update.
|
|
|
|
|
|
* psympriv.h (struct partial_symbol) <address, text_low,
|
|
|
|
|
|
text_high>: Update.
|
|
|
|
|
|
* objfiles.h (obj_section_offset): Update.
|
|
|
|
|
|
(struct objfile) <section_offsets>: Change type.
|
|
|
|
|
|
<num_sections>: Remove.
|
|
|
|
|
|
(objfile_relocate): Update.
|
|
|
|
|
|
* objfiles.c (entry_point_address_query): Update
|
|
|
|
|
|
(relocate_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(objfile_relocate1, objfile_relocate1): Change type of
|
|
|
|
|
|
"new_offsets".
|
|
|
|
|
|
(objfile_rebase1): Update.
|
|
|
|
|
|
* mipsread.c (mipscoff_symfile_read): Update.
|
|
|
|
|
|
(read_alphacoff_dynamic_symtab): Remove "section_offsets"
|
|
|
|
|
|
parameter.
|
|
|
|
|
|
* mdebugread.c (parse_symbol): Change type of "section_offsets".
|
|
|
|
|
|
(parse_external, psymtab_to_symtab_1): Update.
|
|
|
|
|
|
* machoread.c (macho_symfile_offsets): Update.
|
|
|
|
|
|
* ia64-tdep.c (ia64_find_unwind_table): Update.
|
|
|
|
|
|
* hppa-tdep.c (read_unwind_info): Update.
|
|
|
|
|
|
* hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
|
|
|
|
|
|
* dwarf2read.c (create_addrmap_from_index)
|
|
|
|
|
|
(create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
|
|
|
|
|
|
(process_psymtab_comp_unit_reader, add_partial_symbol)
|
|
|
|
|
|
(add_partial_subprogram, process_full_comp_unit)
|
|
|
|
|
|
(read_file_scope, read_func_scope, read_lexical_block_scope)
|
|
|
|
|
|
(read_call_site_scope, dwarf2_rnglists_process)
|
|
|
|
|
|
(dwarf2_ranges_process, dwarf2_ranges_read)
|
|
|
|
|
|
(dwarf_decode_lines_1, var_decode_location, new_symbol)
|
|
|
|
|
|
(dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
|
|
|
|
|
|
Update.
|
|
|
|
|
|
* dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
|
|
|
|
|
|
* dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
|
|
|
|
|
|
(process_one_symbol): Change type of "section_offsets".
|
|
|
|
|
|
* ctfread.c (get_objfile_text_range): Update.
|
|
|
|
|
|
* coffread.c (coff_symtab_read, enter_linenos)
|
|
|
|
|
|
(process_coff_symbol): Update.
|
|
|
|
|
|
* coff-pe-read.c (add_pe_forwarded_sym): Update.
|
|
|
|
|
|
* amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
|
|
|
|
|
|
|
2019-10-31 17:46:18 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (parse_macro_definition): Use std::string.
|
|
|
|
|
|
(parse_macro_definition): Likewise.
|
|
|
|
|
|
|
2019-10-31 17:37:35 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (abbrev_table_read_table): Use std::vector.
|
|
|
|
|
|
(ATTR_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-10-31 17:34:40 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
|
|
|
|
|
|
|
2019-10-31 17:31:28 +01:00
|
|
|
|
2020-01-08 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(dwarf2_compute_name, open_dwo_file): Likewise.
|
|
|
|
|
|
(process_enumeration_scope): Use std::vector.
|
|
|
|
|
|
(guess_partial_die_structure_name): Use unique_xmalloc_ptr.
|
|
|
|
|
|
(partial_die_info::fixup, dwarf2_start_subfile)
|
|
|
|
|
|
(guess_full_die_structure_name, dwarf2_name): Likewise.
|
|
|
|
|
|
(determine_prefix): Update.
|
|
|
|
|
|
(guess_full_die_structure_name): Make return type const.
|
|
|
|
|
|
(partial_die_full_name): Return unique_xmalloc_ptr.
|
|
|
|
|
|
(DW_FIELD_ALLOC_CHUNK): Remove.
|
|
|
|
|
|
|
2019-12-19 19:35:22 +01:00
|
|
|
|
2020-01-07 Tom Tromey <tromey@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
PR build/24937:
|
|
|
|
|
|
* stap-probe.c (class stap_static_probe_ops): Add constructor.
|
|
|
|
|
|
|
2019-12-29 23:26:41 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
|
|
|
|
|
|
|
2019-12-26 21:56:01 +01:00
|
|
|
|
2020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* stack.c (print_frame_info): Move disassemble_next_line code
|
|
|
|
|
|
inside source_print block.
|
|
|
|
|
|
|
2020-01-06 20:54:21 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: Include <signal.h> instead of
|
|
|
|
|
|
gdb/signals.h, as we are now using native signal symbols.
|
|
|
|
|
|
|
2020-01-06 15:27:32 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
|
|
|
|
|
|
overflow by an early check of content vs threshold.
|
|
|
|
|
|
* tui/tui-source.c (tui_source_window::line_is_displayed):
|
|
|
|
|
|
Likewise.
|
|
|
|
|
|
|
2020-01-06 20:25:23 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
|
|
|
|
|
|
|
2020-01-02 01:25:56 +01:00
|
|
|
|
2020-01-02 Jon Turney <jon.turney@dronecode.org.uk>
|
|
|
|
|
|
|
|
|
|
|
|
* coff-pe-read.c (read_pe_exported_syms): Don't try to read the
|
|
|
|
|
|
export table if no section contains it's RVA.
|
|
|
|
|
|
|
2020-01-06 19:22:15 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
|
|
|
|
|
|
|
2019-12-22 14:58:22 +01:00
|
|
|
|
2020-01-06 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* source.c (print_source_lines_base): Set last_line_listed.
|
|
|
|
|
|
|
2020-01-06 13:54:18 +01:00
|
|
|
|
2020-01-06 Shahab Vahedi <shahab@synopsys.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-disasm.c: Remove trailing spaces.
|
|
|
|
|
|
|
2020-01-06 12:51:54 +01:00
|
|
|
|
2020-01-06 Eli Zaretskii <eliz@gnu.org>
|
|
|
|
|
|
Pedro Alves <palves@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
|
|
|
|
|
|
* windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
|
|
|
|
|
|
(windows_gdb_signal_to_target): New function, uses the above
|
|
|
|
|
|
enumeration to convert GDB internal signal codes to equivalent
|
|
|
|
|
|
Windows codes.
|
|
|
|
|
|
(windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
|
|
|
|
|
|
* windows-nat.c: Include "gdb_wait.h".
|
|
|
|
|
|
(get_windows_debug_event): Extract the fatal exception from the
|
|
|
|
|
|
exit status and convert to the equivalent Posix signal number.
|
|
|
|
|
|
* cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
|
|
|
|
|
|
possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
|
|
|
|
|
|
* gdbsupport/gdb_wait.c: New file, implements
|
|
|
|
|
|
windows_status_to_termsig.
|
|
|
|
|
|
* gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
|
|
|
|
|
|
(WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
|
|
|
|
|
|
|
2019-12-23 00:45:31 +01:00
|
|
|
|
2020-01-05 Andrew Burgess <andrew.burgess@embecosm.com>
|
|
|
|
|
|
|
|
|
|
|
|
* tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
|
|
|
|
|
|
show_layout.
|
|
|
|
|
|
|
2020-01-03 20:08:16 +01:00
|
|
|
|
2020-01-05 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* aarch64-linux-nat.c
|
|
|
|
|
|
(aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
|
|
|
|
|
|
and bfd_mach_aarch64.
|
|
|
|
|
|
|
2019-12-15 17:58:16 +01:00
|
|
|
|
2020-01-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
|
|
|
|
|
|
|
|
|
|
|
|
* ui-file.c (stdio_file::can_emit_style_escape)
|
|
|
|
|
|
(tee_file::can_emit_style_escape): Ensure style is used also on
|
|
|
|
|
|
gdb_stderr when gdb_stderr is a tty supporting styling, similarly
|
|
|
|
|
|
to gdb_stdout.
|
|
|
|
|
|
* main.c (set_gdb_data_directory): Use file style to output the
|
|
|
|
|
|
warning that the given pathname is not a directory.
|
|
|
|
|
|
* top.c (show_history_filename, gdb_safe_append_history)
|
|
|
|
|
|
(show_gdb_datadir): Use file style.
|
|
|
|
|
|
|
2019-12-27 13:41:58 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* solib-target.c (struct lm_info_target):
|
|
|
|
|
|
Change offsets to be a unique_xmalloc_ptr.
|
|
|
|
|
|
(solib_target_relocate_section_addresses): Update.
|
|
|
|
|
|
|
2019-12-24 13:14:01 +01:00
|
|
|
|
2020-01-03 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* windows-nat.c (windows_clear_solib): Free so_list linked list.
|
|
|
|
|
|
|
2020-01-03 09:16:38 +01:00
|
|
|
|
2020-01-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2019-12-30 19:47:10 +01:00
|
|
|
|
2020-01-02 Luis Machado <luis.machado@linaro.org>
|
|
|
|
|
|
|
|
|
|
|
|
* proc-service.c (get_ps_regcache): Remove reference to obsolete
|
|
|
|
|
|
Cell BE architecture.
|
|
|
|
|
|
* target.h (struct target_ops) <thread_architecture>: Likewise.
|
|
|
|
|
|
|
2019-12-30 17:01:02 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* Makefile.in: Use INSTALL_PROGRAM_ENV.
|
|
|
|
|
|
|
2020-01-01 13:00:28 +01:00
|
|
|
|
2020-01-01 Hannes Domani <ssbssa@yahoo.de>
|
|
|
|
|
|
|
|
|
|
|
|
* MAINTAINERS (Write After Approval): Add myself.
|
|
|
|
|
|
|
2020-01-01 07:37:10 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* gdbarch.sh: Update copyright year range of generated files.
|
|
|
|
|
|
|
2020-01-01 07:20:01 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
Update copyright year range in all GDB files.
|
|
|
|
|
|
|
2020-01-01 07:12:57 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Convert to Python 3.
|
|
|
|
|
|
|
2020-01-01 06:19:14 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py: Adapt after move of gnulib directory from gdb
|
|
|
|
|
|
directory to toplevel directory.
|
|
|
|
|
|
|
2020-01-01 06:08:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* copyright.py (main): Exit if run from the wrong directory.
|
|
|
|
|
|
|
2020-01-01 05:43:08 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
|
|
|
|
|
|
|
|
|
|
|
* top.c (print_gdb_version): Change copyright year to 2020.
|
|
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
2020-01-01 Joel Brobecker <brobecker@adacore.com>
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
* config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
|
2019-12-30 17:11:32 +01:00
|
|
|
|
|
2020-01-01 05:40:23 +01:00
|
|
|
|
For older changes see ChangeLog-2019.
|
1999-04-16 03:35:26 +02:00
|
|
|
|
|
|
|
|
|
|
Local Variables:
|
|
|
|
|
|
mode: change-log
|
|
|
|
|
|
left-margin: 8
|
|
|
|
|
|
fill-column: 74
|
|
|
|
|
|
version-control: never
|
2007-08-10 00:44:38 +02:00
|
|
|
|
coding: utf-8
|
1999-04-16 03:35:26 +02:00
|
|
|
|
End:
|
