OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Stop the assembler from running out of memory when asked to generate a huge number of spaces. 

PR gas/20901
	* read.c (s_space): Place an upper limit on the number of spaces
	generated.
This commit is contained in:
Nick Clifton 2016-12-06 15:31:14 +00:00
parent 7c2ba67e6a
commit 005304aae3
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gas/ChangeLog
View File

@ -1,5 +1,9 @@
2016-12-06 Nick Clifton <nickc@redhat.com>
PR gas/20901
* read.c (s_space): Place an upper limit on the number of spaces
generated.
PR gas/20896
* testsuite/gas/mmix/err-byte1.s: Adjust expected warning messages
to account for patch to next_char_of_string.

19
gas/read.c
View File

@ -3394,11 +3394,20 @@ s_space (int mult)
{
offsetT i;
if (mult == 0)
mult = 1;
bytes = mult * exp.X_add_number;
for (i = 0; i < exp.X_add_number; i++)
emit_expr (&val, mult);
/* PR 20901: Check for excessive values.
FIXME: 1<<10 is an arbitrary limit. Maybe use maxpagesize instead ? */
if (exp.X_add_number < 0 || exp.X_add_number > (1 << 10))
as_bad (_("size value for s_space directive too large: %lx"),
(long) exp.X_add_number);
else
{
if (mult == 0)
mult = 1;
bytes = mult * exp.X_add_number;
for (i = 0; i < exp.X_add_number; i++)
emit_expr (&val, mult);
}
}
}
else