OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix obvious gotcha in string comparison

Browse Source 
This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.

As is, it could lead to crashes.

gdb/ChangeLog:
2016-10-24  Luis Machado  <lgustavo@codesourcery.com>

	* exec.c (exception_print_same): Fix string comparison to use
	statically-allocated ones.
This commit is contained in:
Luis Machado 2016-10-24 17:44:56 -05:00
parent b8d38ee425
commit 010ece9c47
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2016-10-24 Luis Machado <lgustavo@codesourcery.com>
* exec.c (exception_print_same): Fix string comparison to use
statically-allocated ones.
2016-10-21 Tom Tromey <tom@tromey.com>
* dwarf2expr.h (class dwarf_expr_context)

2
gdb/exec.c
View File

@ -152,7 +152,7 @@ exception_print_same (struct gdb_exception e1, struct gdb_exception e2)
return (e1.reason == e2.reason
&& e1.error == e2.error
&& strcmp (e1.message, e2.message) == 0);
&& strcmp (msg1, msg2) == 0);
}
/* See gdbcore.h. */