Fix PR gdb/19187 (process record over a fork causes internal error)
Right after a fork is detected, we detach breakpoints from the child (detach_breakpoints), which calls into target_remove_breakpoint with inferior_ptid pointing at the child process, but leaves the breakpoint marked inserted (in the parent). The problem is that record-full.c always deletes all knowledge of the breakpoint. Then when we later really delete the breakpoint from the parent, we fail the assertion, since the breakpoint is unexpectedly not found in the record-full.c breakpoint table. The fix is simply to not forget about the breakpoint if we're detaching it from a fork child. gdb/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * record-full.c (record_full_remove_breakpoint): Don't remove the breakpoint from the record_full_breakpoints VEC if we're detaching the breakpoint from a fork child. gdb/testsuite/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * gdb.reverse/waitpid-reverse.exp: Add comment and remove setup_kfails.
This commit is contained in:
parent
7397181903
commit
01d3dedf60
|
@ -1,3 +1,10 @@
|
||||||
|
2016-08-10 Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
|
PR gdb/19187
|
||||||
|
* record-full.c (record_full_remove_breakpoint): Don't remove the
|
||||||
|
breakpoint from the record_full_breakpoints VEC if we're detaching
|
||||||
|
the breakpoint from a fork child.
|
||||||
|
|
||||||
2016-08-10 Pedro Alves <palves@redhat.com>
|
2016-08-10 Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
PR gdb/19187
|
PR gdb/19187
|
||||||
|
|
|
@ -1731,8 +1731,11 @@ record_full_remove_breakpoint (struct target_ops *ops,
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (reason == REMOVE_BREAKPOINT)
|
||||||
|
{
|
||||||
VEC_unordered_remove (record_full_breakpoint_p,
|
VEC_unordered_remove (record_full_breakpoint_p,
|
||||||
record_full_breakpoints, ix);
|
record_full_breakpoints, ix);
|
||||||
|
}
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -1,3 +1,9 @@
|
||||||
|
2016-08-10 Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
|
PR gdb/19187
|
||||||
|
* gdb.reverse/waitpid-reverse.exp: Add comment and remove
|
||||||
|
setup_kfails.
|
||||||
|
|
||||||
2016-08-09 Pedro Alves <palves@redhat.com>
|
2016-08-09 Pedro Alves <palves@redhat.com>
|
||||||
Simon Marchi <simon.marchi@ericsson.com>
|
Simon Marchi <simon.marchi@ericsson.com>
|
||||||
|
|
||||||
|
|
|
@ -18,6 +18,8 @@
|
||||||
#
|
#
|
||||||
# This test tests waitpid syscall for reverse execution.
|
# This test tests waitpid syscall for reverse execution.
|
||||||
#
|
#
|
||||||
|
# Also serves as regression test for gdb/19187 (recording across a
|
||||||
|
# fork).
|
||||||
|
|
||||||
if ![supports_reverse] {
|
if ![supports_reverse] {
|
||||||
return
|
return
|
||||||
|
@ -40,14 +42,12 @@ gdb_test "break marker2" \
|
||||||
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
||||||
"set breakpoint at marker2"
|
"set breakpoint at marker2"
|
||||||
|
|
||||||
setup_kfail "gdb/19187" *-*-*
|
|
||||||
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
|
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
|
||||||
|
|
||||||
gdb_test "break marker1" \
|
gdb_test "break marker1" \
|
||||||
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
|
||||||
"set breakpoint at marker1"
|
"set breakpoint at marker1"
|
||||||
|
|
||||||
setup_kfail "gdb/19187" *-*-*
|
|
||||||
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
|
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
|
||||||
|
|
||||||
# If the variable was recorded properly on syscall, the old contents (-1)
|
# If the variable was recorded properly on syscall, the old contents (-1)
|
||||||
|
|
Loading…
Reference in New Issue