Fix solib-display.exp remote check
This test currently uses [is_remote target] to check if the test is supported. This is not quite correct, as the limitation is actually that it requires support for "running", ruling out stub-like targets. Therefore, it should check for use_gdb_stub. This has no visible effect right now, but it will once we make the native-gdbserver board non-dejagnu-remote. gdb/testsuite/ChangeLog: * gdb.base/solib-display.exp: Check for [use_gdb_stub] instead of [is_remote target],
This commit is contained in:
parent
8929ad8bbc
commit
02e370d94e
|
@ -1,3 +1,8 @@
|
|||
2016-05-04 Simon Marchi <simon.marchi@ericsson.com>
|
||||
|
||||
* gdb.base/solib-display.exp: Check for [use_gdb_stub] instead
|
||||
of [is_remote target],
|
||||
|
||||
2016-05-04 Simon Marchi <simon.marchi@ericsson.com>
|
||||
|
||||
* lib/gdb.exp (use_gdb_stub): New procedure.
|
||||
|
|
|
@ -28,7 +28,24 @@
|
|||
# (and thus aren't affected by shared library unloading) are not
|
||||
# disabled prematurely.
|
||||
|
||||
if { [skip_shlib_tests] || [is_remote target] } {
|
||||
if { [skip_shlib_tests] } {
|
||||
return 0
|
||||
}
|
||||
|
||||
# This test is currently not supported for stub targets, because it uses the
|
||||
# start command (through gdb_start_cmd). In theory, it could be changed to
|
||||
# use something else (kill + gdb_run_cmd with a manual breakpoint at main).
|
||||
# However, when we try that with the native-gdbserver board, we see that the
|
||||
# test fails and gdb outputs this upon connection:
|
||||
#
|
||||
# warning: Unable to display "a_global": No symbol "a_global" in current context.
|
||||
# warning: Unable to display "b_global": No symbol "b_global" in current context.
|
||||
# warning: Unable to display "c_global": No symbol "c_global" in current context.
|
||||
#
|
||||
# This is because the initial stop is done before the shared libraries are
|
||||
# loaded.
|
||||
|
||||
if { [use_gdb_stub] } {
|
||||
return 0
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue