linux low: Make the arch code free arch_process_info

For the same reason as the previous patch, we need to make the
arch-specific code free the arch_process_info structure it allocates.

gdb/gdbserver/ChangeLog:

	* linux-low.h (struct linux_target_ops) <delete_process>: New
	field.
	* linux-low.c (linux_mourn): Call the_low_target.delete_process.
	* linux-aarch64-low.c (aarch64_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-arm-low.c (arm_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-bfin-low.c (struct linux_target_ops): Likewise.
	* linux-crisv32-low.c (struct linux_target_ops): Likewise.
	* linux-m32r-low.c (struct linux_target_ops): Likewise.
	* linux-mips-low.c (mips_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-ppc-low.c (struct linux_target_ops): Likewise.
	* linux-s390-low.c (struct linux_target_ops): Likewise.
	* linux-sh-low.c (struct linux_target_ops): Likewise.
	* linux-tic6x-low.c (struct linux_target_ops): Likewise.
	* linux-tile-low.c (struct linux_target_ops): Likewise.
	* linux-x86-low.c (x86_linux_delete_process): New.
	(struct linux_target_ops): Add delete_process callback.
	* linux-xtensa-low.c (struct linux_target_ops): Likewise.
This commit is contained in:
Simon Marchi 2017-10-12 16:49:27 -04:00
parent 466eeceef4
commit 04ec7890fc
16 changed files with 78 additions and 2 deletions

View File

@ -1,3 +1,26 @@
2017-10-12 Simon Marchi <simon.marchi@ericsson.com>
* linux-low.h (struct linux_target_ops) <delete_process>: New
field.
* linux-low.c (linux_mourn): Call the_low_target.delete_process.
* linux-aarch64-low.c (aarch64_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-arm-low.c (arm_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-bfin-low.c (struct linux_target_ops): Likewise.
* linux-crisv32-low.c (struct linux_target_ops): Likewise.
* linux-m32r-low.c (struct linux_target_ops): Likewise.
* linux-mips-low.c (mips_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-ppc-low.c (struct linux_target_ops): Likewise.
* linux-s390-low.c (struct linux_target_ops): Likewise.
* linux-sh-low.c (struct linux_target_ops): Likewise.
* linux-tic6x-low.c (struct linux_target_ops): Likewise.
* linux-tile-low.c (struct linux_target_ops): Likewise.
* linux-x86-low.c (x86_linux_delete_process): New.
(struct linux_target_ops): Add delete_process callback.
* linux-xtensa-low.c (struct linux_target_ops): Likewise.
2017-10-12 Simon Marchi <simon.marchi@ericsson.com>
* linux-aarch64-low.c (the_low_target): Add thread delete

View File

@ -429,7 +429,7 @@ aarch64_linux_siginfo_fixup (siginfo_t *native, gdb_byte *inf, int direction)
return 0;
}
/* Implementation of linux_target_ops method "linux_new_process". */
/* Implementation of linux_target_ops method "new_process". */
static struct arch_process_info *
aarch64_linux_new_process (void)
@ -441,6 +441,14 @@ aarch64_linux_new_process (void)
return info;
}
/* Implementation of linux_target_ops method "delete_process". */
static void
aarch64_linux_delete_process (struct arch_process_info *info)
{
xfree (info);
}
/* Implementation of linux_target_ops method "linux_new_fork". */
static void
@ -2990,6 +2998,7 @@ struct linux_target_ops the_low_target =
NULL, /* supply_ptrace_register */
aarch64_linux_siginfo_fixup,
aarch64_linux_new_process,
aarch64_linux_delete_process,
aarch64_linux_new_thread,
aarch64_linux_delete_thread,
aarch64_linux_new_fork,

View File

@ -640,6 +640,14 @@ arm_new_process (void)
return info;
}
/* Called when a process is being deleted. */
static void
arm_delete_process (struct arch_process_info *info)
{
xfree (info);
}
/* Called when a new thread is detected. */
static void
arm_new_thread (struct lwp_info *lwp)
@ -1060,6 +1068,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
arm_new_process,
arm_delete_process,
arm_new_thread,
arm_delete_thread,
arm_new_fork,

View File

@ -135,6 +135,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -415,6 +415,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -1687,7 +1687,10 @@ linux_mourn (struct process_info *process)
/* Freeing all private data. */
priv = process->priv;
free (priv->arch_private);
if (the_low_target.delete_process != NULL)
the_low_target.delete_process (priv->arch_private);
else
gdb_assert (priv->arch_private == NULL);
free (priv);
process->priv = NULL;

View File

@ -189,6 +189,10 @@ struct linux_target_ops
allocate it here. */
struct arch_process_info * (*new_process) (void);
/* Hook to call when a process is being deleted. If extra per-process
architecture-specific data is needed, delete it here. */
void (*delete_process) (struct arch_process_info *info);
/* Hook to call when a new thread is detected.
If extra per-thread architecture-specific data is needed,
allocate it here. */

View File

@ -134,6 +134,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -327,6 +327,15 @@ mips_linux_new_process (void)
return info;
}
/* This is the implementation of linux_target_ops method
delete_process. */
static void
mips_linux_delete_process (struct arch_process_info *info)
{
xfree (info);
}
/* This is the implementation of linux_target_ops method new_thread.
Mark the watch registers as changed, so the threads' copies will
be updated. */
@ -900,6 +909,7 @@ struct linux_target_ops the_low_target = {
NULL,
NULL, /* siginfo_fixup */
mips_linux_new_process,
mips_linux_delete_process,
mips_linux_new_thread,
mips_linux_delete_thread,
mips_linux_new_fork,

View File

@ -3124,6 +3124,7 @@ struct linux_target_ops the_low_target = {
ppc_supply_ptrace_register,
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -2829,6 +2829,7 @@ struct linux_target_ops the_low_target = {
s390_supply_ptrace_register,
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -164,6 +164,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -397,6 +397,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -196,6 +196,7 @@ struct linux_target_ops the_low_target =
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */

View File

@ -617,6 +617,14 @@ x86_linux_new_process (void)
return info;
}
/* Called when a process is being deleted. */
static void
x86_linux_delete_process (struct arch_process_info *info)
{
xfree (info);
}
/* Target routine for linux_new_fork. */
static void
@ -2866,6 +2874,7 @@ struct linux_target_ops the_low_target =
/* need to fix up i386 siginfo if host is amd64 */
x86_siginfo_fixup,
x86_linux_new_process,
x86_linux_delete_process,
x86_linux_new_thread,
x86_linux_delete_thread,
x86_linux_new_fork,

View File

@ -288,6 +288,7 @@ struct linux_target_ops the_low_target = {
NULL, /* supply_ptrace_register */
NULL, /* siginfo_fixup */
NULL, /* new_process */
NULL, /* delete_process */
NULL, /* new_thread */
NULL, /* delete_thread */
NULL, /* new_fork */