OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove cli_ui_out::out_field_fmt 

I noticed that cli_ui_out::out_field_fmt is only used by a single
caller, and it can easily be replaced by fputs_filtered.  So, this
patch removes it.

ChangeLog
2018-04-24  Tom Tromey  <tom@tromey.com>

	* cli-out.c (cli_ui_out::out_field_fmt): Remove.
	(cli_ui_out::do_field_string): Use fputs_filtered.
	* cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
This commit is contained in:
Tom Tromey 2018-04-22 17:54:20 -06:00
parent 0f703942d7
commit 05b1d8d6fc
3 changed files with 7 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2018-04-24 Tom Tromey <tom@tromey.com>
* cli-out.c (cli_ui_out::out_field_fmt): Remove.
(cli_ui_out::do_field_string): Use fputs_filtered.
* cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
2018-04-23 Tom Tromey <tom@tromey.com>
* guile/scm-frame.c (gdbscm_frame_read_var): Use

18
gdb/cli-out.c
View File

@ -156,7 +156,7 @@ cli_ui_out::do_field_string (int fldno, int width, ui_align align,
spaces (before);
if (string)
out_field_fmt (fldno, fldname, "%s", string);
fputs_filtered (string, m_streams.back ());
if (after)
spaces (after);
@ -238,22 +238,6 @@ cli_ui_out::do_redirect (ui_file *outstream)
/* local functions */
/* Like cli_ui_out::do_field_fmt, but takes a variable number of args
and makes a va_list and does not insert a separator. */
/* VARARGS */
void
cli_ui_out::out_field_fmt (int fldno, const char *fldname,
const char *format, ...)
{
va_list args;
va_start (args, format);
vfprintf_filtered (m_streams.back (), format, args);
va_end (args);
}
void
cli_ui_out::field_separator ()
{

2
gdb/cli-out.h
View File

@ -68,8 +68,6 @@ protected:
private:
void field_separator ();
void out_field_fmt (int fldno, const char *fldname, const char *format, ...)
ATTRIBUTE_PRINTF (4, 5);
std::vector<ui_file *> m_streams;
bool m_suppress_output;