OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

linux_spu_make_corefile_notes: return note_data instead of nullptr 

Since commit

  9018be2 ("Make target_read_alloc & al return vectors")

the test gdb.threads/gcore-stale-thread.exp test results in UNSUPPORTED:

  UNSUPPORTED: gdb.threads/gcore-stale-thread.exp: save a corefile

The problem is that the linux_spu_make_corefile_notes started returning
nullptr when reading TARGET_OBJECT_SPU fails.  The previous (and proper)
behaviour is to return the note_data received as a parameter, so that
other functions may continue to append to this buffer.

With this patch, the test goes back to PASS.

gdb/ChangeLog:

	* linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
	instead of nullptr.
This commit is contained in:
Simon Marchi 2018-04-16 16:47:06 -04:00
parent e3a91079b5
commit 07d28c7777
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2018-04-16 Simon Marchi <simon.marchi@ericsson.com>
* linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
instead of nullptr.
2018-04-16 Pedro Alves <palves@redhat.com>
* MAINTAINERS (sh): Remove.

2
gdb/linux-tdep.c
View File

@ -1426,7 +1426,7 @@ linux_spu_make_corefile_notes (bfd *obfd, char *note_data, int *note_size)
spu_ids = target_read_alloc (&current_target, TARGET_OBJECT_SPU, NULL);
if (!spu_ids)
return nullptr;
return note_data;
/* Generate corefile notes for each SPU file. */
for (size_t i = 0; i < spu_ids->size (); i += 4)