OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

2007-08-09 Michael Snyder <msnyder@access-company.com> 

* solib.c (solib_open): Memory leak -- openp returns xmalloc buffer.
This commit is contained in:
Michael Snyder 2007-08-09 18:37:08 +00:00
parent 4fec86cf74
commit 0997b53539
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2007-08-09 Michael Snyder <msnyder@access-company.com>
* solib.c (solib_open): Memory leak -- openp returns xmalloc buffer.
2007-08-09 Joel Brobecker <brobecker@adacore.com>
* solib-som.c (som_relocate_section_addresses): Stop saving

20
gdb/solib.c
View File

@ -176,6 +176,17 @@ solib_open (char *in_pathname, char **found_pathname)
/* Now see if we can open it. */
found_file = open (temp_pathname, O_RDONLY | O_BINARY, 0);
/* We try to find the library in various ways. After each attempt
(except for the one above), either found_file >= 0 and
temp_pathname is a malloc'd string, or found_file < 0 and
temp_pathname does not point to storage that needs to be
freed. */
if (found_file < 0)
temp_pathname = NULL;
else
temp_pathname = xstrdup (temp_pathname);
/* If the search in gdb_sysroot failed, and the path name is
absolute at this point, make it relative. (openp will try and open the
file according to its absolute path otherwise, which is not what we want.)
@ -224,8 +235,13 @@ solib_open (char *in_pathname, char **found_pathname)
/* Done. If not found, tough luck. Return found_file and
(optionally) found_pathname. */
if (found_pathname != NULL && temp_pathname != NULL)
*found_pathname = xstrdup (temp_pathname);
if (temp_pathname)
{
if (found_pathname != NULL)
*found_pathname = temp_pathname;
else
xfree (temp_pathname);
}
return found_file;
}