OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add checks for overfar branches

Browse Source 
Check 8 and 16 bit PCREL fixes for overflow, since we bypass the
later overflow checks in write.c.  Direct relocs are left alone,
as gcc has been known to take advantage of the silent overflows
when comparing addresses to constant ranges.
This commit is contained in:
DJ Delorie 2014-04-02 16:50:29 -04:00
parent cad0da33dc
commit 0a899fd5ac
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2014-04-02 DJ Delorie <dj@redhat.com>
* config/tc-rl78.c (md_apply_fix): Add overflow warnings for
pc-relative branches.
2014-04-02 Nick Clifton <nickc@redhat.com>
PR gas/16765

14
gas/config/tc-rl78.c
View File

@ -1310,13 +1310,23 @@ md_apply_fix (struct fix * f ATTRIBUTE_UNUSED,
f->fx_done = 1;
break;
case BFD_RELOC_8:
case BFD_RELOC_8_PCREL:
if ((long)val < -128 || (long)val > 127)
as_bad_where (f->fx_file, f->fx_line,
_("value of %ld too large for 8-bit branch"),
val);
/* Fall through. */
case BFD_RELOC_8:
op[0] = val;
break;
case BFD_RELOC_16:
case BFD_RELOC_16_PCREL:
if ((long)val < -32768 || (long)val > 32767)
as_bad_where (f->fx_file, f->fx_line,
_("value of %ld too large for 16-bit branch"),
val);
/* Fall through. */
case BFD_RELOC_16:
case BFD_RELOC_RL78_CODE:
op[0] = val;
op[1] = val >> 8;