From 0a8ddac418d3e8e12a1bb51c3b0da90155f83403 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 24 Apr 2018 10:14:14 -0400 Subject: [PATCH] info-shared.exp: Replace libs=-ldl with shlib_load As reported in PR 23104, -ldl doesn't work on FreeBSD. Replace it with shlib_load, which adds the right flags for dynamic library loading based on the current target platform. The test still passes on Linux, and should now pass on FreeBSD, though I did not test personally. gdb/testsuite/ChangeLog: PR gdb/23104 * gdb.base/info-shared.exp: Replace libs=-ldl with shlib_load. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/info-shared.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index d5e9429041..cb8dd8012f 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-04-24 Simon Marchi + + PR gdb/23104 + * gdb.base/info-shared.exp: Replace libs=-ldl with shlib_load. + 2018-04-19 Richard Bunt * gdb.threads/multiple-successive-infcall.c: New test. diff --git a/gdb/testsuite/gdb.base/info-shared.exp b/gdb/testsuite/gdb.base/info-shared.exp index 4ffcb1be7e..f228f18eb5 100644 --- a/gdb/testsuite/gdb.base/info-shared.exp +++ b/gdb/testsuite/gdb.base/info-shared.exp @@ -43,7 +43,7 @@ if { [gdb_compile_shlib $srcfile_lib2 $binfile_lib2 \ set cflags "$define1 $define2" if { [prepare_for_testing "failed to prepare" $testfile $srcfile \ - [list additional_flags=$cflags libs=-ldl]] } { + [list additional_flags=$cflags shlib_load]] } { return -1 }