OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

* gdbthread.h: Add comments. 

* stack.c (get_selected_block): Return 0 on an exited thread.
	* top.c (execute_command): Check for is_stopped, not !is_running.
	* event-top.c (command_handler): Likewise.
This commit is contained in:
Pedro Alves 2008-08-16 23:51:14 +00:00
parent 8931f5261f
commit 0d6431e255
5 changed files with 38 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2008-08-17 Pedro Alves <pedro@codesourcery.com>
* gdbthread.h: Add comments.
* stack.c (get_selected_block): Return 0 on an exited thread.
* top.c (execute_command): Check for is_stopped, not !is_running.
* event-top.c (command_handler): Likewise.
2008-08-16 Pedro Alves <pedro@codesourcery.com>
* mi/mi-main.c (mi_cmd_exec_next, mi_cmd_exec_next_instruction)

2
gdb/event-top.c
View File

@ -518,7 +518,7 @@ command_handler (char *command)
/* Do any commands attached to breakpoint we stopped at. Only if we
are always running synchronously. Or if we have just executed a
command that doesn't start the target. */
if (!target_can_async_p () || !is_running (inferior_ptid))
if (!target_can_async_p () || is_stopped (inferior_ptid))
{
bpstat_do_actions (&stop_bpstat);
do_cleanups (old_chain);

33
gdb/gdbthread.h
View File

@ -210,21 +210,40 @@ extern void switch_to_thread (ptid_t ptid);
If PIDGET (PTID) is -1, marks all threads. */
extern void set_running (ptid_t ptid, int running);
/* Reports if thread PTID is known to be running right now. */
extern int is_running (ptid_t ptid);
/* NOTE: Since the thread state is not a boolean, most times, you do
not want to check it with negation. If you really want to check if
the thread is stopped,
/* Reports if any thread is known to be running right now. */
extern int any_running (void);
use (good):
if (is_stopped (ptid))
instead of (bad):
if (!is_running (ptid))
The latter also returns true on exited threads, most likelly not
what you want. */
/* Reports if in the frontend's perpective, thread PTID is running. */
extern int is_running (ptid_t ptid);
/* Is this thread listed, but known to have exited? We keep it listed
(but not visible) until it's safe to delete. */
extern int is_exited (ptid_t ptid);
/* Is this thread stopped? */
/* In the frontend's perpective, is this thread stopped? */
extern int is_stopped (ptid_t ptid);
/* Marks thread PTID as executing, or as stopped.
If PIDGET (PTID) is -1, marks all threads. */
/* In the frontend's perpective is there any thread running? */
extern int any_running (void);
/* Marks thread PTID as executing, or not. If PIDGET (PTID) is -1,
marks all threads.
Note that this is different from the running state. See the
description of state_ and executing_ fields of struct
thread_info. */
extern void set_executing (ptid_t ptid, int executing);
/* Reports if thread PTID is executing. */

3
gdb/stack.c
View File

@ -1644,6 +1644,9 @@ get_selected_block (CORE_ADDR *addr_in_block)
if (!target_has_stack)
return 0;
if (is_exited (inferior_ptid))
return 0;
if (is_executing (inferior_ptid))
return 0;

2
gdb/top.c
View File

@ -477,7 +477,7 @@ Cannot execute this command without a live selected thread. See `help thread'."
/* FIXME: This should be cacheing the frame and only running when
the frame changes. */
if (target_has_stack && !is_running (inferior_ptid))
if (target_has_stack && is_stopped (inferior_ptid))
{
flang = get_frame_language ();
if (!warned