OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix Windows gdb build failure with Python 2 support

Browse Source 
GDB fails to build for Windows host with Python 2 support enabled due
to PyFile_FromString's second argument being of type char * and being
passed a (const) string literal. This parameter is input only so this
commit fixes the issue by casting to char *.

2017-04-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/
	* python/python.c (python_run_simple_file): Cast mode literal to
	non-const char pointer as expected by PyFile_FromString.
This commit is contained in:
Thomas Preud'homme 2017-04-06 17:17:23 +01:00
parent 3944e22b46
commit 0dedf3777d
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2017-04-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
* python/python.c (python_run_simple_file): Cast mode literal to
non-const char pointer as expected by PyFile_FromString.
2017-04-05 Simon Marchi <simon.marchi@ericsson.com> 2017-04-05 Simon Marchi <simon.marchi@ericsson.com>
* common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with

2
gdb/python/python.c
View File

@ -352,7 +352,7 @@ python_run_simple_file (FILE *file, const char *filename)
/* Because we have a string for a filename, and are using Python to /* Because we have a string for a filename, and are using Python to
open the file, we need to expand any tilde in the path first. */ open the file, we need to expand any tilde in the path first. */
gdb::unique_xmalloc_ptr<char> full_path (tilde_expand (filename)); gdb::unique_xmalloc_ptr<char> full_path (tilde_expand (filename));
gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), "r")); gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), (char *) "r"));
if (python_file == NULL) if (python_file == NULL)
{ {
gdbpy_print_stack (); gdbpy_print_stack ();