Move comment in gdb/dwarf2read.c::dwarf2_physname
This commit just moves a comment right next to where it is actually relevant. No actual code change. gdb/ChangeLog: * dwarf2read.c (dwarf2_physname): Move commment. Tested by rebuilding GDB.
This commit is contained in:
parent
27d2460e7a
commit
0eb876f52f
|
@ -1,3 +1,7 @@
|
||||||
|
2018-02-05 Joel Brobecker <brobecker@adacore.com>
|
||||||
|
|
||||||
|
* dwarf2read.c (dwarf2_physname): Move commment.
|
||||||
|
|
||||||
2018-02-01 Leszek Swirski <leszeks@google.com>
|
2018-02-01 Leszek Swirski <leszeks@google.com>
|
||||||
|
|
||||||
* varobj.c (varobj_formatted_print_options): Allow recursive
|
* varobj.c (varobj_formatted_print_options): Allow recursive
|
||||||
|
|
|
@ -11141,14 +11141,6 @@ dwarf2_physname (const char *name, struct die_info *die, struct dwarf2_cu *cu)
|
||||||
gdb::unique_xmalloc_ptr<char> demangled;
|
gdb::unique_xmalloc_ptr<char> demangled;
|
||||||
if (mangled != NULL)
|
if (mangled != NULL)
|
||||||
{
|
{
|
||||||
/* Use DMGL_RET_DROP for C++ template functions to suppress their return
|
|
||||||
type. It is easier for GDB users to search for such functions as
|
|
||||||
`name(params)' than `long name(params)'. In such case the minimal
|
|
||||||
symbol names do not match the full symbol names but for template
|
|
||||||
functions there is never a need to look up their definition from their
|
|
||||||
declaration so the only disadvantage remains the minimal symbol
|
|
||||||
variant `long name(params)' does not have the proper inferior type.
|
|
||||||
*/
|
|
||||||
|
|
||||||
if (cu->language == language_go)
|
if (cu->language == language_go)
|
||||||
{
|
{
|
||||||
|
@ -11158,6 +11150,14 @@ dwarf2_physname (const char *name, struct die_info *die, struct dwarf2_cu *cu)
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
|
/* Use DMGL_RET_DROP for C++ template functions to suppress
|
||||||
|
their return type. It is easier for GDB users to search
|
||||||
|
for such functions as `name(params)' than `long name(params)'.
|
||||||
|
In such case the minimal symbol names do not match the full
|
||||||
|
symbol names but for template functions there is never a need
|
||||||
|
to look up their definition from their declaration so
|
||||||
|
the only disadvantage remains the minimal symbol variant
|
||||||
|
`long name(params)' does not have the proper inferior type. */
|
||||||
demangled.reset (gdb_demangle (mangled,
|
demangled.reset (gdb_demangle (mangled,
|
||||||
(DMGL_PARAMS | DMGL_ANSI
|
(DMGL_PARAMS | DMGL_ANSI
|
||||||
| DMGL_RET_DROP)));
|
| DMGL_RET_DROP)));
|
||||||
|
|
Loading…
Reference in New Issue