Use gdb::byte_vector in load_progress
This changes load_progress to use gdb::byte_vector, removing a cleanup. 2017-10-03 Tom Tromey <tom@tromey.com> * symfile.c (load_progress): Use gdb::byte_vector.
This commit is contained in:
parent
245ad7d373
commit
0efef64054
|
@ -1,3 +1,7 @@
|
||||||
|
2017-10-03 Tom Tromey <tom@tromey.com>
|
||||||
|
|
||||||
|
* symfile.c (load_progress): Use gdb::byte_vector.
|
||||||
|
|
||||||
2017-10-03 Tom Tromey <tom@tromey.com>
|
2017-10-03 Tom Tromey <tom@tromey.com>
|
||||||
|
|
||||||
* mi/mi-main.c (mi_cmd_trace_frame_collected): Remove unused
|
* mi/mi-main.c (mi_cmd_trace_frame_collected): Remove unused
|
||||||
|
|
|
@ -56,6 +56,7 @@
|
||||||
#include "stack.h"
|
#include "stack.h"
|
||||||
#include "gdb_bfd.h"
|
#include "gdb_bfd.h"
|
||||||
#include "cli/cli-utils.h"
|
#include "cli/cli-utils.h"
|
||||||
|
#include "common/byte-vector.h"
|
||||||
|
|
||||||
#include <sys/types.h>
|
#include <sys/types.h>
|
||||||
#include <fcntl.h>
|
#include <fcntl.h>
|
||||||
|
@ -1942,16 +1943,14 @@ load_progress (ULONGEST bytes, void *untyped_arg)
|
||||||
might add a verify_memory() method to the target vector and
|
might add a verify_memory() method to the target vector and
|
||||||
then use that. remote.c could implement that method using
|
then use that. remote.c could implement that method using
|
||||||
the ``qCRC'' packet. */
|
the ``qCRC'' packet. */
|
||||||
gdb_byte *check = (gdb_byte *) xmalloc (bytes);
|
gdb::byte_vector check (bytes);
|
||||||
struct cleanup *verify_cleanups = make_cleanup (xfree, check);
|
|
||||||
|
|
||||||
if (target_read_memory (args->lma, check, bytes) != 0)
|
if (target_read_memory (args->lma, check.data (), bytes) != 0)
|
||||||
error (_("Download verify read failed at %s"),
|
error (_("Download verify read failed at %s"),
|
||||||
paddress (target_gdbarch (), args->lma));
|
paddress (target_gdbarch (), args->lma));
|
||||||
if (memcmp (args->buffer, check, bytes) != 0)
|
if (memcmp (args->buffer, check.data (), bytes) != 0)
|
||||||
error (_("Download verify compare failed at %s"),
|
error (_("Download verify compare failed at %s"),
|
||||||
paddress (target_gdbarch (), args->lma));
|
paddress (target_gdbarch (), args->lma));
|
||||||
do_cleanups (verify_cleanups);
|
|
||||||
}
|
}
|
||||||
totals->data_count += bytes;
|
totals->data_count += bytes;
|
||||||
args->lma += bytes;
|
args->lma += bytes;
|
||||||
|
|
Loading…
Reference in New Issue