OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ELF/LD: Always consider STB_LOCAL symbols local

Browse Source 
Do not require forced local (STB_LOCAL) symbols to have a definition in
a regular file to be considered to resolve local to the current module,
matching `elf_link_renumber_local_hash_table_dynsyms'.  In the absence
of a regular definition any reference to a STB_LOCAL symbol will have to
be garbage collected along with the undefined symbol itself, or the link
will eventually fail.  Either way the symbol concerned is not going to
be external.

	bfd/
	* elflink.c (_bfd_elf_symbol_refs_local_p): Always return TRUE
	if forced local.
This commit is contained in:
Maciej W. Rozycki 2017-04-13 10:26:05 +01:00
parent 31321c8031
commit 0fad29560e
2 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2017-04-20 Maciej W. Rozycki <macro@imgtec.com>
* elflink.c (_bfd_elf_symbol_refs_local_p): Always return TRUE
if forced local.
2017-04-20 Maciej W. Rozycki <macro@imgtec.com>
* elfxx-mips.c (_bfd_mips_elf_final_link): Reorder comment about

18
bfd/elflink.c
View File

@ -3063,10 +3063,10 @@ _bfd_elf_dynamic_symbol_p (struct elf_link_hash_entry *h,
to resolve local to the current module, and false otherwise. Differs
from (the inverse of) _bfd_elf_dynamic_symbol_p in the treatment of
undefined symbols. The two functions are virtually identical except
for the place where forced_local and dynindx == -1 are tested. If
either of those tests are true, _bfd_elf_dynamic_symbol_p will say
the symbol is local, while _bfd_elf_symbol_refs_local_p will say
the symbol is local only for defined symbols.
for the place where dynindx == -1 is tested. If that test is true,
_bfd_elf_dynamic_symbol_p will say the symbol is local, while
_bfd_elf_symbol_refs_local_p will say the symbol is local only for
defined symbols.
It might seem that _bfd_elf_dynamic_symbol_p could be rewritten as
!_bfd_elf_symbol_refs_local_p, except that targets differ in their
treatment of undefined weak symbols. For those that do not make
@ -3089,6 +3089,10 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
|| ELF_ST_VISIBILITY (h->other) == STV_INTERNAL)
return TRUE;
/* Forced local symbols resolve locally. */
if (h->forced_local)
return TRUE;
/* Common symbols that become definitions don't get the DEF_REGULAR
flag set, so test it first, and don't bail out. */
if (ELF_COMMON_DEF_P (h))
@ -3098,11 +3102,7 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
else if (!h->def_regular)
return FALSE;
/* Forced local symbols resolve locally. */
if (h->forced_local)
return TRUE;
/* As do non-dynamic symbols. */
/* Non-dynamic symbols resolve locally. */
if (h->dynindx == -1)
return TRUE;