From 10766686b02fce9eedd6217ca76f457106a8142c Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Mon, 1 Jun 2015 12:13:02 +0100 Subject: [PATCH] Fetch and store GP registers by PTRACE_{G,S}ETREGSET If kernel supports PTRACE_GETREGSET, GDB uses PTRACE_{G,S}ETREGSET to fetch and store GP registers. gdb: 2015-06-01 Yao Qi * arm-linux-nat.c (fetch_register): Use PTRACE_GETREGSET. (fetch_regs): Likewise. (store_regs): Use PTRACE_SETREGSET. (store_register): Likewise. --- gdb/ChangeLog | 7 ++++ gdb/arm-linux-nat.c | 85 +++++++++++++++++++++++++++++++++++++++------ 2 files changed, 82 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 27b84382bb..84c3685834 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2015-06-01 Yao Qi + + * arm-linux-nat.c (fetch_register): Use PTRACE_GETREGSET. + (fetch_regs): Likewise. + (store_regs): Use PTRACE_SETREGSET. + (store_register): Likewise. + 2015-06-01 Yao Qi * arm-linux-nat.c (arm_linux_read_description): Check whether diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c index 877559ed3e..98d3557946 100644 --- a/gdb/arm-linux-nat.c +++ b/gdb/arm-linux-nat.c @@ -224,8 +224,19 @@ fetch_register (struct regcache *regcache, int regno) /* Get the thread id for the ptrace call. */ tid = GET_THREAD_ID (inferior_ptid); - - ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (ret < 0) { warning (_("Unable to fetch general register.")); @@ -266,8 +277,19 @@ fetch_regs (struct regcache *regcache) /* Get the thread id for the ptrace call. */ tid = GET_THREAD_ID (inferior_ptid); - - ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (ret < 0) { warning (_("Unable to fetch general registers.")); @@ -304,9 +326,20 @@ store_register (const struct regcache *regcache, int regno) /* Get the thread id for the ptrace call. */ tid = GET_THREAD_ID (inferior_ptid); - + /* Get the general registers from the process. */ - ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (ret < 0) { warning (_("Unable to fetch general registers.")); @@ -322,7 +355,18 @@ store_register (const struct regcache *regcache, int regno) regcache_raw_collect (regcache, ARM_PC_REGNUM, (char *) ®s[ARM_PC_REGNUM]); - ret = ptrace (PTRACE_SETREGS, tid, 0, ®s); + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_SETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_SETREGS, tid, 0, ®s); + if (ret < 0) { warning (_("Unable to store general register.")); @@ -338,9 +382,20 @@ store_regs (const struct regcache *regcache) /* Get the thread id for the ptrace call. */ tid = GET_THREAD_ID (inferior_ptid); - + /* Fetch the general registers. */ - ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_GETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_GETREGS, tid, 0, ®s); + if (ret < 0) { warning (_("Unable to fetch general registers.")); @@ -357,7 +412,17 @@ store_regs (const struct regcache *regcache) regcache_raw_collect (regcache, ARM_PS_REGNUM, (char *) ®s[ARM_CPSR_GREGNUM]); - ret = ptrace (PTRACE_SETREGS, tid, 0, ®s); + if (have_ptrace_getregset) + { + struct iovec iov; + + iov.iov_base = ®s; + iov.iov_len = sizeof (regs); + + ret = ptrace (PTRACE_SETREGSET, tid, NT_PRSTATUS, &iov); + } + else + ret = ptrace (PTRACE_SETREGS, tid, 0, ®s); if (ret < 0) {