OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

aarch64: actually copy first operand in convert_bfc_to_bfm() 

Commit 93562a343c ("[AArch64] PR target/20666, fix wrong encoding of
new introduced BFC pseudo") changed the destination operand to 0,
making the whole function invocation a no-op. We really want to copy
operand 0 (a register) to operand 1 (an immediate before coming here),
even if right now this likely is only a latent bug.
This commit is contained in:
Jan Beulich 2017-02-22 10:36:05 +01:00 committed by Jan Beulich
parent e025ae6880
commit 11648de5a9
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2017-02-21 Jan Beulich <jbeulich@suse.com>
* aarch64-asm.c (convert_bfc_to_bfm): Copy operand 0 to operand
1 (instead of to itself). Correct typo.
2017-02-14 Andrew Waterman <andrew@sifive.com>
* riscv-opc.c (riscv_opcodes): Add sfence.vma instruction and

4
opcodes/aarch64-asm.c
View File

@ -1607,10 +1607,10 @@ convert_bfc_to_bfm (aarch64_inst *inst)
/* Insert XZR. */
copy_operand_info (inst, 3, 2);
copy_operand_info (inst, 2, 1);
copy_operand_info (inst, 0, 0);
copy_operand_info (inst, 1, 0);
inst->operands[1].reg.regno = 0x1f;
/* Convert the immedate operand. */
/* Convert the immediate operand. */
lsb = inst->operands[2].imm.value;
width = inst->operands[3].imm.value;
if (inst->operands[2].qualifier == AARCH64_OPND_QLF_imm_0_31)