OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

2012-03-19 Pedro Alves <palves@redhat.com> 

Jan Kratochvil  <jan.kratochvil@redhat.com>

	* server.c (cont_thread, general_thread): Add describing comments.
	(start_inferior): Clear `cont_thread'.
	(handle_v_cont): Don't set `cont_thread' if resuming all threads
	of a process.
This commit is contained in:
Pedro Alves 2012-03-19 14:33:35 +00:00
parent 3a69ffb280
commit 122f36efc1
2 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,11 @@
2012-03-19 Pedro Alves <palves@redhat.com>
Jan Kratochvil <jan.kratochvil@redhat.com>
* server.c (cont_thread, general_thread): Add describing comments.
(start_inferior): Clear `cont_thread'.
(handle_v_cont): Don't set `cont_thread' if resuming all threads
of a process.
2012-03-15 Yao Qi <yao@codesourcery.com>
* tracepoint.c (install_tracepoint): Move duplicated tracepoint

24
gdb/gdbserver/server.c
View File

@ -30,7 +30,19 @@
#include <sys/wait.h>
#endif
/* The thread set with an `Hc' packet. `Hc' is deprecated in favor of
`vCont'. Note the multi-process extensions made `vCont' a
requirement, so `Hc pPID.TID' is pretty much undefined. So
CONT_THREAD can be null_ptid for no `Hc' thread, minus_one_ptid for
resuming all threads of the process (again, `Hc' isn't used for
multi-process), or a specific thread ptid_t.
We also set this when handling a single-thread `vCont' resume, as
some places in the backends check it to know when (and for which
thread) single-thread scheduler-locking is in effect. */
ptid_t cont_thread;
/* The thread set with an `Hg' packet. */
ptid_t general_thread;
int server_waiting;
@ -262,6 +274,10 @@ start_inferior (char **argv)
signal (SIGTTIN, SIG_DFL);
#endif
/* Clear this so the backend doesn't get confused, thinking
CONT_THREAD died, and it needs to resume all threads. */
cont_thread = null_ptid;
signal_pid = create_inferior (new_argv[0], new_argv);
/* FIXME: we don't actually know at this point that the create
@ -1962,9 +1978,13 @@ handle_v_cont (char *own_buf)
if (i < n)
resume_info[i] = default_action;
/* Still used in occasional places in the backend. */
/* `cont_thread' is still used in occasional places in the backend,
to implement single-thread scheduler-locking. Doesn't make sense
to set it if we see a stop request, or any form of wildcard
vCont. */
if (n == 1
&& !ptid_equal (resume_info[0].thread, minus_one_ptid)
&& !(ptid_equal (resume_info[0].thread, minus_one_ptid)
|| ptid_get_lwp (resume_info[0].thread) == -1)
&& resume_info[0].kind != resume_stop)
cont_thread = resume_info[0].thread;
else