From 128205bb36e521955248a7ab895bd3e79e4f58d5 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Mon, 6 May 2013 09:32:55 +0000 Subject: [PATCH] * elf64-ppc.c (opd_entry_value): Handle case where symbol hashes are not available. --- bfd/ChangeLog | 5 +++++ bfd/elf64-ppc.c | 29 ++++++++++++++++++++++++----- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 0434e70e7d..8e2308ef87 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2013-05-06 Alan Modra + + * elf64-ppc.c (opd_entry_value): Handle case where symbol + hashes are not available. + 2013-05-06 Alan Modra * elflink.c (elf_link_add_object_symbols): Don't save symbol diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index cb33821a76..d4415e4576 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -5665,11 +5665,30 @@ opd_entry_value (asection *opd_sec, sym_hashes = elf_sym_hashes (opd_bfd); rh = sym_hashes[symndx - symtab_hdr->sh_info]; - rh = elf_follow_link (rh); - BFD_ASSERT (rh->root.type == bfd_link_hash_defined - || rh->root.type == bfd_link_hash_defweak); - val = rh->root.u.def.value; - sec = rh->root.u.def.section; + if (rh != NULL) + { + rh = elf_follow_link (rh); + BFD_ASSERT (rh->root.type == bfd_link_hash_defined + || rh->root.type == bfd_link_hash_defweak); + val = rh->root.u.def.value; + sec = rh->root.u.def.section; + } + else + { + /* Handle the odd case where we can be called + during bfd_elf_link_add_symbols before the + symbol hashes have been fully populated. */ + Elf_Internal_Sym *sym; + + sym = bfd_elf_get_elf_syms (opd_bfd, symtab_hdr, 1, + symndx, NULL, NULL, NULL); + if (sym == NULL) + break; + + val = sym->st_value; + sec = bfd_section_from_elf_index (opd_bfd, sym->st_shndx); + free (sym); + } } val += look->r_addend; if (code_off != NULL)