MIPS/LD/testsuite: mips-elf-flags: Use `remote_exec' to call `readelf'

For ELF file header flag verification done in `good_combination' in the
`mips-elf-flags.exp' test script the version of `readelf' built along
with the rest of binutils has to be used rather than any such executable
already present on the build system, so that flags recognized by the
tool match those supported by LD being tested.  Use `remote_exec' as
elsewhere in the LD test framework and also with GAS and LD used here,
getting and arranging for extra reporting of `readelf' calls included in
test logs on this occasion as well.

	ld/
	* testsuite/ld-mips-elf/mips-elf-flags.exp (good_combination):
	Use `remote_exec' to call `readelf'.  Log the command issued.
This commit is contained in:
Maciej W. Rozycki 2017-06-27 02:58:27 +01:00
parent b1a2d7a0e5
commit 1284e99a6c
2 changed files with 12 additions and 2 deletions

View File

@ -1,3 +1,8 @@
2017-06-27 Maciej W. Rozycki <macro@imgtec.com>
* testsuite/ld-mips-elf/mips-elf-flags.exp (good_combination):
Use `remote_exec' to call `readelf'. Log the command issued.
2017-06-27 Maciej W. Rozycki <macro@imgtec.com>
* testsuite/ld-mips-elf/mips-elf-flags.exp (good_combination):

View File

@ -70,8 +70,13 @@ proc good_combination {arglist flags} {
} elseif {![ld_link "$ld $ldemul" $finalobj "-r $objs"]} {
fail $testname
} else {
catch "exec $READELF -h $finalobj" output
if {![regexp "Flags: *(\[^\n\]*)" $output full gotflags]} {
set cmd "$READELF -h $finalobj"
send_log "$cmd\n"
set cmdret [remote_exec host [concat sh -c [list "$cmd 2>&1"]]]
set output [lindex $cmdret 1]
set cmdret [lindex $cmdret 0]
if {$cmdret != 0 \
|| ![regexp "Flags: *(\[^\n\r\]*)" $output full gotflags]} {
unresolved $testname
} else {
set failed 0