OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rename tdesc_register_size to tdesc_register_bitsize

Browse Source 
tdesc_register_size returns number of bits, not bytes.
Rename to make it clearer.

Also, fixed bug in aarch64_get_tdesc_vq which assumed bytes.

gdb/
	* target-descriptions.c (tdesc_register_bitsize): Rename.
	* target-descriptions.h (tdesc_register_bitsize): Likewise.
	* rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
	* aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
This commit is contained in:
Alan Hayward 2018-07-11 08:34:50 +01:00
parent a79eaed6a5
commit 12863263d6
5 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2018-07-11 Alan Hayward <alan.hayward@arm.com>
* target-descriptions.c (tdesc_register_bitsize): Rename.
* target-descriptions.h (tdesc_register_bitsize): Likewise.
* rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
* aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
2018-07-10 Tom Tromey <tom@tromey.com>
* breakpoint.c (moribund_locations): Now static and a

4
gdb/aarch64-tdep.c
View File

@ -2922,8 +2922,8 @@ aarch64_get_tdesc_vq (const struct target_desc *tdesc)
if (feature_sve == nullptr)
return 0;
uint64_t vl = tdesc_register_size (feature_sve,
aarch64_sve_register_names[0]);
uint64_t vl = tdesc_register_bitsize (feature_sve,
aarch64_sve_register_names[0]) / 8;
return sve_vq_from_vl (vl);
}

4
gdb/rs6000-tdep.c
View File

@ -5953,7 +5953,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
have_mq = tdesc_numbered_register (feature, tdesc_data, PPC_MQ_REGNUM,
"mq");
tdesc_wordsize = tdesc_register_size (feature, "pc") / 8;
tdesc_wordsize = tdesc_register_bitsize (feature, "pc") / 8;
if (wordsize == -1)
wordsize = tdesc_wordsize;
@ -5984,7 +5984,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* The fpscr register was expanded in isa 2.05 to 64 bits
along with the addition of the decimal floating point
facility. */
if (tdesc_register_size (feature, "fpscr") > 32)
if (tdesc_register_bitsize (feature, "fpscr") > 32)
have_dfp = 1;
}
else

3
gdb/target-descriptions.c
View File

@ -816,8 +816,7 @@ tdesc_numbered_register_choices (const struct tdesc_feature *feature,
bits. The register must exist. */
int
tdesc_register_size (const struct tdesc_feature *feature,
const char *name)
tdesc_register_bitsize (const struct tdesc_feature *feature, const char *name)
{
struct tdesc_reg *reg = tdesc_find_register_early (feature, name);

4
gdb/target-descriptions.h
View File

@ -125,8 +125,8 @@ int tdesc_unnumbered_register (const struct tdesc_feature *feature,
/* Search FEATURE for a register named NAME, and return its size in
bits. The register must exist. */
int tdesc_register_size (const struct tdesc_feature *feature,
const char *name);
int tdesc_register_bitsize (const struct tdesc_feature *feature,
const char *name);
/* Search FEATURE for a register with any of the names from NAMES
(NULL-terminated). Record REGNO and the register in DATA; when