From 12e37cbc4b33576711d4e4742c691652fdf5bea7 Mon Sep 17 00:00:00 2001 From: Matthew Gretton-Dann Date: Fri, 24 Aug 2012 07:58:02 +0000 Subject: [PATCH] * gas/config/tc-arm.c (do_setend): Warn on deprecated SETEND. (do_t_setend): Likewise. * gas/testsuite/gas/arm/armv8-a-bad.l: Update * gas/testsuite/gas/arm/armv8-a-bad.s: Likewise. --- gas/ChangeLog | 5 +++++ gas/config/tc-arm.c | 8 ++++++++ gas/testsuite/ChangeLog | 5 +++++ gas/testsuite/gas/arm/armv8-a-bad.l | 2 ++ gas/testsuite/gas/arm/armv8-a-bad.s | 6 ++++++ 5 files changed, 26 insertions(+) diff --git a/gas/ChangeLog b/gas/ChangeLog index f3319725aa..5d6b4449f8 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2012-08-24 Matthew Gretton-Dann + + * config/tc-arm.c (do_setend): Warn on deprecated SETEND. + (do_t_setend): Likewise. + 2012-08-24 Matthew Gretton-Dann * config/tc-arm.c (do_t_it): Fully initialise now_it. diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index d9cf3d3702..8f2f88bd96 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -8528,6 +8528,10 @@ do_usat16 (void) static void do_setend (void) { + if (warn_on_deprecated + && ARM_CPU_HAS_FEATURE (cpu_variant, arm_ext_v8)) + as_warn (_("setend use is deprecated for ARMv8")); + if (inst.operands[0].imm) inst.instruction |= 0x200; } @@ -11769,6 +11773,10 @@ do_t_rsb (void) static void do_t_setend (void) { + if (warn_on_deprecated + && ARM_CPU_HAS_FEATURE (cpu_variant, arm_ext_v8)) + as_warn (_("setend use is deprecated for ARMv8")); + set_it_insn_type (OUTSIDE_IT_INSN); if (inst.operands[0].imm) inst.instruction |= 0x8; diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 40ab12dad8..2cdaada1d5 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-08-24 Matthew Gretton-Dann + + * gas/arm/armv8-a-bad.l: Update + * gas/arm/armv8-a-bad.s: Likewise. + 2012-08-24 Matthew Gretton-Dann * gas/arm/armv8-a-it-bad.d: New testcase. diff --git a/gas/testsuite/gas/arm/armv8-a-bad.l b/gas/testsuite/gas/arm/armv8-a-bad.l index cde1bba9a3..e96efceeec 100644 --- a/gas/testsuite/gas/arm/armv8-a-bad.l +++ b/gas/testsuite/gas/arm/armv8-a-bad.l @@ -5,3 +5,5 @@ .*:12: Warning: This coprocessor register access is deprecated in ARMv8 .*:13: Warning: This coprocessor register access is deprecated in ARMv8 .*:14: Warning: This coprocessor register access is deprecated in ARMv8 +.*:17: Warning: setend use is deprecated for ARMv8 +.*:20: Warning: setend use is deprecated for ARMv8 diff --git a/gas/testsuite/gas/arm/armv8-a-bad.s b/gas/testsuite/gas/arm/armv8-a-bad.s index af08639fae..33a3c17ee2 100644 --- a/gas/testsuite/gas/arm/armv8-a-bad.s +++ b/gas/testsuite/gas/arm/armv8-a-bad.s @@ -12,3 +12,9 @@ mcr p15, 0, r2, c7, c10, 5 mrc p14, 6, r1, c0, c0, 0 mrc p14, 6, r0, c1, c0, 0 + + // deprecated SETEND + setend be + + .thumb + setend le