2003-06-27 Elena Zannoni <ezannoni@redhat.com>

* symfile.c (syms_from_objfile): Move variables to inner block.
        Move the checks for the non-mainline case a bit earlier to avoid
        doing some useless computations.
This commit is contained in:
Elena Zannoni 2003-06-27 13:11:17 +00:00
parent 3cb3398dc3
commit 1549f61969
2 changed files with 13 additions and 8 deletions

View File

@ -1,3 +1,9 @@
2003-06-27 Elena Zannoni <ezannoni@redhat.com>
* symfile.c (syms_from_objfile): Move variables to inner block.
Move the checks for the non-mainline case a bit earlier to avoid
doing some useless computations.
2003-06-27 Elena Zannoni <ezannoni@redhat.com> 2003-06-27 Elena Zannoni <ezannoni@redhat.com>
* dwarfread.c (decode_modified_type): Gag new compiler warning. * dwarfread.c (decode_modified_type): Gag new compiler warning.

View File

@ -566,12 +566,8 @@ syms_from_objfile (struct objfile *objfile,
int mainline, int mainline,
int verbo) int verbo)
{ {
asection *lower_sect;
asection *sect;
CORE_ADDR lower_offset;
struct section_addr_info *local_addr = NULL; struct section_addr_info *local_addr = NULL;
struct cleanup *old_chain; struct cleanup *old_chain;
int i;
gdb_assert (! (addrs && offsets)); gdb_assert (! (addrs && offsets));
@ -626,8 +622,13 @@ syms_from_objfile (struct objfile *objfile,
We no longer warn if the lowest section is not a text segment (as We no longer warn if the lowest section is not a text segment (as
happens for the PA64 port. */ happens for the PA64 port. */
if (!mainline) if (!mainline && addrs && addrs->other[0].name)
{ {
asection *lower_sect;
asection *sect;
CORE_ADDR lower_offset;
int i;
/* Find lowest loadable section to be used as starting point for /* Find lowest loadable section to be used as starting point for
continguous sections. FIXME!! won't work without call to find continguous sections. FIXME!! won't work without call to find
.text first, but this assumes text is lowest section. */ .text first, but this assumes text is lowest section. */
@ -659,9 +660,7 @@ syms_from_objfile (struct objfile *objfile,
(the loadable section directly below it in memory). (the loadable section directly below it in memory).
this_offset = lower_offset = lower_addr - lower_orig_addr */ this_offset = lower_offset = lower_addr - lower_orig_addr */
/* Calculate offsets for sections. */ for (i = 0; i < addrs->num_sections && addrs->other[i].name; i++)
if (addrs)
for (i=0 ; i < addrs->num_sections && addrs->other[i].name; i++)
{ {
if (addrs->other[i].addr != 0) if (addrs->other[i].addr != 0)
{ {