OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ussan: d30v: index out of bounds

Browse Source 
* d30v-dis.c (print_insn): Make opind unsigned.  Don't access
	past end of operands array.
This commit is contained in:
Alan Modra 2019-12-10 23:50:02 +10:30
parent d93bba9e0d
commit 159653d8c0
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-11 Alan Modra <amodra@gmail.com>
* d30v-dis.c (print_insn): Make opind unsigned. Don't access
past end of operands array.
2019-12-11 Alan Modra <amodra@gmail.com>
* csky-dis.c (csky_chars_to_number): Rewrite. Avoid signed

8
opcodes/d30v-dis.c
View File

@ -125,7 +125,8 @@ print_insn (struct disassemble_info *info,
{
int val, opnum, need_comma = 0;
struct d30v_operand *oper;
int i, match, opind = 0, need_paren = 0, found_control = 0;
int i, match, need_paren = 0, found_control = 0;
unsigned int opind = 0;
(*info->fprintf_func) (info->stream, "%s", insn->op->name);
@ -154,7 +155,8 @@ print_insn (struct disassemble_info *info,
(*info->fprintf_func) (info->stream, "\t");
while ((opnum = insn->form->operands[opind++]) != 0)
while (opind < ARRAY_SIZE (insn->form->operands)
&& (opnum = insn->form->operands[opind++]) != 0)
{
int bits;
@ -314,7 +316,7 @@ print_insn (struct disassemble_info *info,
(*info->fprintf_func) (info->stream, "0x%x", val);
}
/* If there is another operand, then write a comma and space. */
if (opind < (int) ARRAY_SIZE (insn->form->operands)
if (opind < ARRAY_SIZE (insn->form->operands)
&& insn->form->operands[opind]
&& !(found_control && opind == 2))
need_comma = 1;