OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdb: Fix ATTRIBUTE_NONNULL usage

Browse Source 
Should fix the build failure with Clang mentioned at
	<https://sourceware.org/bugzilla/show_bug.cgi?id=21206#c2>:

 In file included from ../../binutils-gdb/gdb/dwarf2read.c:72:
 ../../binutils-gdb/gdb/common/gdb_unlinker.h:35:35: error: '__nonnull__' attribute is invalid for the implicit this argument
   unlinker (const char *filename) ATTRIBUTE_NONNULL (1)
				   ^                  ~
 ../../binutils-gdb/gdb/../include/ansidecl.h:169:48: note: expanded from macro 'ATTRIBUTE_NONNULL'
 #  define ATTRIBUTE_NONNULL(m) __attribute__ ((__nonnull__ (m)))

gdb/ChangeLog:
2017-03-08  Pedro Alves  <palves@redhat.com>

	PR 21206
	* common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
	goes to argument 2, not 1.
This commit is contained in:
Pedro Alves 2017-03-08 15:52:16 +00:00
parent 1fc87489b4
commit 15c22686d0
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2017-03-08 Pedro Alves <palves@redhat.com>
PR 21206
* common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
goes to argument 2, not 1.
2017-03-08 Pedro Alves <palves@redhat.com>
PR cli/21218

2
gdb/common/gdb_unlinker.h
View File

@ -32,7 +32,7 @@ class unlinker
{
public:
unlinker (const char *filename) ATTRIBUTE_NONNULL (1)
unlinker (const char *filename) ATTRIBUTE_NONNULL (2)
: m_filename (filename)
{
gdb_assert (filename != NULL);