OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Hoist assertion in target_stack::unpush

Browse Source 
I noticed that target_stack::unpush first uses the target "t", then
later asserts that it is non-NULL:

  strata stratum = t->stratum ();
[...]
  gdb_assert (t != NULL);

This is backwards, though, as the assertion must come first.

gdb/ChangeLog
2019-02-05  Tom Tromey  <tom@tromey.com>

	* target.c (target_stack::unpush): Move assertion earlier.
This commit is contained in:
Tom Tromey 2019-02-05 04:59:11 -07:00
parent 4dcfcfe063
commit 1688cb2916
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2019-02-05 Tom Tromey <tom@tromey.com>
* target.c (target_stack::unpush): Move assertion earlier.
2019-01-30 Tom Tromey <tom@tromey.com>
PR python/23615:

4
gdb/target.c
View File

@ -598,14 +598,14 @@ unpush_target (struct target_ops *t)
bool
target_stack::unpush (target_ops *t)
{
gdb_assert (t != NULL);
strata stratum = t->stratum ();
if (stratum == dummy_stratum)
internal_error (__FILE__, __LINE__,
_("Attempt to unpush the dummy target"));
gdb_assert (t != NULL);
/* Look for the specified target. Note that a target can only occur
once in the target stack. */