OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

alpha-vms: memory leak 

* vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
This commit is contained in:
Alan Modra 2020-02-28 13:02:42 +10:30
parent 1b088c829e
commit 182ec6707c
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/ChangeLog
View File

@ -1,3 +1,7 @@
2020-02-28 Alan Modra <amodra@gmail.com>
* vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
2020-02-28 Alan Modra <amodra@gmail.com>
* vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.

16
bfd/vms-lib.c
View File

@ -623,12 +623,16 @@ _bfd_vms_lib_archive_p (bfd *abfd, enum vms_lib_kind kind)
if (sbm_off > reclen
|| reclen - sbm_off < sizeof (struct vms_dcxsbm))
goto err;
{
err_free_buf:
free (buf);
goto err;
}
sbm = (struct vms_dcxsbm *) (buf + sbm_off);
sbm_sz = bfd_getl16 (sbm->size);
sbm_off += sbm_sz;
if (sbm_off > reclen)
goto err;
goto err_free_buf;
sbmdesc->min_char = sbm->min_char;
BFD_ASSERT (sbmdesc->min_char == 0);
@ -638,25 +642,25 @@ _bfd_vms_lib_archive_p (bfd *abfd, enum vms_lib_kind kind)
if (sbm_sz < sizeof (struct vms_dcxsbm) + l + sbm_len
|| (tdata->nbr_dcxsbm > 1
&& sbm_sz < sizeof (struct vms_dcxsbm) + l + 3 * sbm_len))
goto err;
goto err_free_buf;
sbmdesc->flags = (unsigned char *)bfd_alloc (abfd, l);
off = bfd_getl16 (sbm->flags);
if (off > sbm_sz
|| sbm_sz - off < l)
goto err;
goto err_free_buf;
memcpy (sbmdesc->flags, (bfd_byte *) sbm + off, l);
sbmdesc->nodes = (unsigned char *)bfd_alloc (abfd, 2 * sbm_len);
off = bfd_getl16 (sbm->nodes);
if (off > sbm_sz
|| sbm_sz - off < 2 * sbm_len)
goto err;
goto err_free_buf;
memcpy (sbmdesc->nodes, (bfd_byte *) sbm + off, 2 * sbm_len);
off = bfd_getl16 (sbm->next);
if (off != 0)
{
if (off > sbm_sz
|| sbm_sz - off < 2 * sbm_len)
goto err;
goto err_free_buf;
/* Read the 'next' array. */
sbmdesc->next = (unsigned short *) bfd_alloc (abfd, 2 * sbm_len);
buf1 = (bfd_byte *) sbm + off;