OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gdbserver: xtensa: add call0 support 

Correctly handle a0- registers on requests from remote gdb. This fixes

  'Register 1 is not available'

and subsequent assertion in the remote gdb connecting to the gdbserver:

  'findvar.c:291: internal-error: value_of_register_lazy:
    Assertion `frame_id_p(get_frame_id (frame))' failed.'

The register structure is the same for windowed and call0 ABIs because
currently linux kernel internally requires windowed registers, so they
are always present.

gdb/gdbserver/
2017-03-27  Max Filippov  <jcmvbkbc@gmail.com>

	* linux-xtensa-low.c (xtensa_fill_gregset): Call collect_register
	for all registers in a0_regnum..a0_regnum + C0_NREGS range.
	(xtensa_store_gregset): Call supply_register for all registers in
	a0_regnum..a0_regnum + C0_NREGS range.
This commit is contained in:
Max Filippov 2016-11-18 08:58:21 -08:00
parent 0ce4291e3f
commit 1a09b50a46
2 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,10 @@
2017-03-27 Max Filippov <jcmvbkbc@gmail.com>
* linux-xtensa-low.c (xtensa_fill_gregset): Call collect_register
for all registers in a0_regnum..a0_regnum + C0_NREGS range.
(xtensa_store_gregset): Call supply_register for all registers in
a0_regnum..a0_regnum + C0_NREGS range.
2017-03-13 Simon Marchi <simon.marchi@polymtl.ca>
* Makefile.in (%-ipa.o: %-ipa.c): New rule.

28
gdb/gdbserver/linux-xtensa-low.c
View File

@ -59,6 +59,20 @@ xtensa_fill_gregset (struct regcache *regcache, void *buf)
ptr += register_size (tdesc, i);
}
if (XSHAL_ABI == XTHAL_ABI_CALL0)
{
int a0_regnum = find_regno (tdesc, "a0");
ptr = (char *) &rset[R_A0 + 4 * rset[R_WB]];
for (i = a0_regnum; i < a0_regnum + C0_NREGS; i++)
{
if ((4 * rset[R_WB] + i - a0_regnum) == XCHAL_NUM_AREGS)
ptr = (char *) &rset[R_A0];
collect_register (regcache, i, ptr);
ptr += register_size (tdesc, i);
}
}
/* Loop registers, if hardware has it. */
#if XCHAL_HAVE_LOOPS
@ -94,6 +108,20 @@ xtensa_store_gregset (struct regcache *regcache, const void *buf)
ptr += register_size (tdesc, i);
}
if (XSHAL_ABI == XTHAL_ABI_CALL0)
{
int a0_regnum = find_regno (tdesc, "a0");
ptr = (char *) &rset[R_A0 + (4 * rset[R_WB]) % XCHAL_NUM_AREGS];
for (i = a0_regnum; i < a0_regnum + C0_NREGS; i++)
{
if ((4 * rset[R_WB] + i - a0_regnum) == XCHAL_NUM_AREGS)
ptr = (char *) &rset[R_A0];
supply_register (regcache, i, ptr);
ptr += register_size (tdesc, i);
}
}
/* Loop registers, if hardware has it. */
#if XCHAL_HAVE_LOOPS