Comment and whitespace changes

This commit merges the comments and whitespace in the common
parts of i386-linux-nat.c and amd64-linux-nat.c.

gdb/
2014-07-11  Gary Benson  <gbenson@redhat.com>

	* amd64-linux-nat.c: Comment and whitespace changes.
	* i386-linux-nat.c: Comment and whitespace changes.
This commit is contained in:
Gary Benson 2014-06-25 14:57:42 +01:00
parent c1e246a060
commit 1aa7e42c3f
3 changed files with 20 additions and 3 deletions

View File

@ -1,3 +1,8 @@
2014-07-11 Gary Benson <gbenson@redhat.com>
* amd64-linux-nat.c: Comment and whitespace changes.
* i386-linux-nat.c: Comment and whitespace changes.
2014-07-11 Gary Benson <gbenson@redhat.com>
* amd64-linux-nat.c (x86_linux_create_target): New function.

View File

@ -277,8 +277,11 @@ amd64_linux_store_inferior_registers (struct target_ops *ops,
}
}
/* Support for debug registers. */
/* Get debug register REGNUM value from only the one LWP of PTID. */
static unsigned long
x86_linux_dr_get (ptid_t ptid, int regnum)
{

View File

@ -732,7 +732,7 @@ update_debug_registers_callback (struct lwp_info *lwp, void *arg)
return 0;
}
/* Set DR_CONTROL to ADDR in all LWPs of the current inferior. */
/* Set DR_CONTROL to CONTROL in all LWPs of the current inferior. */
static void
x86_linux_dr_set_control (unsigned long control)
@ -775,9 +775,16 @@ x86_linux_prepare_to_resume (struct lwp_info *lwp)
= i386_debug_reg_state (ptid_get_pid (lwp->ptid));
int i;
/* See amd64_linux_prepare_to_resume for Linux kernel note on
i386_linux_dr_set calls ordering. */
/* On Linux kernel before 2.6.33 commit
72f674d203cd230426437cdcf7dd6f681dad8b0d
if you enable a breakpoint by the DR_CONTROL bits you need to have
already written the corresponding DR_FIRSTADDR...DR_LASTADDR registers.
Ensure DR_CONTROL gets written as the very last register here. */
/* Clear DR_CONTROL first. In some cases, setting DR0-3 to a
value that doesn't match what is enabled in DR_CONTROL
results in EINVAL. */
x86_linux_dr_set (lwp->ptid, DR_CONTROL, 0);
for (i = DR_FIRSTADDR; i <= DR_LASTADDR; i++)
@ -792,6 +799,8 @@ x86_linux_prepare_to_resume (struct lwp_info *lwp)
clear_status = 1;
}
/* If DR_CONTROL is supposed to be zero, we've already set it
above. */
if (state->dr_control_mirror != 0)
x86_linux_dr_set (lwp->ptid, DR_CONTROL, state->dr_control_mirror);