Use getenv instead of gdb_environ on mi-cmd-env.c

This is a spinoff of
<https://sourceware.org/ml/gdb-patches/2017-06/msg00437.html>.
mi-cmd-env.c is using the whole gdb_environ machinery in order to
access just one variable, which can be easily replaced by a simple
call to getenv.  This patch does that, and doesn't cause regressions.

gdb/ChangeLog:
2017-06-18  Sergio Durigan Junior  <sergiodj@redhat.com>

	* mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of
	gdb_environ to access an environment variable.
This commit is contained in:
Sergio Durigan Junior 2017-06-16 18:10:27 -04:00
parent 65ce7763df
commit 1c8e01c960
2 changed files with 9 additions and 8 deletions

View File

@ -1,3 +1,8 @@
2017-06-19 Sergio Durigan Junior <sergiodj@redhat.com>
* mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of
gdb_environ to access an environment variable.
2017-06-18 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
* nat/linux-ptrace.c (linux_fork_to_function): Add cast to

View File

@ -270,21 +270,17 @@ mi_cmd_inferior_tty_show (const char *command, char **argv, int argc)
void
_initialize_mi_cmd_env (void)
{
struct gdb_environ *environment;
const char *env;
/* We want original execution path to reset to, if desired later.
At this point, current inferior is not created, so cannot use
current_inferior ()->environment. Also, there's no obvious
place where this code can be moved such that it surely run
before any code possibly mangles original PATH. */
environment = make_environ ();
init_environ (environment);
env = get_in_environ (environment, path_var_name);
current_inferior ()->environment. We use getenv here because it
is not necessary to create a whole new gdb_environ just for one
variable. */
env = getenv (path_var_name);
/* Can be null if path is not set. */
if (!env)
env = "";
orig_path = xstrdup (env);
free_environ (environment);
}