From 1daad298d699383bb4f35aa919a1acfa0ab8e16c Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 22 Nov 2017 16:50:53 +0000 Subject: [PATCH] [testsuite] Pass pthreads in prepare_for_testing "pthreads" in the right flag to pass in prepare_for_testing to linker, instead of additional_flags. Without this patch, the test case can't be complied by clang. gdb compile failed, clang: warning: -lpthread: 'linker' input unused gdb/testsuite: 2017-11-22 Yao Qi * gdb.base/info-os.exp: Pass pthreads. * gdb.multi/multi-attach.exp: Likewise. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/info-os.exp | 2 +- gdb/testsuite/gdb.multi/multi-attach.exp | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0bb2391924..535cf1bf2e 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-11-22 Yao Qi + + * gdb.base/info-os.exp: Pass pthreads. + * gdb.multi/multi-attach.exp: Likewise. + 2017-11-22 Yao Qi * gdb.dwarf2/pr10770.exp: Remove code skipping non-gcc diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp index 574da26c33..3267eec9da 100644 --- a/gdb/testsuite/gdb.base/info-os.exp +++ b/gdb/testsuite/gdb.base/info-os.exp @@ -28,7 +28,7 @@ if [gdb_skip_xml_test] then { } # Compile test program. -if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}] } { +if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] } { fail "cannot compile test program" return -1 } diff --git a/gdb/testsuite/gdb.multi/multi-attach.exp b/gdb/testsuite/gdb.multi/multi-attach.exp index 9397f85297..0e54b4fa52 100644 --- a/gdb/testsuite/gdb.multi/multi-attach.exp +++ b/gdb/testsuite/gdb.multi/multi-attach.exp @@ -23,7 +23,7 @@ if {![can_spawn_for_attach]} { return 0 } -if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}]} { +if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}]} { return -1 }