OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ARI: Remove true/false checks 

These don't make sense with C++.

gdb/ChangeLog:
2016-10-13  Pedro Alves  <palves@redhat.com>

	* contrib/ari/gdb_ari.sh (boolean): Suggest bool instead.
	(false, true): Remove checks.
This commit is contained in:
Pedro Alves 2016-10-13 17:59:26 +01:00
parent 5ad9dba751
commit 1f2e9c5e3b
2 changed files with 6 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2016-10-13 Pedro Alves <palves@redhat.com>
* contrib/ari/gdb_ari.sh (boolean): Suggest bool instead.
(false, true): Remove checks.
2016-10-12 Tom Tromey <tom@tromey.com>
* machoread.c (macho_symfile_read_all_oso): Use std::string.

22
gdb/contrib/ari/gdb_ari.sh Normal file → Executable file
View File

@ -1136,7 +1136,7 @@ Do not use strnicmp(), instead use strncasecmp()"
# Boolean expressions and conditionals
BEGIN { doc["boolean"] = "\
Do not use `boolean'\'', use `int'\'' instead"
Do not use `boolean'\'', use `bool'\'' instead"
category["boolean"] = ari_regression
}
/(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
@ -1145,26 +1145,6 @@ Do not use `boolean'\'', use `int'\'' instead"
}
}
BEGIN { doc["false"] = "\
Definitely do not use `false'\'' in boolean expressions"
category["false"] = ari_regression
}
/(^|[^_[:alnum:]])false([^_[:alnum:]]|$)/ {
if (is_yacc_or_lex == 0) {
fail("false")
}
}
BEGIN { doc["true"] = "\
Do not try to use `true'\'' in boolean expressions"
category["true"] = ari_regression
}
/(^|[^_[:alnum:]])true([^_[:alnum:]]|$)/ {
if (is_yacc_or_lex == 0) {
fail("true")
}
}
# Typedefs that are either redundant or can be reduced to `struct
# type *''.
# Must be placed before if assignment otherwise ARI exceptions