OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

alpha: Warn DT_TEXTREL with -M

Browse Source 
This fixes:

FAIL: DT_TEXTREL map file warning

	* elf64-alpha.c (alpha_elf_reloc_entry): Replace reltext with
	sec.
	(elf64_alpha_check_relocs): Set sec instead of reltext.  Warn
	DT_TEXTREL with -M.
	(elf64_alpha_calc_dynrel_sizes): Warn DT_TEXTREL with -M.
This commit is contained in:
H.J. Lu 2020-04-21 05:20:11 -07:00
parent e04f33c09f
commit 1f7f2abbc3
2 changed files with 30 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/ChangeLog
View File

@ -1,3 +1,11 @@
2020-04-21 H.J. Lu <hongjiu.lu@intel.com>
* elf64-alpha.c (alpha_elf_reloc_entry): Replace reltext with
sec.
(elf64_alpha_check_relocs): Set sec instead of reltext. Warn
DT_TEXTREL with -M.
(elf64_alpha_calc_dynrel_sizes): Warn DT_TEXTREL with -M.
2020-04-21 Nick Clifton <nickc@redhat.com>
* po/sr.po: Updated Serbian translation.

31
bfd/elf64-alpha.c
View File

@ -144,14 +144,14 @@ struct alpha_elf_reloc_entry
/* Which .reloc section? */
asection *srel;
/* What kind of relocation? */
unsigned int rtype;
/* Is this against read-only section? */
unsigned int reltext : 1;
/* Which section this relocation is against? */
asection *sec;
/* How many did we find? */
unsigned long count;
/* What kind of relocation? */
unsigned int rtype;
};
struct alpha_elf_link_hash_entry
@ -1998,9 +1998,9 @@ elf64_alpha_check_relocs (bfd *abfd, struct bfd_link_info *info,
return FALSE;
rent->srel = sreloc;
rent->sec = sec;
rent->rtype = r_type;
rent->count = 1;
rent->reltext = (sec->flags & SEC_READONLY) != 0;
rent->next = h->reloc_entries;
h->reloc_entries = rent;
@ -2014,7 +2014,13 @@ elf64_alpha_check_relocs (bfd *abfd, struct bfd_link_info *info,
loaded into memory, we need a RELATIVE reloc. */
sreloc->size += sizeof (Elf64_External_Rela);
if (sec->flags & SEC_READONLY)
info->flags |= DF_TEXTREL;
{
info->flags |= DF_TEXTREL;
info->callbacks->minfo
(_("%pB: dynamic relocation against `%pT' in "
"read-only section `%pA'\n"),
sec->owner, h->root.root.root.string, sec);
}
}
}
}
@ -2699,10 +2705,17 @@ elf64_alpha_calc_dynrel_sizes (struct alpha_elf_link_hash_entry *h,
bfd_link_pie (info));
if (entries)
{
asection *sec = relent->sec;
relent->srel->size +=
entries * sizeof (Elf64_External_Rela) * relent->count;
if (relent->reltext)
info->flags |= DT_TEXTREL;
if ((sec->flags & SEC_READONLY) != 0)
{
info->flags |= DT_TEXTREL;
info->callbacks->minfo
(_("%pB: dynamic relocation against `%pT' in "
"read-only section `%pA'\n"),
sec->owner, h->root.root.root.string, sec);
}
}
}