OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Constify argument to make_tempname and make_tempdir 

This constifies the argument to make_tempname and make_tempdir,
removing some casts.

I initially thought that this obsoleted the allocation in
write_archive, but write_archive closes the BFD before using the name,
so this appears not to be the case.

binutils/ChangeLog
2019-09-11  Tom Tromey  <tom@tromey.com>

	* objcopy.c (copy_archive): Update.
	* bucomm.h (make_tempname, make_tempdir): Make argument const.
	* bucomm.c (make_tempname, make_tempdir): Make argument const.
This commit is contained in:
Tom Tromey 2019-09-08 09:53:43 -06:00
parent 0a4632b563
commit 1ff5d5c463
4 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
binutils/ChangeLog
View File

@ -1,3 +1,9 @@
2019-09-11 Tom Tromey <tom@tromey.com>
* objcopy.c (copy_archive): Update.
* bucomm.h (make_tempname, make_tempdir): Make argument const.
* bucomm.c (make_tempname, make_tempdir): Make argument const.
2019-09-11 Alan Modra <amodra@gmail.com>
PR 24907

4
binutils/bucomm.c
View File

@ -532,7 +532,7 @@ template_in_dir (const char *path)
as FILENAME. */
char *
make_tempname (char *filename)
make_tempname (const char *filename)
{
char *tmpname = template_in_dir (filename);
int fd;
@ -558,7 +558,7 @@ make_tempname (char *filename)
directory containing FILENAME. */
char *
make_tempdir (char *filename)
make_tempdir (const char *filename)
{
char *tmpname = template_in_dir (filename);

4
binutils/bucomm.h
View File

@ -51,8 +51,8 @@ int display_info (void);
void print_arelt_descr (FILE *, bfd *, bfd_boolean, bfd_boolean);
char *make_tempname (char *);
char *make_tempdir (char *);
char *make_tempname (const char *);
char *make_tempdir (const char *);
bfd_vma parse_vma (const char *, const char *);

2
binutils/objcopy.c
View File

@ -3311,7 +3311,7 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target,
}
/* Make a temp directory to hold the contents. */
dir = make_tempdir ((char *) bfd_get_filename (obfd));
dir = make_tempdir (bfd_get_filename (obfd));
if (dir == NULL)
fatal (_("cannot create tempdir for archive copying (error: %s)"),
strerror (errno));