From 20ced3e4887e055380433f1cb7f45cc411cba5eb Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Thu, 7 Mar 2013 18:50:53 +0000 Subject: [PATCH] breakpoint.c: fix -Wpointer-sign MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit $ make WERROR_CFLAGS="-Wpointer-sign -Werror" breakpoint.o 2>&1 1>/dev/null ../../src/gdb/breakpoint.c: In function ‘breakpoint_xfer_memory’: ../../src/gdb/breakpoint.c:1578:2: error: pointer targets in passing argument 3 of ‘gdbarch_breakpoint_from_pc’ differ in signedness [-Werror=pointer-sign] In file included from ../../src/gdb/defs.h:644:0, from ../../src/gdb/breakpoint.c:20: ../../src/gdb/gdbarch.h:495:25: note: expected ‘int *’ but argument is of type ‘unsigned int *’ target_info.placed_size is an 'int', and gdbarch_breakpoint_from_pc takes an int too. gdb/ 2013-03-07 Pedro Alves * breakpoint.c.c (breakpoint_xfer_memory): Change type of local to int. --- gdb/ChangeLog | 5 +++++ gdb/breakpoint.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index daa4089763..36e8af356b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-03-07 Pedro Alves + + * breakpoint.c.c (breakpoint_xfer_memory): Change type of local to + int. + 2013-03-07 Pedro Alves * stap-probe.c (handle_stap_probe): Add cast to char*. diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index fb57a57d88..d71bb36cad 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -1567,7 +1567,7 @@ breakpoint_xfer_memory (gdb_byte *readbuf, gdb_byte *writebuf, struct gdbarch *gdbarch = bl->gdbarch; const unsigned char *bp; CORE_ADDR placed_address = bl->target_info.placed_address; - unsigned placed_size = bl->target_info.placed_size; + int placed_size = bl->target_info.placed_size; /* Update the shadow with what we want to write to memory. */ memcpy (bl->target_info.shadow_contents + bptoffset,