From 213291361b4ddb2d05b8c89bf47d23ca4306912e Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 12 Mar 2020 13:32:15 -0600 Subject: [PATCH] Change gdbsupport not to rely on BFD This changes gdbsupport so that it no longer relies on BFD. This is a precursor to making gdbserver use the already-built gdbsupport, because building gdbserver should not require BFD to be built. The most notable change here is that CORE_ADDR is always a 64-bit type. This makes it so that gdb acts as if it were always built in 64-bit mode. ChangeLog 2020-03-12 Tom Tromey * Makefile.in: Rebuild. * Makefile.def (gdbsupport): Don't depend on bfd. gdbsupport/ChangeLog 2020-03-12 Tom Tromey * common-types.h: Remove GDBSERVER code. (gdb_byte, CORE_ADDR, LONGEST, ULONGEST): Redefine. * common-defs.h: Remove GDBSERVER code. --- ChangeLog | 5 +++++ Makefile.def | 2 -- Makefile.in | 2 -- gdbsupport/ChangeLog | 6 ++++++ gdbsupport/common-defs.h | 16 ---------------- gdbsupport/common-types.h | 32 +++++--------------------------- 6 files changed, 16 insertions(+), 47 deletions(-) diff --git a/ChangeLog b/ChangeLog index f36e28ed7c..9fb604e359 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2020-03-12 Tom Tromey + + * Makefile.in: Rebuild. + * Makefile.def (gdbsupport): Don't depend on bfd. + 2020-03-12 Tom Tromey * Makefile.in: Rebuild. diff --git a/Makefile.def b/Makefile.def index 7a27220d77..3162199ac7 100644 --- a/Makefile.def +++ b/Makefile.def @@ -421,10 +421,8 @@ dependencies = { module=all-libgui; on=all-tcl; }; dependencies = { module=all-libgui; on=all-tk; }; dependencies = { module=all-libgui; on=all-itcl; }; -dependencies = { module=configure-gdbsupport; on=configure-bfd; }; dependencies = { module=configure-gdbsupport; on=configure-gnulib; }; dependencies = { module=configure-gdbsupport; on=configure-intl; }; -dependencies = { module=all-gdbsupport; on=all-bfd; }; dependencies = { module=all-gdbsupport; on=all-gnulib; }; dependencies = { module=all-gdbsupport; on=all-intl; }; diff --git a/Makefile.in b/Makefile.in index e09bb1d311..d24dfdfb86 100644 --- a/Makefile.in +++ b/Makefile.in @@ -52454,9 +52454,7 @@ all-gdb: maybe-all-opcodes all-gdb: maybe-all-libdecnumber all-gdb: maybe-all-libctf all-gdbserver: maybe-all-libiberty -configure-gdbsupport: maybe-configure-bfd configure-gdbsupport: maybe-configure-intl -all-gdbsupport: maybe-all-bfd all-gdbsupport: maybe-all-intl configure-gprof: maybe-configure-intl all-gprof: maybe-all-libiberty diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index 4b678eb06c..c471726af5 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,9 @@ +2020-03-12 Tom Tromey + + * common-types.h: Remove GDBSERVER code. + (gdb_byte, CORE_ADDR, LONGEST, ULONGEST): Redefine. + * common-defs.h: Remove GDBSERVER code. + 2020-03-12 Simon Marchi * selftest.m4: Moved from gdb/. diff --git a/gdbsupport/common-defs.h b/gdbsupport/common-defs.h index a5c57de2f2..65500ce763 100644 --- a/gdbsupport/common-defs.h +++ b/gdbsupport/common-defs.h @@ -20,20 +20,6 @@ #ifndef COMMON_COMMON_DEFS_H #define COMMON_COMMON_DEFS_H -#ifdef GDBSERVER - -#include - -#undef PACKAGE_NAME -#undef PACKAGE -#undef PACKAGE_VERSION -#undef PACKAGE_STRING -#undef PACKAGE_TARNAME - -#include - -#else /* GDBSERVER */ - #include #undef PACKAGE_NAME @@ -44,8 +30,6 @@ #include "gnulib/config.h" -#endif /* GDBSERVER */ - /* From: https://www.gnu.org/software/gnulib/manual/html_node/stdint_002eh.html diff --git a/gdbsupport/common-types.h b/gdbsupport/common-types.h index 61099b4e25..f5b2f3d249 100644 --- a/gdbsupport/common-types.h +++ b/gdbsupport/common-types.h @@ -20,40 +20,18 @@ #ifndef COMMON_COMMON_TYPES_H #define COMMON_COMMON_TYPES_H -#ifdef GDBSERVER +#include /* * A byte from the program being debugged. */ typedef unsigned char gdb_byte; -typedef unsigned long long CORE_ADDR; - -typedef long long LONGEST; -typedef unsigned long long ULONGEST; - -#else /* GDBSERVER */ - -#include "bfd.h" - -/* * A byte from the program being debugged. */ -typedef bfd_byte gdb_byte; - /* * An address in the program being debugged. Host byte order. */ -typedef bfd_vma CORE_ADDR; +typedef uint64_t CORE_ADDR; -/* This is to make sure that LONGEST is at least as big as CORE_ADDR. */ +/* LONGEST must be at least as big as CORE_ADDR. */ -#ifdef BFD64 - -typedef BFD_HOST_64_BIT LONGEST; -typedef BFD_HOST_U_64_BIT ULONGEST; - -#else /* No BFD64 */ - -typedef long long LONGEST; -typedef unsigned long long ULONGEST; - -#endif /* No BFD64 */ -#endif /* GDBSERVER */ +typedef int64_t LONGEST; +typedef uint64_t ULONGEST; /* * The largest CORE_ADDR value. */ #define CORE_ADDR_MAX (~(CORE_ADDR) 0)