OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove ARI check for multiple calls to warning or error 

ARI has a check for multiple calls to warning or error, suggesting
that they be combined into a single call.  This triggers at three
places in gdb -- throw_bad_regnum_error, guile_repl_command, and the
end of value_cast -- and after examining these, I think they all make
sense as-is.  Instead, it makes sense to remove this check from ARI.

gdb/ChangeLog
2019-12-13  Tom Tromey  <tromey@adacore.com>

	* contrib/ari/gdb_ari.sh: Remove check for multiple calls to
	warning or error.

Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d
This commit is contained in:
Tom Tromey 2019-12-12 10:40:08 -07:00
parent 93537683e7
commit 234c306803
2 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove check for multiple calls to
warning or error.
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".

15
gdb/contrib/ari/gdb_ari.sh
View File

@ -619,21 +619,6 @@ Do not use NORETURN, use ATTRIBUTE_NORETURN instead"
# General problems
BEGIN { doc["multiple messages"] = "\
Do not use multiple calls to warning or error, instead use a single call"
category["multiple messages"] = ari_gettext
}
FNR == 1 {
warning_fnr = -1
}
/(^|[^_[:alnum:]])(warning|error)[[:space:]]*\(/ {
if (FNR == warning_fnr + 1) {
fail("multiple messages")
} else {
warning_fnr = FNR
}
}
# Commented out, but left inside sources, just in case.
# BEGIN { doc["inline"] = "\
# Do not use the inline attribute; \