OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix is_remote check in gdb.base/remote.exp 

1. Otherwise, when the native-gdbserver board stops setting is_remote,
   this test would stop running there.

2. Makes the test run with --target_board=native-extended-gdbserver
   too.

gdb/testsuite/ChangeLog:
2017-10-13  Pedro Alves  <palves@redhat.com>

	* gdb.base/remote.exp: Check gdb_protocol instead of is_remote.
	(top level): Add comment.
This commit is contained in:
Pedro Alves 2017-10-13 10:48:42 +01:00
parent cc77b1dc33
commit 23fb630af0
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp: Check gdb_protocol instead of is_remote.
(top level): Add comment.
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/remote.exp (top level): Fix comment typo and add

11
gdb/testsuite/gdb.base/remote.exp
View File

@ -13,10 +13,9 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# test only on a remote target board
if {! [is_remote target]} {
# Test only on boards that actually use the remote protocol.
if {[target_info gdb_protocol] != "remote"
&& [target_info gdb_protocol] != "extended-remote"} {
return
}
@ -103,6 +102,10 @@ proc gdb_load_timed {executable class writesize} {
pass $test
}
# These download tests won't actually download anything on !is_remote
# target boards, but we run them anyway because it's simpler, and
# harmless.
# Typically about 400-1 bytes can be downloaded
gdb_load_timed $binfile "limit" 398
gdb_load_timed $binfile "limit" 400