OpenE2K/binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PR22764][LD][AARCH64]Allow R_AARCH64_ABS16 and R_AARCH64_ABS32 against absolution symbol or undefine symbol in shared object.

Browse Source 
The assumption that R_AARCH64_ABS16 and R_AARCH64_ABS32 relocation in LP64 abi
will be used to generate an address does not hold for absolute symbol.
In this case, it is a value fixed at static linking time.

The condition to check the relocations is relax to allow absolute symbol and
undefined symbol case.

bfd/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* elfnn-aarch64.c (elfNN_aarch64_check_relocs): Relax the
	R_AARCH64_ABS32 and R_AARCH64_ABS16 for absolute symbol. Apply the
	check for writeable section as well.

ld/

2018-02-05  Renlin Li  <renlin.li@arm.com>

	PR ld/22764
	* testsuite/ld-aarch64/emit-relocs-258.s: Define symbol as an address.
	* testsuite/ld-aarch64/emit-relocs-259.s: Likewise.
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr22764.s: New.
	* testsuite/ld-aarch64/pr22764.d: New.
This commit is contained in:
Renlin Li 2018-02-03 13:18:17 +00:00
parent f3b91ed8f9
commit 279b2f9416
8 changed files with 56 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2018-02-05 Renlin Li <renlin.li@arm.com>
PR ld/22764
* elfnn-aarch64.c (elfNN_aarch64_check_relocs): Relax the
R_AARCH64_ABS32 and R_AARCH64_ABS16 for absolute symbol. Apply the
check for writeable section as well.
2018-02-05 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22782

15
bfd/elfnn-aarch64.c
View File

@ -7189,10 +7189,19 @@ elfNN_aarch64_check_relocs (bfd *abfd, struct bfd_link_info *info,
#if ARCH_SIZE == 64
case BFD_RELOC_AARCH64_32:
#endif
if (bfd_link_pic (info)
&& (sec->flags & SEC_ALLOC) != 0
&& (sec->flags & SEC_READONLY) != 0)
if (bfd_link_pic (info) && (sec->flags & SEC_ALLOC) != 0)
{
if (h != NULL
/* This is an absolute symbol. It represents a value instead
of an address. */
&& ((h->root.type == bfd_link_hash_defined
&& bfd_is_abs_section (h->root.u.def.section))
/* This is an undefined symbol. */
|| h->root.type == bfd_link_hash_undefined))
break;
/* For local symbols, defined global symbols in a non-ABS section,
it is assumed that the value is an address. */
int howto_index = bfd_r_type - BFD_RELOC_AARCH64_RELOC_START;
_bfd_error_handler
/* xgettext:c-format */

8
ld/ChangeLog
View File

@ -1,3 +1,11 @@
2018-02-05 Renlin Li <renlin.li@arm.com>
PR ld/22764
* testsuite/ld-aarch64/emit-relocs-258.s: Define symbol as an address.
* testsuite/ld-aarch64/emit-relocs-259.s: Likewise.
* testsuite/ld-aarch64/pr22764.s: New.
* testsuite/ld-aarch64/pr22764.d: New.
2018-02-05 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22782

1
ld/testsuite/ld-aarch64/aarch64-elf.exp
View File

@ -285,6 +285,7 @@ run_dump_test "pr17415"
run_dump_test_lp64 "tprel_g2_overflow"
run_dump_test "tprel_add_lo12_overflow"
run_dump_test "protected-data"
run_dump_test_lp64 "pr22764"
# ifunc tests
run_dump_test "ifunc-1"

3
ld/testsuite/ld-aarch64/emit-relocs-258.s
View File

@ -1,5 +1,6 @@
.global dummy
.text
dummy:
ldr x0, .L1
.L1:

3
ld/testsuite/ld-aarch64/emit-relocs-259.s
View File

@ -1,5 +1,6 @@
.global dummy
.text
dummy:
ldr x0, .L1
.L1:

18
ld/testsuite/ld-aarch64/pr22764.d Normal file
View File

@ -0,0 +1,18 @@
#source: pr22764.s
#ld: -shared -T relocs.ld -defsym sym_abs1=0x1 -defsym sym_abs2=0x2 -defsym sym_abs3=0x3 -e0 --emit-relocs
#notarget: aarch64_be-*-*
#objdump: -dr
#...
Disassembly of section \.text:
0000000000010000 \<\.text\>:
10000: d503201f nop
...
10004: R_AARCH64_ABS64 sym_abs1
1000c: 00000002 \.word 0x00000002
1000c: R_AARCH64_ABS32 sym_abs2
10010: 0003 \.short 0x0003
10010: R_AARCH64_ABS16 sym_abs3
10012: 0000 \.short 0x0000
10014: d503201f nop

6
ld/testsuite/ld-aarch64/pr22764.s Normal file
View File

@ -0,0 +1,6 @@
.text
nop
.xword sym_abs1
.word sym_abs2
.short sym_abs3
nop