OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PR23169 bogus test 

The testcase isn't valid.  If it happens to run on your target, you're
lucky.

	PR 23169
	* testsuite/ld-ifunc/ifunc.exp: Don't run pr23169 tests on
	powerpc.  Comment.
This commit is contained in:
Alan Modra 2018-06-26 14:30:16 +09:30
parent 2db70efacd
commit 2822b09ff6
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ld/ChangeLog
View File

@ -1,3 +1,9 @@
2018-06-26 Alan Modra <amodra@gmail.com>
PR 23169
* testsuite/ld-ifunc/ifunc.exp: Don't run pr23169 tests on
powerpc. Comment.
2018-06-26 Alan Modra <amodra@gmail.com>
* testsuite/ld-bootstrap/bootstrap.exp: Use parentheses rather

15
ld/testsuite/ld-ifunc/ifunc.exp
View File

@ -702,6 +702,19 @@ run_ld_link_exec_tests [list \
"pr18841cn" \
"pr18841.out" \
] \
]
# The pr23169 testcase is not valid. In general, you can't call ifunc
# resolvers in another binary unless you know what you're doing. In
# particular you must ensure that the binary containing the resolver
# is relocated before the resolver is called (for example, the
# function addresses returned by the resolver may be loaded from the
# GOT).
# That does not happen for the pr23169 testcase where the resolver is
# in the executable (which is relocated last by ld.so).
if { [isnative]
&& ![istarget "powerpc-*-*"] } {
run_ld_link_exec_tests [list \
[list \
"Run pr23169a" \
"$NOPIE_LDFLAGS -Wl,--no-as-needed tmpdir/libpr23169a.so" \
@ -756,4 +769,4 @@ run_ld_link_exec_tests [list \
"pass.out" \
"-fPIE -O2 -g" \
] \
]
]}