OpenE2K
/
binutils-gdb
12
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix AArch64 unintialized variable which can cause diagnostic failures. 

This patch fixes an uninitialized memory issue that can under certain
circumstances turn an error into a warning because non_fatal was not initialised
in all cases.

Verified using valgrind.

gas/config/tc-aarch64.c

	PR binutils/21446
	* tc-aarch64.c (record_operand_error, record_operand_error_with_data):
	  Initialize non_fatal.
This commit is contained in:
Tamar Christina 2018-06-07 11:53:13 +01:00
parent 63bad7b636
commit 2a9b2c1abe
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gas/ChangeLog
View File

@ -1,3 +1,9 @@
2018-06-08 Tamar Christina <tamar.christina@arm.com>
PR binutils/21446
* tc-aarch64.c (record_operand_error, record_operand_error_with_data):
Initialize non_fatal.
2018-06-06 Sameera Deshpande <sameera.deshpande@linaro.org>
* config/tc-aarch64.c (aarch64_cpus): Add support of ARMv8.4 in

2
gas/config/tc-aarch64.c
View File

@ -4400,6 +4400,7 @@ record_operand_error (const aarch64_opcode *opcode, int idx,
info.index = idx;
info.kind = kind;
info.error = error;
info.non_fatal = FALSE;
record_operand_error_info (opcode, &info);
}
@ -4415,6 +4416,7 @@ record_operand_error_with_data (const aarch64_opcode *opcode, int idx,
info.data[0] = extra_data[0];
info.data[1] = extra_data[1];
info.data[2] = extra_data[2];
info.non_fatal = FALSE;
record_operand_error_info (opcode, &info);
}